CVS: cvs.openbsd.org: src

2019-11-27 Thread Ayaka Koshibe
CVSROOT:/cvs
Module name:src
Changes by: akosh...@cvs.openbsd.org2019/11/27 20:08:21

Modified files:
lib/libpcap: pcap.h 

Log message:
Fix typo in comment in struct pcap_pkthdr



CVS: cvs.openbsd.org: src

2019-11-27 Thread Ayaka Koshibe
CVSROOT:/cvs
Module name:src
Changes by: akosh...@cvs.openbsd.org2019/11/27 10:37:32

Modified files:
usr.sbin/switchd: ofp13.c 
usr.sbin/tcpdump: print-ofp.c 
sys/net: switchofp.c 

Log message:
OpenFlow 1.3 defines packet header patterns of interest using TLVs (OXMs)
that represent various header fields. One place where OXMs are used is in
the sef_field action, which contains one OXM representing the header field
to set, followed by padding to align the action in the OpenFlow message to
64 bits. Currently, we assume that a set_field action can contain multiple
OXMs and that they do not need to be padded.

This matches the way we handle OpenFlow messages that contain set_field
actions so that we follow the specs.

OK ori claudio



CVS: cvs.openbsd.org: src

2019-11-21 Thread Ayaka Koshibe
CVSROOT:/cvs
Module name:src
Changes by: akosh...@cvs.openbsd.org2019/11/21 10:24:15

Modified files:
sys/net: switchofp.c 

Log message:
Fix comment typo: specification



CVS: cvs.openbsd.org: src

2019-11-20 Thread Ayaka Koshibe
CVSROOT:/cvs
Module name:src
Changes by: akosh...@cvs.openbsd.org2019/11/20 23:54:26

Modified files:
sys/net: switchofp.c 

Log message:
Remove duplicate #define OFP_ALIGNMENT



CVS: cvs.openbsd.org: src

2019-11-20 Thread Ayaka Koshibe
CVSROOT:/cvs
Module name:src
Changes by: akosh...@cvs.openbsd.org2019/11/20 23:22:57

Modified files:
usr.sbin/switchd: ofp13.c ofp_common.c switchd.h 

Log message:
Remove arguments from ofp13_flowmod() which are unused and unnecessary.

ok guenther@



CVS: cvs.openbsd.org: src

2019-05-12 Thread Ayaka Koshibe
CVSROOT:/cvs
Module name:src
Changes by: akosh...@cvs.openbsd.org2019/05/12 10:24:44

Modified files:
sys/net: if_switch.c 

Log message:
Unused switch_port variable.



CVS: cvs.openbsd.org: src

2019-05-10 Thread Ayaka Koshibe
CVSROOT:/cvs
Module name:src
Changes by: akosh...@cvs.openbsd.org2019/05/10 12:27:50

Modified files:
sbin/ifconfig  : ifconfig.8 
share/man/man4 : bridge.4 switch.4 

Log message:
Document port protection support in switch(4). Also add SIOCBRDGSIFPROT to
list of ioctls in bridge(4).

OK ccardenas@ kn@ phessler@



CVS: cvs.openbsd.org: src

2019-05-10 Thread Ayaka Koshibe
CVSROOT:/cvs
Module name:src
Changes by: akosh...@cvs.openbsd.org2019/05/10 09:13:38

Modified files:
sys/net: if_switch.c if_switch.h switchofp.c 

Log message:
Add port protection support to switch(4). The behavior copies that of
bridge(4), where the SIOCBRDGSIFPROT ioctl can be used to add a port to up
to 31 protected domains. This allows configuration by specifying a list of
IDs to the 'protected' option in ifconfig(8):

# ifconfig switch0 protected pair1 1,2,..

Domain membership is checked for unicast, flooded (broadcast), and
local (host-network-bound, e.g. trunk) traffic.

OK benno@



CVS: cvs.openbsd.org: src

2019-05-05 Thread Ayaka Koshibe
CVSROOT:/cvs
Module name:src
Changes by: akosh...@cvs.openbsd.org2019/05/05 15:33:00

Modified files:
usr.sbin/switchd: ofp10.c ofp13.c packet.c switchd.h 

Log message:
switchd(8) will sometimes not save a copy of a packet needing forwarding
even when a switch(4) instance requires it to supply it. Cases where this
can happen are: if the copy of the packet recieved from the switch is too
short (source/destination pairs can't be recovered), is non-unicast, or
when switchd has to fall back to flooding traffic.

Factor out the check for short packets, stopping before forwarding
decisions are made if the full packet is needed by the switch. Set the
packet buffer early for cases where it is needed otherwise.

Also replace a few bzero's with memset's.

Diff based on one by guenther@
OK phessler@



CVS: cvs.openbsd.org: src

2018-11-10 Thread Ayaka Koshibe
CVSROOT:/cvs
Module name:src
Changes by: akosh...@cvs.openbsd.org2018/11/10 17:11:01

Modified files:
usr.sbin/switchd: switchd.conf.5 

Log message:
Mention the default address (0.0.0.0) and port (6653) that switchd(8)
uses.

OK nayden@ kn@



CVS: cvs.openbsd.org: src

2018-11-08 Thread Ayaka Koshibe
CVSROOT:/cvs
Module name:src
Changes by: akosh...@cvs.openbsd.org2018/11/08 10:48:06

Modified files:
usr.sbin/switchd: parse.y 

Log message:
Set sc_server.srv_tls value for "LISTEN ON STRING opttls".

OK phessler@



CVS: cvs.openbsd.org: src

2018-11-08 Thread Ayaka Koshibe
CVSROOT:/cvs
Module name:src
Changes by: akosh...@cvs.openbsd.org2018/11/08 10:12:12

Modified files:
usr.sbin/switchd: parse.y types.h 

Log message:
Currently, switchd(8) defaults to listening on port 6633, which was the
defacto port value used by OpenFlow. A decent chunk of OpenFlow
controllers have switched over to the IANA standardized OpenFlow port,
6653. switchd(8) also randomizes its listen ports when one is not
specified in switchd.conf(5).conf.

Consolidate the #defines for port values, and set a default listen port.

OK phessler@ claudio@, kn@ with separate switchd.conf(5) update



CVS: cvs.openbsd.org: src

2018-10-24 Thread Ayaka Koshibe
CVSROOT:/cvs
Module name:src
Changes by: akosh...@cvs.openbsd.org2018/10/24 12:06:22

Modified files:
usr.sbin/switchctl: switchctl.c 

Log message:
As per advice from claudio@, further restrict the pledge in switchctl(8).
Only stdio is needed when running the 'show *' commands. Everything else is
only needed while parsing args and opening sockets.

OK claudio@ deraadt@ phessler@



CVS: cvs.openbsd.org: src

2018-10-21 Thread Ayaka Koshibe
CVSROOT:/cvs
Module name:src
Changes by: akosh...@cvs.openbsd.org2018/10/21 15:10:24

Modified files:
usr.sbin/switchctl: ofpclient.c parser.c switchctl.8 switchctl.c 

Log message:
Add the ability to query a switch(4) instance via its control device. Also
explicitly set the OpenFlow version during the handshake prior to a query.

Since switchctl(8) behaves like a controller in this case, a switch can't be
connected to switchd(8) while it is being queried in this way.

OK claudio@, tb@ and mestre@ for pledge changes



CVS: cvs.openbsd.org: src

2018-09-10 Thread Ayaka Koshibe
CVSROOT:/cvs
Module name:src
Changes by: akosh...@cvs.openbsd.org2018/09/10 07:21:39

Modified files:
usr.sbin/switchd: proc.c proc.h switchd.c 

Log message:
Mirror bluhm's fixes for proc.c daemons to dup /dev/null for child processes
in switchd(8).

OK henning@ bluhm@



CVS: cvs.openbsd.org: src

2018-09-09 Thread Ayaka Koshibe
CVSROOT:/cvs
Module name:src
Changes by: akosh...@cvs.openbsd.org2018/09/09 08:21:32

Modified files:
usr.sbin/switchd: ofp10.c ofp13.c 

Log message:
Make switchd(8) ignore PACKET_INs generated from looped traffic. Currently,
it responds to these messages with an invalid PACKET_OUT onto OFP*_PORT_ANY,
resulting in the switch responding with an error, causing switchd to
disconnect the switch.

OK phessler@ claudio@



CVS: cvs.openbsd.org: src

2018-08-21 Thread Ayaka Koshibe
CVSROOT:/cvs
Module name:src
Changes by: akosh...@cvs.openbsd.org2018/08/21 10:40:23

Modified files:
sys/net: switchofp.c 

Log message:
Fix alignment fault in switchd(8) on sparc64. Use memcpy to set oxm_value,
which isn't aligned to 64 bits.

Based on pointers from Ori Bernstein
Reported by Ryan Keating
ok yasuoka@ deraadt@



CVS: cvs.openbsd.org: src

2018-08-08 Thread Ayaka Koshibe
CVSROOT:/cvs
Module name:src
Changes by: akosh...@cvs.openbsd.org2018/08/08 21:35:19

Modified files:
sys/net: if.c 

Log message:
Currently, attempting to move an immovable lo(4) to a new rdomain will fail
with an EPERM, but the target rdomain will still be created.

Move the check for an lo(4)'s if_index/if_rdomain to before the creation of a
nonexisting target routing table.

ok benno@ claudio@ mpi@



CVS: cvs.openbsd.org: www

2018-06-11 Thread Ayaka Koshibe
CVSROOT:/cvs
Module name:www
Changes by: akosh...@cvs.openbsd.org2018/06/11 22:42:16

Modified files:
.  : events.html 
Added files:
papers : bsdcan2018-mininet.pdf 

Log message:
Add presentation slides from BSDCan2018



CVS: cvs.openbsd.org: src

2018-04-25 Thread Ayaka Koshibe
CVSROOT:/cvs
Module name:src
Changes by: akosh...@cvs.openbsd.org2018/04/26 00:58:50

Modified files:
sbin/ifconfig  : ifconfig.8 ifconfig.c 

Log message:
Add a '-tunneldomain' ifconfig(8) option as shorthand for 'tunneldomain 0'
to be consistent with the '-rdomain' option.

Suggested by dlg
OK benno, jca, kn, phessler, jmc



CVS: cvs.openbsd.org: www

2018-03-10 Thread Ayaka Koshibe
CVSROOT:/cvs
Module name:www
Changes by: akosh...@cvs.openbsd.org2018/03/11 00:03:12

Modified files:
.  : events.html 
Added files:
papers : asiabsdcon2018-mininet-paper.pdf 
 asiabsdcon2018-mininet-slides.pdf 

Log message:
Add slides and paper from AsiaBSD talk



CVS: cvs.openbsd.org: src

2018-02-22 Thread Ayaka Koshibe
CVSROOT:/cvs
Module name:src
Changes by: akosh...@cvs.openbsd.org2018/02/22 22:17:39

Modified files:
sbin/ifconfig  : ifconfig.8 ifconfig.c 

Log message:
Add unsetrdomain() and option -rdomain to return an interface to routing
domain 0.

OK phessler, henning, deraadt, stsp, benno