CVS: cvs.openbsd.org: www

2024-03-23 Thread Greg Steuck
CVSROOT:/cvs
Module name:www
Changes by: gne...@cvs.openbsd.org  2024/03/23 18:18:15

Modified files:
.  : 75.html 

Log message:
Fix a typo



CVS: cvs.openbsd.org: src

2023-12-23 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2023/12/23 23:35:05

Modified files:
usr.sbin/dev_mkdb: dev_mkdb.c 

Log message:
Rewrite dev_mkdb with FTS

This adds support for the devices in nested directories.

Pointers, review, and OK by semarie@



CVS: cvs.openbsd.org: src

2023-08-12 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2023/08/12 07:42:55

src/regress/libexec/ld.so/ldd

Update of /cvs/src/regress/libexec/ld.so/ldd
In directory cvs.openbsd.org:/cvs.d/hack/gnezdo/src/regress/libexec/ld.so/ldd

Log Message:
Directory /cvs/src/regress/libexec/ld.so/ldd added to the repository



CVS: cvs.openbsd.org: src

2023-06-22 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2023/06/22 22:36:49

Modified files:
sys/kern   : uipc_mbuf.c 

Log message:
Avoid division by 0 in m_pool_used

OK dlg@

Reported-by: syzbot+a377d5cd833c23434...@syzkaller.appspotmail.com



CVS: cvs.openbsd.org: src

2023-04-28 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2023/04/28 06:03:49

Modified files:
gnu/llvm/clang/lib/Driver/ToolChains: OpenBSD.cpp 

Log message:
Enable kernel-address sanitizer for clang openbsd target

OK deraadt@



CVS: cvs.openbsd.org: src

2023-04-27 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2023/04/27 17:16:18

Modified files:
sys/sys: syslog.h 

Log message:
Use __size_t which is available in syslog.h

Directly including sys/syslog.h would fail due to size_t
being unknown.

OK millert, miod



Re: CVS: cvs.openbsd.org: src

2023-04-27 Thread Greg Steuck
"Todd C. Miller"  writes:

>> Should I replicate this block into sys/syslog.h? That fixes the
>> problem
>> but clearly one can never tell what's gonna break with system
>> include
>> files.
>
> That should be OK but you could also just use __size_t in the
> function prototype.  We use __va_list in syslog.h instead of va_list
> for a similar reason.

I'm running this through make build just in case, but it seems to be
fixing the original problem. OK?

diff --git a/sys/sys/syslog.h b/sys/sys/syslog.h
index 063105952b1..c5f24339ecc 100644
--- a/sys/sys/syslog.h
+++ b/sys/sys/syslog.h
@@ -204,7 +204,7 @@ int setlogmask_r(int, struct syslog_data *);
 void   syslog_r(int, struct syslog_data *, const char *, ...)
  __attribute__((__format__(__syslog__,3,4)));
 void   vsyslog_r(int, struct syslog_data *, const char *, __va_list);
-intsendsyslog(const char *, size_t, int);
+intsendsyslog(const char *, __size_t, int);
 __END_DECLS
 
 #else /* !_KERNEL */



Re: CVS: cvs.openbsd.org: src

2023-04-27 Thread Greg Steuck
"Theo de Raadt"  writes:

> Can you dig deeper into why?

The easiest reproducer is to compile a file with a single
#include 

> Should syslog.h be pulling in sys/_types.h instead of machine/_types.h?

Neither of them seems to have the magic define, unlike the 13
unobviously chosen places in /usr/include which have:

#ifndef _SIZE_T_DEFINED_
#define _SIZE_T_DEFINED_
typedef __size_tsize_t;
#endif

Should I replicate this block into sys/syslog.h? That fixes the problem
but clearly one can never tell what's gonna break with system include
files.

Thanks
Greg



CVS: cvs.openbsd.org: src

2023-04-26 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2023/04/26 00:52:45

Modified files:
lib/libc/hidden: syslog.h 
sys/sys: syslog.h 

Log message:
Declare sendsyslog to match its man page

This simplifies syzkaller revival after the removal of __syscall.

OK bluhm, millert, deraadt



CVS: cvs.openbsd.org: src

2023-04-09 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2023/04/09 17:41:48

Modified files:
libexec/ld.so  : resolve.c 
regress/libexec/ld.so/subst: Makefile 
Added files:
regress/libexec/ld.so/subst/prog2: Makefile main.c 

Log message:
Treat symlinks better in $ORIGIN determination in ld.so

Now symlinking an executable away from the rest of its installation
tree no longer prevents it from finding the libraries. This matches
the behavior of other OS linkers. Prompted by a behavior change in
lang/ghc test suite.

Swapped the order of dirname/realpath in _dl_origin_path.

Added some regress tests that pass and then bin3 that fails without
this change and reflects the behavior needd for lang/ghc.

Suggestion by semarie@, OK deraadt@



CVS: cvs.openbsd.org: src

2023-04-09 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2023/04/09 17:41:42

src/regress/libexec/ld.so/subst/prog2

Update of /cvs/src/regress/libexec/ld.so/subst/prog2
In directory 
cvs.openbsd.org:/cvs.d/hack/gnezdo/src/regress/libexec/ld.so/subst/prog2

Log Message:
Directory /cvs/src/regress/libexec/ld.so/subst/prog2 added to the repository



CVS: cvs.openbsd.org: src

2023-02-19 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2023/02/19 17:51:57

Modified files:
libexec/ld.so  : loader.c 

Log message:
Adjust inline !libc check to match the intent in ld.so

right, deraadt@



CVS: cvs.openbsd.org: src

2023-01-29 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2023/01/29 13:30:56

Modified files:
libexec/ld.so  : library.c library_mquery.c loader.c resolve.h 

Log message:
Accumulate intermediate imutables locally before applying

OK deraadt



CVS: cvs.openbsd.org: src

2023-01-29 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2023/01/29 13:30:21

Modified files:
libexec/ld.so/aarch64: rtld_machine.c 
libexec/ld.so/amd64: rtld_machine.c 
libexec/ld.so/i386: rtld_machine.c 
libexec/ld.so/riscv64: rtld_machine.c 
libexec/ld.so/sh: rtld_machine.c 
libexec/ld.so  : util.h 

Log message:
Unite all nitems copies in ld.so/util.h

OK deraadt



CVS: cvs.openbsd.org: www

2022-10-01 Thread Greg Steuck
CVSROOT:/cvs
Module name:www
Changes by: gne...@cvs.openbsd.org  2022/10/01 15:36:27

Modified files:
.  : 72.html 

Log message:
Minor grammar nits



CVS: cvs.openbsd.org: src

2022-09-28 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2022/09/28 10:44:15

Modified files:
lib/libc/stdio : setvbuf.c 

Log message:
Fix incorrect range check for size in setvbuf

>From enh AT google.com:

The existing test is wrong for LP64, where size_t has twice as many
relevant bits as int, not just one. (Found by inspection by
rprichard.)

Looks good to deraadt@ and millert@



CVS: cvs.openbsd.org: src

2022-08-31 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2022/08/31 03:07:35

Modified files:
sys/uvm: uvm_vnode.c 

Log message:
Lock vmobjlock then check u_flags & UVM_VNODE_VALID in uvn_attach

This is a continuation of this commit:
"Always acquire the `vmobjlock' before incrementing an object's reference."

Unfortuantely this created a race found by syzkaller manifesting as:

panic: kernel diagnostic assertion "uvn->u_obj.uo_refs == 0" failed:
file "sys/uvm/uvm_vnode.c", line 234

ok mpi@

Reported-by: syzbot+dd2d2684ad2818c92...@syzkaller.appspotmail.com



CVS: cvs.openbsd.org: xenocara

2022-08-29 Thread Greg Steuck
CVSROOT:/cvs
Module name:xenocara
Changes by: gne...@cvs.openbsd.org  2022/08/29 12:11:41

Modified files:
app/xlockmore/xlock: passwd.c 

Log message:
Properly support style in passwd\nOK matthieu



CVS: cvs.openbsd.org: src

2022-06-20 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2022/06/20 10:28:42

Modified files:
sys/dev/wscons : wsdisplay.c 

Log message:
Fix console screen blanker setting timeout back to zero

Tested locally. "looks correct" to miod@

>From Crystal Kolipe kolipe DOT c AT exoticsilicon DOT com



CVS: cvs.openbsd.org: src

2022-06-11 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2022/06/11 23:36:20

Modified files:
usr.bin/locate/locate: locate.updatedb.8 

Log message:
Document ext2fs traversal by locate.updatedb(8)

>From Larry Hynes



CVS: cvs.openbsd.org: www

2022-04-20 Thread Greg Steuck
CVSROOT:/cvs
Module name:www
Changes by: gne...@cvs.openbsd.org  2022/04/20 22:25:45

Modified files:
.  : plus71.html 

Log message:
Mention UBSan in plus71



CVS: cvs.openbsd.org: src

2022-03-04 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2022/03/04 09:46:23

Modified files:
gnu/llvm/clang/lib/Driver: Driver.cpp 
gnu/llvm/lld/ELF: DriverUtils.cpp 

Log message:
Report versioned lib.so in cc --print-file-name given short name

E.g. `cc --print-file-name libc.so` reports /usr/lib/libc.so.96.1

This is a complement of the major.minor finding logic in DriverUtils.
`ld -lc -L/usr/lib` currently find the libraries with this logic.

To make things more obviously related the code was extracted into a
function which was copied over verbatim.

fine with mortimer@
ok patrick@



CVS: cvs.openbsd.org: src

2022-02-15 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2022/02/15 21:12:48

Modified files:
distrib/sets/lists/comp: clang.amd64 clang.arm64 clang.armv7 
 clang.i386 clang.loongson clang.macppc 
 clang.octeon clang.powerpc64 
 clang.riscv64 clang.sparc64 

Log message:
Add libclang_rt.ubsan_minimal to comp set

ok jca@



CVS: cvs.openbsd.org: src

2022-02-15 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2022/02/15 20:49:40

Modified files:
gnu/lib/libclang_rt: Makefile 
Added files:
gnu/lib/libclang_rt/ubsan_minimal: Makefile 

Log message:
Plug ubsan_minimal into gnu/lib/libclang_rt build

ok jca@



CVS: cvs.openbsd.org: src

2022-02-15 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2022/02/15 20:49:12

src/gnu/lib/libclang_rt/ubsan_minimal

Update of /cvs/src/gnu/lib/libclang_rt/ubsan_minimal
In directory 
cvs.openbsd.org:/cvs.d/hack/gnezdo/src/gnu/lib/libclang_rt/ubsan_minimal

Log Message:
Directory /cvs/src/gnu/lib/libclang_rt/ubsan_minimal added to the repository



CVS: cvs.openbsd.org: src

2022-02-15 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2022/02/15 20:48:55

Modified files:
gnu/llvm/compiler-rt/lib/interception: interception.h 
   interception_linux.h 
gnu/llvm/compiler-rt/lib/sanitizer_common: sanitizer_linux.cpp 
   sanitizer_linux.h 
   sanitizer_platform.h 
gnu/llvm/compiler-rt/lib/ubsan: ubsan_platform.h 

Log message:
Add ifdefs to build ubsan_minimal on OpenBSD

ok jca@



CVS: cvs.openbsd.org: src

2022-02-05 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2022/02/05 16:00:20

Modified files:
games/battlestar: extern.h 

Log message:
Fix UB "shift-out-of-bounds" in battlestar

OK millert@



CVS: cvs.openbsd.org: src

2022-01-24 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2022/01/24 21:04:41

Modified files:
sys/arch/amd64/amd64: machdep.c 
sys/arch/i386/i386: machdep.c 
sys/kern   : kern_sysctl.c vfs_subr.c 
sys/netinet: ip_input.c 
sys/sys: sysctl.h 

Log message:
Capture a repeated pattern into sysctl_securelevel_int function

A few variables in the kernel are only writeable before securelevel is
raised. It makes sense to handle them with less code.

OK sthen@ bluhm@



CVS: cvs.openbsd.org: src

2022-01-20 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2022/01/20 20:13:22

Modified files:
regress/lib/libm/msun: Makefile 

Log message:
Require trig_test-2 to pass on arm64 and powerpc64

Thanks to mbuhl@ for testing on a plethora of platforms.

OK mbuhl@, tested by mbuhl@ and phessler@



CVS: cvs.openbsd.org: src

2022-01-20 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2022/01/20 20:13:10

Modified files:
lib/libm/src   : k_cosf.c k_sin.c k_sinf.c s_cosf.c s_sin.c 
 s_sinf.c 

Log message:
Optimization for tiny x in cos and sin

Subset of FreeBSD commit 4339c67c485f0b1f7699863fc29f6c06862d1dde:
Moved the optimization for tiny x from __kernel_{cos,sin}[f](x) to
{cos_sin}[f](x) so that x doesn't need to be reclassified in the
"kernel" functions to determine if it is tiny (it still needs to be
reclassified in the cosine case for other reasons that will go away).
...

Parts of the original change were applied separately before.

Suggested by kettenis@

OK mbuhl@, tested by mbuhl@ and phessler@



CVS: cvs.openbsd.org: src

2022-01-20 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2022/01/20 20:12:56

Modified files:
lib/libm   : Makefile 
regress/lib/libm/msun: Makefile 

Log message:
Unplug assembly implementations of trig functions on x86 platforms

The same change was done by NetBSD some time back as:

Disable x87 implementations of sin, cos, tan.

The x87 hardware uses a bad approximation to pi for argument
reduction, and consequently yields bad answers for inputs near pi or
pi/2.

OK mbuhl@, tested by mbuhl@ and phessler@



CVS: cvs.openbsd.org: src

2022-01-20 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2022/01/20 20:12:43

Modified files:
lib/libm/src   : k_cos.c s_cos.c 

Log message:
Copy cos(3) software implementation from FreeBSD-13

The result passes more tests from msun suite. In particular,
testacc(cos, -0.34061437849088045332L, 0.94254960031831729956L,
ALL_STD_EXCEPT, FE_INEXACT);
matches instead of being 1e-16 off.

OK mbuhl@, tested by mbuhl@ and phessler@



CVS: cvs.openbsd.org: src

2022-01-03 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2022/01/03 22:50:43

Modified files:
sys/arch/amd64/conf: GENERIC 

Log message:
Remove commented out gtp from amd64 GENERIC

It has long been irrelevant as pointed out by Crystal Kolipe
kolipe.c AT exoticsilicon.com

ok mlarkin



CVS: cvs.openbsd.org: src

2021-09-01 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2021/09/01 03:34:53

Modified files:
gnu/llvm/clang/lib/Driver/ToolChains: OpenBSD.cpp 

Log message:
llvm: Use Component in OpenBSD::getCompilerRT to find libraries

Clang uses runtime libraries for some advanced features like
sanitizers. Different systems have different preferences about file
placement. OpenBSD with this change would use this name for ASan:
/usr/lib/clang/11.1.0/lib/libclang_rt.asan.a

So far, no libraries are shipped, only their eventual location is chosen.

Discussed with deraadt@ and kettenis@, OK mortimer@



CVS: cvs.openbsd.org: src

2021-08-29 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2021/08/29 15:32:52

Modified files:
gnu/llvm/clang/lib/Driver/ToolChains: OpenBSD.cpp 

Log message:
Revert: llvm: openbsd driver had one -lcompiler_rt too many

Suggested by jca@ that kettenis@ looks at it first.



CVS: cvs.openbsd.org: src

2021-08-29 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2021/08/29 15:05:15

Modified files:
gnu/llvm/clang/lib/Driver/ToolChains: OpenBSD.cpp 

Log message:
llvm: openbsd driver had one -lcompiler_rt too many

Tested by doing a full system build locally. Will work with brad@ for
upstream-ing.

OK patrick & mortimer



CVS: cvs.openbsd.org: src

2021-08-29 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2021/08/29 14:31:18

Modified files:
sys/dev/pci: if_iwm.c if_iwx.c 

Log message:
iwm/iwx: propagate errors out of iw{m,x}_set_bits_mask_prph routines

This might help with troubleshooting "iwx0: acquiring device failed"
errors.

OK stsp@



CVS: cvs.openbsd.org: src

2021-08-12 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2021/08/12 19:24:22

Modified files:
sys/dev/usb: if_ure.c if_urereg.h 

Log message:
Remove unused ure_stop_task (from Christian Ludwig of genua.de)

The ure_stop_task is not scheduled anywhere.

Compile tested here.



CVS: cvs.openbsd.org: src

2021-05-01 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2021/05/01 10:18:58

Modified files:
sys/sys: sysctl.h 

Log message:
Removed unused SYSCTL_INT_UNBOUNDED (no use planned)

Added a comment for SYSCTL_INT_READONLY.

OK mvs@



CVS: cvs.openbsd.org: src

2021-05-01 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2021/05/01 10:18:29

Modified files:
sys/arch/amd64/amd64: machdep.c 
sys/arch/i386/i386: machdep.c 
sys/kern   : kern_sysctl.c 
sys/miscfs/fuse: fuse_vfsops.c 
sys/ufs/ffs: ffs_vfsops.c 

Log message:
Update the remaining SYSCTL_INT_READONLY cases

OK mvs@



CVS: cvs.openbsd.org: www

2021-04-12 Thread Greg Steuck
CVSROOT:/cvs
Module name:www
Changes by: gne...@cvs.openbsd.org  2021/04/12 10:33:23

Modified files:
.  : 69.html 

Log message:
Remove packages related notes (too sparse as is).



CVS: cvs.openbsd.org: www

2021-04-11 Thread Greg Steuck
CVSROOT:/cvs
Module name:www
Changes by: gne...@cvs.openbsd.org  2021/04/11 10:03:42

Modified files:
.  : 69.html 

Log message:
Documented GHC and Haskell package upgrades in 6.9



CVS: cvs.openbsd.org: src

2021-04-10 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2021/04/10 09:26:47

Modified files:
share/man/man5 : Makefile port-modules.5 
Added files:
share/man/man5 : cabal-module.5 

Log message:
Add cabal-module(5) man page

OK kn



CVS: cvs.openbsd.org: src

2021-01-09 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2021/01/09 16:33:18

Modified files:
sys/kern   : kern_sysctl.c 

Log message:
Split hierarchical calls into kern_sysctl_dirs

Removed a rash of +/-1 and made both functions shorter and more focused.

OK millert@



CVS: cvs.openbsd.org: src

2021-01-09 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2021/01/09 15:00:13

Modified files:
sys/kern   : kern_sysctl.c 

Log message:
Reduce case duplication in kern_sysctl

This changes amd64 GENERIC.MP .text size of kern_sysctl.o from 6440 to 6400.
Surprisingly, RAMDISK grows from 1645 to 1678.

OK millert@, mglocker@



CVS: cvs.openbsd.org: src

2021-01-09 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2021/01/09 14:01:20

Modified files:
sys/arch/i386/i386: machdep.c 

Log message:
Fold fitting sysctl_rdint into sysctl_bounded_arr in i386 cpu_sysctl

OK millert@



CVS: cvs.openbsd.org: src

2021-01-09 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2021/01/09 14:00:58

Modified files:
sys/net: if_etherip.c 

Log message:
Enforce range with sysctl_int_bounded in etherip_sysctl

OK millert@



CVS: cvs.openbsd.org: src

2021-01-09 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2021/01/09 14:00:29

Modified files:
sys/uvm: uvm_swap_encrypt.c 

Log message:
Enforce range with sysctl_int_bounded in swap_encrypt_ctl

OK millert@



CVS: cvs.openbsd.org: src

2021-01-09 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2021/01/09 14:00:04

Modified files:
sys/net: pipex.c 

Log message:
Enforce range with sysctl_int_bounded in pipex_sysctl

OK millert@



CVS: cvs.openbsd.org: src

2021-01-09 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2021/01/09 13:59:44

Modified files:
sys/netinet: ip_ipip.c 

Log message:
Enforce range with sysctl_int_bounded in ipip_sysctl

OK millert@



CVS: cvs.openbsd.org: src

2021-01-09 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2021/01/09 13:59:23

Modified files:
sys/kern   : kern_watchdog.c 

Log message:
Enforce range with sysctl_int_bounded in sysctl_wdog

OK millert@



CVS: cvs.openbsd.org: src

2021-01-09 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2021/01/09 13:59:06

Modified files:
sys/kern   : subr_witness.c 

Log message:
Enforce range with sysctl_int_bounded in witness_sysctl_watch

Makes previously explicit checking less verbose.

OK millert@



CVS: cvs.openbsd.org: src

2021-01-09 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2021/01/09 13:58:37

Modified files:
sys/netinet: tcp_usrreq.c 

Log message:
Enforce range with sysctl_int_bounded in tcp_sysctl

One case uses the explicit range from the code and the other was
inferred from reading the usage.

OK millert@



CVS: cvs.openbsd.org: src

2021-01-09 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2021/01/09 13:58:12

Modified files:
sys/ddb: db_usrreq.c 

Log message:
Finish converting ddb_sysctl to sysctl_int_bounded

I missed the verbose pattern that it used for error checking the first
time around.

OK millert@



CVS: cvs.openbsd.org: src

2021-01-09 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2021/01/09 13:57:46

Modified files:
sys/kern   : kern_sched.c 

Log message:
Use sysctl_int_bounded in sysctl_hwsmt

Prefer error reporting is to silent clipping.

OK millert@



CVS: cvs.openbsd.org: src

2021-01-09 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2021/01/09 13:51:00

Modified files:
sys/dev/wscons : wsmux.c 

Log message:
Revert mistaken commit: Stop wsmux_attach_sc race from anton@



CVS: cvs.openbsd.org: src

2021-01-09 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2021/01/09 13:45:55

Modified files:
sys/dev/wscons : wsmux.c 

Log message:
Stop wsmux_attach_sc race from anton@

OK millert@



CVS: cvs.openbsd.org: src

2020-12-12 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/12/12 23:14:35

Modified files:
sys/arch/amd64/amd64: machdep.c 

Log message:
Turn simple sysctl_rdint into cpuctl_vars entries

ok gkoehler@



CVS: cvs.openbsd.org: src

2020-12-09 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/12/09 21:27:25

Modified files:
sys/ddb: db_usrreq.c 

Log message:
Convert ddb_sysctl to sysctl_bounded_arr

ok gkoehler@



CVS: cvs.openbsd.org: src

2020-12-09 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/12/09 21:27:07

Modified files:
sys/net: if_gre.c 

Log message:
Convert gre_sysctl to sysctl_bounded_arr

Fixed up a reference to gre_wccp where a fixed value from wwcp
standard was intended.

ok gkoehler@



CVS: cvs.openbsd.org: src

2020-12-09 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/12/09 21:26:50

Modified files:
sys/kern   : sched_bsd.c 

Log message:
Use sysctl_int_bounded for sysctl_hwsetperf

Removed some trailing whitespace while there.

ok gkoehler@



CVS: cvs.openbsd.org: src

2020-12-07 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/12/07 10:34:49

Modified files:
sys/dev/acpi   : dwgpio.c 

Log message:
Initialize handled

ok kettenis@



CVS: cvs.openbsd.org: src

2020-12-04 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/12/04 21:46:34

Modified files:
sys/kern   : kern_tc.c 

Log message:
Convert sysctl_tc to sysctl_bounded_arr

ok gkoehler@



CVS: cvs.openbsd.org: src

2020-11-18 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/11/18 21:08:46

Modified files:
sys/kern   : sysv_shm.c 

Log message:
Convert sysctl_sysvsem to sysctl_int_bounded

Performed a minor refactoring and removed a few trailing whitespaces.

ok anton@



CVS: cvs.openbsd.org: src

2020-11-16 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/11/16 20:23:54

Modified files:
sys/kern   : sysv_sem.c 

Log message:
Convert sysctl_sysvsem to sysctl_bounded_args

Used sysctl_int_bounded in many places to shrink code.
Extracted a new function to make the case tidy.
Removed some superflous fluff.

OK millert@



CVS: cvs.openbsd.org: src

2020-11-16 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/11/16 20:23:10

Modified files:
sys/miscfs/fuse: fuse_vfsops.c 

Log message:
Convert fusefs_sysctl to sysctl_bounded_args

OK millert@



CVS: cvs.openbsd.org: src

2020-11-15 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/11/15 23:44:39

Modified files:
sys/netinet: ip_input.c tcp_usrreq.c 
sys/netinet6   : ip6_input.c 

Log message:
Replace sysctl_rdint with sysctl_bounded_args entries in net.inet*



CVS: cvs.openbsd.org: src

2020-11-15 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/11/15 23:42:12

Modified files:
sys/kern   : kern_sysctl.c 

Log message:
Convert hw_sysctl to sysctl_bounded_args

This one is surprisingly a minor loss if one were to simply add bytes
on amd64:
.text+.data+.bss+.rodata
before 0x64b0+0x40+0x14+0x338 = 0x683c
after  0x6440+0x48+0x14+0x3b8 = 0x6854



CVS: cvs.openbsd.org: src

2020-11-15 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/11/15 23:38:20

Modified files:
sys/netinet: ip_divert.c 
sys/netinet6   : ip6_divert.c 

Log message:
Remove the cases folded into sysctl_bounded_args but left behind

divert_sysctl and divert6_sysctl get a tiny bit slimmer.



CVS: cvs.openbsd.org: src

2020-11-15 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/11/15 23:37:07

Modified files:
sys/kern   : kern_sysctl.c 

Log message:
Convert kern_sysctl to sysctl_bounded_args

objdump -h changes in Size of kern_sysctl.o on amd64
before  after
.text 7140   64b0
.data   24 40
.bss10 14
.rodata 50338



CVS: cvs.openbsd.org: src

2020-11-06 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/11/06 22:24:20

Modified files:
sys/kern   : kern_sysctl.c 
sys/sys: sysctl.h 
sys/ufs/ffs: ffs_vfsops.c 

Log message:
Convert ffs_sysctl to sysctl_bounded_args

Requires sysctl_bounded_arr branch to support sysctl_rdint.
The read-only variables are marked by an empty range of [1, 0].

OK millert@



CVS: cvs.openbsd.org: src

2020-11-03 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/11/03 21:40:13

Modified files:
sys/net: bpf.c 

Log message:
Use sysctl_int_bounded in bpf_sysctl

Unlike the other cases of sysctl_bounded_arr this one uses a dynamic limit.

OK millert@



CVS: cvs.openbsd.org: src

2020-11-01 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/11/01 21:29:23

Modified files:
sys/netinet: tcp_usrreq.c 

Log message:
Move TCPCTL_ALWAYS_KEEPALIVE into tcpctl_vars

OK deraadt



CVS: cvs.openbsd.org: src

2020-08-31 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/08/31 20:22:52

Modified files:
sys/arch/loongson/loongson: machdep.c 

Log message:
Use sysctl_bounded_args for simple cases in cpu_sysctl on loongson

deraadt@: looks fine



CVS: cvs.openbsd.org: src

2020-08-31 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/08/31 19:57:15

Modified files:
share/man/man9 : sysctl_int.9 

Log message:
Document sysctl_bounded_args(9)

Remove obsolete sysctl_int_arr documentation.

Looks good, deraadt@
reads ok, jmc@



CVS: cvs.openbsd.org: src

2020-08-31 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/08/31 19:53:13

Modified files:
sys/netinet: icmp6.h 
sys/netinet6   : icmp6.c 

Log message:
Convert icmp6_sysct to sysctl_bounded_args

The best-guessed limits will be tested by trial.



CVS: cvs.openbsd.org: src

2020-08-31 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/08/31 19:53:34

Modified files:
sys/netinet: ip_ah.h ip_esp.h ip_ipcomp.h ip_ipsp.h 
 ipsec_input.c 

Log message:
Convert *_sysctl in ipsec_input.c to sysctl_bounded_arr

The best-guessed limits will be tested by trial.



CVS: cvs.openbsd.org: src

2020-08-31 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/08/31 19:53:50

Modified files:
sys/kern   : kern_sysctl.c 
sys/sys: sysctl.h 

Log message:
Remove unused sysctl_int_arr(9)



CVS: cvs.openbsd.org: src

2020-08-24 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/08/24 10:40:07

Modified files:
sys/netinet6   : in6.h ip6_input.c 

Log message:
Convert ip6_sysctl to sysctl_bounded_args

Tighter limits and OK by sashan



CVS: cvs.openbsd.org: src

2020-08-24 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/08/24 10:00:31

Modified files:
sys/netinet: ip_divert.c ip_divert.h 
sys/netinet6   : ip6_divert.c ip6_divert.h 

Log message:
Convert divert*_sysctl to sysctl_bounded_args

OK sashan



CVS: cvs.openbsd.org: src

2020-08-22 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/08/22 19:12:04

Modified files:
sys/arch/i386/i386: machdep.c 

Log message:
Use sysctl_bounded_args for simple cases in cpu_sysctl on i386

OK kn



CVS: cvs.openbsd.org: src

2020-08-22 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/08/22 11:55:54

Modified files:
sys/netinet: icmp_var.h ip_icmp.c 

Log message:
Convert icmp_sysctl to sysctl_bounded_args

... these all look fine, derradt@



CVS: cvs.openbsd.org: src

2020-08-22 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/08/22 11:54:57

Modified files:
sys/netinet: udp_usrreq.c udp_var.h 

Log message:
Convert udp_sysctl to sysctl_bounded_args



CVS: cvs.openbsd.org: src

2020-08-22 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/08/22 11:55:30

Modified files:
sys/netinet: in.h ip_input.c 

Log message:
Convert ip_sysctl to sysctl_bounded_args



CVS: cvs.openbsd.org: src

2020-08-19 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/08/19 13:24:03

Modified files:
sys/arch/amd64/amd64: machdep.c 

Log message:
Use sysctl_bounded_args for simple cases in cpu_sysctl on amd64

deraadt@: fine



CVS: cvs.openbsd.org: src

2020-08-19 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/08/19 13:22:53

Modified files:
sys/netmpls: mpls.h mpls_raw.c 

Log message:
Convert mpls_sysctl to sysctl_bounded_args

OK claudio@



CVS: cvs.openbsd.org: src

2020-08-18 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/08/18 12:19:30

Modified files:
sys/kern   : kern_sysctl.c 
sys/netinet: tcp_usrreq.c 

Log message:
Style fixups from hurried commits

Thanks kettenis@ for pointing out.

ok kettenis@



CVS: cvs.openbsd.org: src

2020-08-17 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/08/17 23:21:21

Modified files:
sys/netinet: tcp_usrreq.c tcp_var.h 

Log message:
Convert tcp_sysctl to sysctl_bounded_args

This introduces bounds checks for many net.inet.tcp sysctl variables.
Folded some fitting cases into the framework: tcp_do_sack, tcp_do_ecn.

ok derradt@



CVS: cvs.openbsd.org: src

2020-08-17 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/08/17 22:48:12

Modified files:
sys/kern   : kern_sysctl.c 
sys/sys: sysctl.h 

Log message:
Add sysctl_bounded_arr as a replacement for sysctl_int_arr

Design by deraadt@

ok deraadt@



CVS: cvs.openbsd.org: src

2020-08-17 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/08/17 10:25:34

Modified files:
sys/netinet: igmp.c igmp_var.h 

Log message:
Simplify igmp_sysctl to directly return error in default case

This replaces a piece of observationally identical code which was much
more complicated.

ok mpi@



CVS: cvs.openbsd.org: src

2020-08-16 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/08/16 22:26:57

Modified files:
sys/dev/usb: ugold.c 

Log message:
Fix typo in comment

>From Paul de Weerd



CVS: cvs.openbsd.org: src

2020-08-16 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/08/16 10:08:10

Modified files:
sys/dev/acpi   : acpi.c acpivar.h 

Log message:
Remove sc_maxgpe from acpi_softc which was never read from

Remove a dead conditional from acpi_init_gpes while there.

ok jcs@



CVS: cvs.openbsd.org: src

2020-08-01 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/08/01 22:24:45

Modified files:
share/man/man9 : sysctl_int.9 

Log message:
Catch up sysctl_int.9 to the updated signature

OK kn@, "fine" deraadt@



CVS: cvs.openbsd.org: src

2020-08-01 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2020/08/01 17:41:56

Modified files:
sys/kern   : kern_sysctl.c 
sys/netinet: igmp.c ip_divert.c ip_icmp.c ip_input.c 
 ipsec_input.c tcp_usrreq.c udp_usrreq.c 
sys/netinet6   : icmp6.c ip6_divert.c ip6_input.c 
sys/netmpls: mpls_raw.c 
sys/sys: sysctl.h 

Log message:
Move range check inside sysctl_int_arr

Range violations are now consistently reported as EOPNOTSUPP.
Previously they were mixed with ENOPROTOOPT.

OK kn@