CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/10/30 09:00:12

Modified files:
sys/sys: disk.h 

Log message:
nope, gcc does not like the change

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/10/24 21:42:06

Modified files:
usr.sbin/sysupgrade: sysupgrade.8 sysupgrade.sh 

Log message:
Add support for performing a sysupgrade from a path.  This is convenient
for offline machines if you can pull the snapshot or release to there there,
but want sysupgrade to locally perform signify validation before performing
the /home/_sysupgrade and other boot-upgrade steps.
ok florian

Re: CVS: cvs.openbsd.org: src

[Theo de Raadt]

Anton, back it out right away.

>From owner-source-changes+M181516=deraadt=cvs.openbsd@openbsd.org Sun Oct 
>20 23:43:01 2024
>Delivered-To: dera...@cvs.openbsd.org
>DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=selector1; bh=GMhdKwZ2pE
>   NofvlurQX6BF2bUqjtBvklZlgQXTQ75kc=; h=list-unsubscribe:list-subscribe:
>   list-post:list-owner:list-id:list-help:in-reply-to:references:subject:
>   cc:to:from:date; d=openbsd.org; b=b+ra1d4gGP7sOjogrPsDnwGfAltH2nKTeuUK
>   eTM47Y77ZypvKzuPfokG9yYGKiGVzehzTHYahglGOQNvCE2Hvn8l+81dPfeTUWrUh4MqAH
>   /e8FMkAPAk1J2gVJ+2whVdFbnqn+s+p9nOUOugFCan9Znz2jRq60eDYg/VwVKvNkrewo9S
>   Km4VqyAli/BtCksfgyWcceaKCLZmsISUdUUoS4XpD1vKlf9FkfbYjOyfPdm7X7w79PQxwP
>   8vluzuWz87d3i1V7CcXQ2hMo2izo1E7fJhyRvWxsdyKJBCEQwTzpHJNz8oMNI/5PmzkIqk
>   Q9kBi2+2pY/COAYBLmJCsZx0wA==
>Date: Mon, 21 Oct 2024 07:42:54 +0200
>From: Anton Lindqvist 
>To: David Gwynne 
>Cc: source-chan...@cvs.openbsd.org
>Subject: Re: CVS: cvs.openbsd.org: src
>Mail-Followup-To: David Gwynne ,
>   source-chan...@cvs.openbsd.org
>References: 
>MIME-Version: 1.0
>Content-Type: text/plain; charset=us-ascii
>Content-Disposition: inline
>In-Reply-To: 
>List-Help: 
>List-ID: 
>List-Owner: 
>List-Post: 
>List-Subscribe: 
>List-Unsubscribe: 
>X-Loop: source-changes@openbsd.org
>Precedence: list
>Sender: owner-source-chan...@openbsd.org
>
>On Sun, Oct 20, 2024 at 05:28:17AM -0600, David Gwynne wrote:
>> CVSROOT: /cvs
>> Module name: src
>> Changes by:  d...@cvs.openbsd.org2024/10/20 05:28:17
>> 
>> Modified files:
>>  sys/uvm: uvm_map.c uvm_map.h 
>> 
>> Log message:
>> try to simplify the locking code around busy maps.
>> 
>> vm_maps have a "feature" where they can mark that they're being
>> operated on by a specific proc, and then release the rwlock protecting
>> their state. to relock, you have to be the same proc that marked
>> it busy.
>> 
>> this diff tries to simplify it a bit. it basically has threads check
>> the busy field up front and rechecks the busy field inside the
>> rwlock. if you can sleep, it will sleep up front for the busy field
>> to become clear, rather than sleep on either the busy field or the
>> rwlock. some code paths clear the busy field without holding the
>> rwlock, so it doesn't make sense to me to be waiting for the busy
>> field but sleeping somewhere else.
>> 
>> ok claudio@ mpi@
>
>This caused by amd64 regress machine to panic. It goes straight to
>reboot, no chance of capturing any output from ddb.
>
>Here's a reproducer which compiles some Go application:
>
>   $ make -C $BSDSRC/regress/lib/libcrypto/c2sp
>
>My amd64 desktop machine also locks up while starting firefox.
>
>

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/10/14 18:08:28

Modified files:
etc/etc.i386   : disktab 
distrib/i386/iso: Makefile 

Log message:
grow i386 media a bit

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/10/13 20:46:50

Modified files:
etc: rc 

Log message:
sshd-auth also has a relink kit

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/10/13 20:45:44

Modified files:
distrib/sets/lists/base: mi 

Log message:
sync

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/10/12 18:00:41

Modified files:
usr.sbin/fw_update: patterns.c 

Log message:
Be more eager to install qcpas firmware (more pattern matches)

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/10/11 08:12:05

Modified files:
usr.sbin/sysupgrade: sysupgrade.8 sysupgrade.sh 

Log message:
The fw keys have been added to the signify key bundles.  sysupgrade will
now extract the fw key also, so that pre-upgrade fw_update can fetch
the most uptodate firmware.
ok sthen

CVS: cvs.openbsd.org: www

[Theo de Raadt]

CVSROOT:/cvs
Module name:www
Changes by: dera...@cvs.openbsd.org 2024/10/07 14:02:26

Modified files:
.  : 76.html index.html security.html 

Log message:
release openbsd 7.6, 57th release.

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/10/07 07:21:53

Modified files:
usr.sbin/sysupgrade: sysupgrade.8 sysupgrade.sh 

Log message:
The two usual use cases are sysupgrade and sysupgrade -s, jumping
forward to the same key, or the key+.1.  But sometimes you want to
update an older machine far forward (either with -s, or with -R), and
the required key might not exist on-disk.  Since getting the key isn't
automated, people make some poor decisions to get the key.  Previous
to 7.6 the situation was worse, (and obviously older releases will have
the old sysupgrade script, though you can copy this one to those machines
and it will work, but please do that securely..)
Moving forward this improves the workflow: a new set of keybundles
(signed by older keys) have been made available so that sysupgrade
can securely and automatically download the required key.
ok job tb beck sthen

CVS: cvs.openbsd.org: www

[Theo de Raadt]

CVSROOT:/cvs
Module name:www
Changes by: dera...@cvs.openbsd.org 2024/09/30 15:49:54

Modified files:
.  : 76.html 

Log message:
typo

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/09/30 08:31:56

Modified files:
etc/root   : root.mail 

Log message:
change release date

CVS: cvs.openbsd.org: www

[Theo de Raadt]

CVSROOT:/cvs
Module name:www
Changes by: dera...@cvs.openbsd.org 2024/09/29 22:18:58

Modified files:
.  : plus76.html 

Log message:
ksh NUL change is not in 7.6

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/09/24 22:19:36

Modified files:
usr.sbin/vmd   : sev.c 

Log message:
document why sys/param.h is used

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/09/23 20:22:43

Modified files:
sys/kern   : kern_pledge.c 

Log message:
for sysctl on arm64, handle CPU_ID_AA64ISAR1 same as CPU_ID_AA64ISAR0
ok sthen

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/09/23 15:18:33

Modified files:
bin/ksh: shf.c 

Log message:
If during parsing lines in the script, ksh finds a NUL byte on the
line, it should abort ("syntax error: NUL byte unexpected").  There
appears to be one piece of software which is misinterpreting guidance
of this, and trying to depend upon embedded NUL.  During research,
every shell we tested has one or more cases where a NUL byte in the
input or inside variable contents will create divergent behaviour from
other shells.  (ie. gets converted to a space, is silently skipped, or
aborts script parsing or later execution).  All the shells are written
in C, and majority of them use C strings for everything, which means
they cannot embed a NUL, so this is not surprising.  It is quite
unbelievable there are people trying to rewrite history on a lark, and
expecting the world to follow alone.

If there is ONE THING the Unix world needs, it is for bash/ksh/sh to
stop diverging further by permitting STUPID INPUT that cannot
plausibly work in all other shells.  We are in a post-Postel world.

It remains possible to put arbitrary bytes *AFTER* the parts of the
shell script that get parsed & executed (like some Solaris patch files
do).  But you can't put arbirary bytes in the middle, ahead of shell
script parsed lines, because shells can't jump to arbitrary offsets
inside the input file, they go THROUGH all the 'valid shell script
text lines' to get there.

This was in snapshots for more than 2 months, and only spotted one
other program depending on the behaviour (and that test program did
not observe that it was therefore depending in incorrect behaviour!!)

ok ingo.  Softer ok's from various others.

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/09/23 15:05:28

Modified files:
sys/conf   : newvers.sh 

Log message:
now hacking on 7.6-current
(corrected)

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/09/23 14:50:47

Modified files:
sys/conf   : newvers.sh 

Log message:
now hacking on 7.6-current

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/09/21 13:06:07

Modified files:
sys/dev/acpi   : acpi_x86.c acpibtn.c 
sys/arch/amd64/amd64: machdep.c 

Log message:
We aren't ready to choose S0-over-S3 based upon the S0ix bit in FADT.
Some machines which work great in S3, don't work great in S0.

Some people want to be able to force S0, mostly for testing purposes
(or to notice improvements as changes are made in the tree).  Provide
a TEMPORARY method via machdep.lidaction=-1 which will be S0-suspend
while =1 remains S3 suspend.  This button will not remain long-term,
but for now, and during 7.6, it will be better than nothing.
ok ratchov kettenis

CVS: cvs.openbsd.org: www

[Theo de Raadt]

CVSROOT:/cvs
Module name:www
Changes by: dera...@cvs.openbsd.org 2024/09/19 05:42:54

Modified files:
.  : 76.html 

Log message:
increment two more versions

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/09/18 05:29:55

Modified files:
etc/root   : root.mail 

Log message:
back to previous plan

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/09/17 20:43:54

Modified files:
etc/root   : root.mail 

Log message:
adjust date

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/09/17 07:39:17

Modified files:
sys/conf   : newvers.sh 

Log message:
head into release

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/09/17 06:53:15

Modified files:
lib/libc/sys   : pledge.2 

Log message:
getdents(2) was pushed into rpath because it exposes pathname
information, similar to getcwd(2).  Move it to the right place, and
also say why.
report from henryford...@gmail.com

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/09/15 17:13:19

Modified files:
sys/kern   : exec_elf.c 

Log message:
Invalid pintables in ELF binaries can crash the kernel.
Fix from yufeng@uq.edu.au

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/09/04 08:18:36

Modified files:
share/tabset   : Makefile 

Log message:
correct .OBJDIR use; from Denis Bodor

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/09/03 11:05:59

Modified files:
lib/libc/net   : inet_pton.c 

Log message:
wild white space

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/09/03 09:28:58

Modified files:
distrib/sets/lists/comp: mi 

Log message:
sync

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/09/02 10:39:03

Modified files:
distrib/sets/lists/game: mi 

Log message:
sync

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/09/02 10:37:58

Modified files:
games/quiz/datfiles: index 
Added files:
games/quiz/datfiles: greek 

Log message:
In our fight against the cosmos, in the chaos of the source tree, we
deleted the greek quiz.  Some people felt trauma, and called out our
hubris.  At my request, Carson Harding performed a metamorphosis of
the quiz -- kudos to him!  After playing, I consider it the acme of
quizzes.
ok jmc mglocker

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/09/01 17:26:10

Modified files:
sys/kern   : vfs_syscalls.c 

Log message:
Regarding previous commit, X_OK on unveil-permitted directories does
not map nicely to UNVEIL_EXEC.  But we don't know before calling
namei() if the path is a directory.  Oh well, stick to UNVEIL_READ
for that case, it is going to be good enough for the typical case.
Worked out with jeremy after chrome/firefox Downloads directory issue.

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/31 10:23:09

Modified files:
sys/dev/ic : dc.c fxp.c rtl81x9.c xl.c 
sys/dev/pci: if_alc.c if_ale.c if_bce.c if_bge.c if_em.c 
 if_ix.c if_lii.c if_msk.c if_nfe.c if_re_pci.c 
 if_rge.c if_se.c if_sis.c if_sk.c if_vr.c 

Log message:
net drivers may have mii children, but mii layer has no _activate
functions.  similar operations are done via driver xx_stop/init functions
calling mii_ subfunctions directly at the right moments in time, and
are not anticipated to ever need the activate mechanism.  so for now,
delete all the config_activate_children() here
ok kettenis

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/31 09:53:44

Modified files:
sys/dev/acpi   : acpi_x86.c 

Log message:
If FADT_POWER_S0_IDLE_CAPABLE feature is found, prefer S0ix style over S3.
Commiting now so that tests can be done by more people before release.
At the last moment, we can pull this change out.

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/31 09:52:09

Modified files:
sys/kern   : vfs_syscalls.c 

Log message:
jeremy observed that access() on unveiled space was returning errors
for valid requests.  This is because the nd.ni_unveil to namei() was
always UNVEIL_READ, regardless of the request amode.  Building a
correct ni_unveil passes a new regression test, producing expected
results.
ok beck jeremy

Re: CVS: cvs.openbsd.org: src

[Theo de Raadt]

It is a mistake copying the idiomatic example from the bottom of the
man page.

I always copy it, and then fix the indentation.  Then, I consider
adjusting the local variables to match the idiomatic example.  Usually
it feels better to do that, rather than edit every variable occurance
in the strtol incantation ("Double, double toil and trouble; fire burn
and cauldron bubble.")

Anton Lindqvist  wrote:

> On Wed, Aug 28, 2024 at 05:40:33AM -0600, Omar Polo wrote:
> > CVSROOT:/cvs
> > Module name:src
> > Changes by: o...@cvs.openbsd.org2024/08/28 05:40:33
> > 
> > Modified files:
> > lib/libpcap: scanner.l 
> > 
> > Log message:
> > libpcap: replace hand-rolled number parser with strtol
> > 
> > can't use strtonum here since it needs to handle octal and hex
> > notations as well.  Part of a larger diff that's ok beck@
> 
> This broke slaacd, vxlan, wg and rip6cksum regress. I doubt it was ever
> tested.
> 
> According to the manual, strtol() assigns endptr to '\0' when the
> complete string is valid.
> 
> Index: scanner.l
> ===
> RCS file: /cvs/src/lib/libpcap/scanner.l,v
> diff -u -p -r1.31 scanner.l
> --- scanner.l 28 Aug 2024 11:40:33 -  1.31
> +++ scanner.l 29 Aug 2024 04:43:02 -
> @@ -344,7 +344,7 @@ stoi(char *s)
>  
>   errno = 0;
>   lval = strtol(s, &ep, 0);
> - if (*s == '\0' || *ep == '\0')
> + if (*s == '\0' || *ep != '\0')
>   bpf_error("invalid number %s", s);
>   if ((errno == ERANGE && (lval == LONG_MAX || lval == LONG_MIN)) ||
>   (lval > INT_MAX || lval < INT_MIN))
> 

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/28 21:30:05

Modified files:
lib/libcrypto/arch/aarch64: arm64cap.c 
lib/libcrypto/arch/arm: armcap.c 

Log message:
repair bizzare indents; ok tb

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/27 21:54:54

Modified files:
sys/arch/macppc/dev: if_wi_obio.c 

Log message:
splnet() not needed in activate function
ok gkoehler

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/26 16:54:21

Modified files:
etc/root   : root.mail 

Log message:
calendars are so hard

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/25 21:49:06

Modified files:
usr.bin/printf : printf.c 

Log message:
annoying whitespace found during an audit process

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/25 08:51:33

Modified files:
sys/arch/alpha/tc: tc_3000_500.c 

Log message:
make activate function confirm to the common idiom; ok miod

CVS: cvs.openbsd.org: www

[Theo de Raadt]

CVSROOT:/cvs
Module name:www
Changes by: dera...@cvs.openbsd.org 2024/08/25 07:39:29

Modified files:
openssh: specs.html 

Log message:
point at sntrup761x25519-sha512 documentation; ok djm

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/23 17:45:34

Modified files:
distrib/sets/lists/game: mi 

Log message:
sync

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/23 11:29:08

Modified files:
games/quiz : Makefile 
games/quiz/datfiles: index 
Added files:
games/quiz/datfiles: ship 
Removed files:
games/quiz/datfiles: greek 

Log message:
The greek quiz is so obscure that it is ridiculous -- noone can play
this.  Replace it with a new quiz about galley (ship) parts.  This
commit changes the *LAST UNMODIFIED ORIGINAL FILE* (meaning revision
1.1.1.1) from the original import that created OpenBSD on Oct 18,
1995.  With this commit, we have completed an amusing mission of
replacing the final parts of the original OpenBSD.

We have reached OpenBSD of Theseus.

ideas & assistance from mglocker, naval terminology help from jmc

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/23 08:50:16

Modified files:
games/atc  : main.c 

Log message:
slight improvement to index file parsing; ok mlarkin

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/22 22:51:00

Modified files:
usr.bin/ssh: cipher.c kex.c kex.h packet.c readconf.c 

Log message:
As defined in the RFC, the SSH protocol has negotiable compression support
(which is requested as the name "zlib"). Compression starts very early in
the session.
Relative early in OpenSSH lifetime, privsep was added to sshd, and this
required a shared-memory hack so the two processes could see what was going
on in the dataflow.  This shared-memory hack was soon recognized as a tremendous
complexity risk, because it put libz (which very much trusts it's memory)
in a dangerous place, and a new option ("z...@openssh.com") was added begins
compression after authentication (aka delayed-compression).  That change
also permitted removal of the shared-memory hack.
Despite removal from the server, the old "zlib" support remained in the
client, to allow negotiation with non-OpenSSH daemons which lack the
delayed-compression option.
This commit deletes support for the older "zlib" option in the client.
It reduces our featureset in a small way, and encourages other servers
to move to a better design.
The SSH protocol is different enough that compressed-key-material attacks
like BEAST are unlikely, but who wants to take the chance?
We encourage other ssh servers who care about optional compression support
to add delayed-zlib support.  (Some already do "z...@openssh.com")
ok djm markus

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/22 22:26:11

Modified files:
games/atc/games: Game_List 

Log message:
add rcsid markers so that we can visually see the flurry of commits in
this area
ok mlarkin

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/22 22:25:46

Modified files:
games/atc  : main.c 

Log message:
add the dumbest #-comment parser for the Game_List parser, someone
else can improve this later.  My code is not substandard considering
what I saw.

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/22 22:21:18

Modified files:
games/atc/games: Atlantis Killer OHare Tic-Tac-Toe airports box 
 crosshatch crossover default easy game_2 game_3 
 game_4 novice two-corners 

Log message:
add rcsid markers so that we can visually see the flurry of commits in
this area
ok mlarkin

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/22 21:25:32

Modified files:
games/fortune/datfiles: Makefile 
Removed files:
games/fortune/datfiles: fortunes-o.fake 

Log message:
probition is over.  most people want want to laugh at lightly
offensive things.
suggested it is time by millert

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/22 20:49:20

Modified files:
regress/sys/kern/execve: doexec.c 
regress/sys/kern/execve/good: badinterplen devnullscript empty 
  goodaout goodscript nonexistent 
  nonexistshell scriptarg 
  scriptarg-nospace truncaout 
regress/sys/kern/execve/tests: goodaout.c goodscript.in 
   scriptarg-nospace.in scriptarg.in 

Log message:
these tests only print strerror result, which can be confusing to look up.
print errno also.

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/22 20:46:09

Modified files:
games/quiz : Makefile 

Log message:
must use sh to run the script, because /usr/src may be noexec

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/21 21:10:42

Modified files:
games/atc  : BUGS 

Log message:
the hup bug is incorrectly described; ok mlarkin

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/21 14:20:24

Modified files:
games/quiz/datfiles: mult 

Log message:
unfair to discriminate against 0

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/21 08:08:19

Modified files:
games/quiz/datfiles: inca 

Log message:
This quiz is pretty old.  Don't know when this happened, but it seems
the wellknown name of "tupa inca yupanqui" has evolved to be either
"topa inca yupanqui" or "tupac inca yupanqui", so accept those answers.
research by claudio, inhouse inca expert

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/21 07:44:17

Modified files:
games/quiz/datfiles: chinese 

Log message:
accept capital letter answers

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/21 07:23:31

Modified files:
usr.bin/mail/misc: mail.rc 

Log message:
alpbetically sort the configuration choices

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/21 07:22:29

Modified files:
games/quiz/datfiles: seq-hard 

Log message:
difficult sequence for a mathematician to identify

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/20 23:08:54

Modified files:
games/quiz/datfiles: seq-easy 

Log message:
satisfy the number version of the quiz; with mglocker

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/20 22:56:27

Modified files:
games/quiz/datfiles: seq-easy 

Log message:
Add a simple random number sequence to the questions
ok mglocker

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/20 21:16:25

Modified files:
sys/kern   : exec_elf.c 

Log message:
If binaries lack a pintable, execve() can now reject them at startup
by returning EINVAL, rather than at runtime when the first system call
occurs (and then probably dumping core).  Let's find out if there are
any surprising exceptions we were unaware of (would need a custom linker,
or a non-crt0 runtime)
errno discussions with kettenis, sthen, millert. Vague concensus it is
worth trying now.

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/20 21:07:45

Modified files:
bin/ps : ps.1 
sys/sys: proc.h 
sys/kern   : exec_elf.c kern_exec.c kern_fork.c 
sys/uvm: uvm_mmap.c 

Log message:
We do not need the PS_LIBCPIN and PS_PIN flag fields anymore, which were
used during devlopment (for visibility). There is speculation claudio will
immediately use these bits for something else.

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/20 10:24:50

Modified files:
sys/arch/armv7/omap: omehci.c omohci.c 

Log message:
match the config_activate_children() sequences found in other usb host
controller drivers.

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/20 10:07:14

Modified files:
games/phantasia: COPYRIGHT 
Removed files:
games/phantasia: OWNER 

Log message:
having a file called "OWNER" lying around in a directory of
(effectively) public dommain software is weird.  put that info
into a better place.

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/20 09:48:32

Modified files:
games/atc  : log.c 

Log message:
annotate signal race

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/19 23:22:05

Modified files:
usr.bin/indent : README 

Log message:
nasty whitespace

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/19 08:46:41

Modified files:
usr.bin/gprof  : gprof.flat 

Log message:
whitespaces

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/19 08:24:24

Modified files:
sys/dev/i2c: iatp.c 

Log message:
now that suspend operations are done as quiesce, we can try to use
the MXT_T7_POWER_MODE_DEEP_SLEEP operation.

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/18 19:43:23

Modified files:
regress/bin/ed : Makefile 
Added files:
regress/bin/ed : README TODO a.d a.r a.t a1.err a2.err addr.d 
 addr.r addr.t addr1.err addr2.err ascii.d 
 ascii.r ascii.t bang1.d bang1.err bang1.r 
 bang1.t bang2.err c.d c.r c.t c1.err c2.err 
 ckscripts.sh d.d d.err d.r d.t d0.d d0.r d0.t 
 d1.d d1.r d1.t d2.d d2.r d2.t d3.d d3.r d3.t 
 d4.d d4.r d4.t d5.d d5.r d5.t e1.d e1.err e1.r 
 e1.t e2.d e2.err e2.r e2.t e3.d e3.err e3.r 
 e3.t e4.d e4.r e4.t eq.err f1.err f2.err g1.d 
 g1.err g1.r g1.t g2.d g2.err g2.r g2.t g3.d 
 g3.err g3.r g3.t g4.d g4.r g4.t g5.d g5.r g5.t 
 h.err i.d i.r i.t i0.d i0.r i0.t i1.err i2.err 
 j.d j.r j.t k.d k.r k.t k1.err k2.err k3.err 
 k4.err l.d l.r l.t m.d m.err m.r m.t 
 mkscripts.sh n.d n.r n.t nl1.d nl1.r nl1.t 
 nl2.d nl2.r nl2.t p.d p.r p.t q.d q.r q.t 
 q1.err r1.d r1.err r1.r r1.t r2.d r2.err r2.r 
 r2.t r3.d r3.r r3.t s1.d s1.err s1.r s1.t 
 s10.err s2.d s2.r s2.t s3.d s3.err s3.r s3.t 
 s4.d s4.err s4.r s4.t s5.err s6.err s7.err 
 s8.err s9.err t.d t.r t.t t1.d t1.err t1.r t1.t 
 t2.d t2.err t2.r t2.t u.d u.err u.r u.t v.d v.r 
 v.t w.d w.r w.t w1.err w2.err w3.err x.err 
 z.err 
Removed files:
bin/ed/test: Makefile README TODO a.d a.r a.t a1.err a2.err 
 addr.d addr.r addr.t addr1.err addr2.err 
 ascii.d ascii.r ascii.t bang1.d bang1.err 
 bang1.r bang1.t bang2.err c.d c.r c.t c1.err 
 c2.err ckscripts.sh d.d d.err d.r d.t d0.d d0.r 
 d0.t d1.d d1.r d1.t d2.d d2.r d2.t d3.d d3.r 
 d3.t d4.d d4.r d4.t d5.d d5.r d5.t e1.d e1.err 
 e1.r e1.t e2.d e2.err e2.r e2.t e3.d e3.err 
 e3.r e3.t e4.d e4.r e4.t eq.err f1.err f2.err 
 g1.d g1.err g1.r g1.t g2.d g2.err g2.r g2.t 
 g3.d g3.err g3.r g3.t g4.d g4.r g4.t g5.d g5.r 
 g5.t h.err i.d i.r i.t i0.d i0.r i0.t i1.err 
 i2.err j.d j.r j.t k.d k.r k.t k1.err k2.err 
 k3.err k4.err l.d l.r l.t m.d m.err m.r m.t 
 mkscripts.sh n.d n.r n.t nl1.d nl1.r nl1.t 
 nl2.d nl2.r nl2.t p.d p.r p.t q.d q.r q.t 
 q1.err r1.d r1.err r1.r r1.t r2.d r2.err r2.r 
 r2.t r3.d r3.r r3.t s1.d s1.err s1.r s1.t 
 s10.err s2.d s2.r s2.t s3.d s3.err s3.r s3.t 
 s4.d s4.err s4.r s4.t s5.err s6.err s7.err 
 s8.err s9.err t.d t.r t.t t1.d t1.err t1.r t1.t 
 t2.d t2.err t2.r t2.t u.d u.err u.r u.t v.d v.r 
 v.t w.d w.r w.t w1.err w2.err w3.err x.err 
 z.err 

Log message:
move ed/tests files to regress/bin/ed, where they are used

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/18 19:04:10

Removed files:
games/hack : OWNER 

Log message:
file not needed

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/18 19:03:12

Modified files:
games/hack : rumors 

Log message:
spelling error, fixed by "snj", 21 years ago in some other repository

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/18 18:58:09

Modified files:
games/adventure: glorkz 

Log message:
21 years ago someone called "jsm" modified another version of this which is
also being distributed, with commit message "Fix capitalisation of compass 
directions."
Seems sensible.

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/18 18:52:05

Modified files:
share/dict : web2a 

Log message:
fix a spelling error found by Ceri Davis 18 years ago.

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/18 18:03:12

Modified files:
sys/dev/pv : pvbus.c 

Log message:
pvbus_activate does nothing except call config_activate_children
(4 possible cases).  it does not need to exist.  encoding NULL
into the cfattach structure does the same thing.

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/18 18:01:40

Modified files:
sys/dev/pci: glxpcib.c 

Log message:
call activate functions of children in the correct place.

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/18 16:06:40

Modified files:
usr.bin/m4 : NOTES 

Log message:
whitespaces

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/18 14:14:49

Modified files:
gnu/usr.bin: Makefile.inc 

Log message:
fix comment

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/18 14:08:58

Modified files:
usr.sbin/pppd/chat: Makefile 

Log message:
fix comment

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/18 13:58:35

Modified files:
usr.bin/cal: README cal.c 

Log message:
whitespace

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/18 09:50:49

Modified files:
sys/arch/arm/cortex: cortex.c 
sys/arch/arm/mainbus: mainbus.c 
sys/arch/arm64/dev: mainbus.c 
sys/arch/i386/i386: bios.c mainbus.c 
sys/arch/powerpc64/dev: mainbus.c 
sys/arch/riscv64/dev: mainbus.c 

Log message:
don't need to put config_activate_children inside cfattach, because
NULL means the same
ok kettenis

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/18 09:09:49

Modified files:
sys/dev/pckbc  : pms.c 

Log message:
Driver was not calling the child activate functions in the correct way.
There is a child -- wsmouse, which has an activate function, so this
is another oversight...

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/18 09:03:01

Modified files:
sys/dev/sdmmc  : sdmmc.c 

Log message:
For DVACT_RESUME, let the children know we are ready *after* calling
our own wakeup().  The wakeup() won't result in anything running now
because DVACT_RESUME is running in "cold !=0, interrupts blocked,
scheduler stopped", but it is idiomatically incorrect to inform your
children you are ready before you are ready.

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/18 08:42:56

Modified files:
sys/dev/pci: auixp.c azalia.c cs4280.c cs4281.c esa.c eso.c 
 maestro.c yds.c 

Log message:
Most audio drivers were incorrectly (or not at all) informing their children
about suspend/resume related events, and they all have audio.c as a child,
which definately needs to know!
ok ratchov

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/18 08:35:14

Modified files:
sys/dev/pci: azalia.c 

Log message:
there are azalia that will fail to attach.  in the activate function for
DVACT_QUIESCE, this was handled by doing nothing.  however, the other
DVACT methods were still trying to touch the device.  This needs to
bail out earlier.
ok ratchov

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/17 21:25:04

Modified files:
sys/dev/i2c: iatp.c ietp.c ihidev.c 

Log message:
add missing child activate handling, found due to idiom inspection
tested by phessler, input from kettenis

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/17 20:59:51

Modified files:
sys/dev/usb: usb.c 

Log message:
Upon resume, run usb_attach_roothub() in DVACT_WAKEUP rather than DVACT_RESUME.
The usb root hub is a software construct, not actual hardware, and the code
has a potential to reach sleeping points (which won't work because DVACT_RESUME
runs cold).

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/17 20:53:08

Modified files:
sys/dev/acpi   : acpi.c 

Log message:
If FADT indicates FADT_POWER_S0_IDLE_CAPABLE, print "S0ix" instead
of "S0" on the acpi: sleep states line.  (In my view, this flag-bit
announces that the hardware vendor + bios vendor + microsoft have agreed
this machine has enough "features" that S0 suspend is about as good or
better than S3, for various criteria).
ok kettenis mlarkin

Re: CVS: cvs.openbsd.org: src

[Theo de Raadt]

You said suspend/resume

Do you mean for DVACT_WAKEUP?  That's run with sleep allowed.

Some drivers fix their hardware without sleeps in DVACT_RESUME.
Others, do this async with sleeps in DVACT_WAKEUP.  If you can
gaurantee that no io transactions happen async to you, then
what you do now is fine.  And I see the same structure in other
net80211 drivers.

Stefan Sperling  wrote:

> CVSROOT:  /cvs
> Module name:  src
> Changes by:   s...@cvs.openbsd.org2024/08/17 02:12:46
> 
> Modified files:
>   sys/dev/ic : qwx.c 
> 
> Log message:
> enable qwx(4) ext irqs earlier for suspend/resume
> 
> Enable ext IRQs like the Linux driver does it, not later. I did this
> differently due to problems in early development that have since
> been fixed.
> 
> Fixes an interrupt storm during resume which prevents things like
> key installation from working, leaving the network link dead.
> 

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/17 09:10:00

Modified files:
sys/dev/i2c: icc.c 

Log message:
icc_detach was not listed in cfattach

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/16 20:35:00

Modified files:
sys/dev/ic : dwiic.c 

Log message:
whitespace

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/16 20:31:15

Modified files:
sys/dev/pci: dwiic_pci.c 

Log message:
perusing drivers on other systems, there appears to be some cynism about
how this chip comes out of D3 and when the RESET register is touched.
Some systems were still wasn't resuming reliabily, but adding these
delays has eliminated resume-hangs.
ok kettenis mlarkin

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/16 20:28:45

Modified files:
sys/dev/ic : dwiic.c 

Log message:
The dwiic_init() routine is used at startup to read various chip
registers, make some decisions, and then program other registers.  After
a resume, it is pointless, and potentially incorrect to read such registers
again, which a BIOS or something may not have initialized, and we are
better off using the remembered soft-state to init cleanly.  So craft a
custom block of chip restoration, and do it while the chip is stopped hard.
ok kettenis mlarkin

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/16 20:24:06

Modified files:
sys/dev/ic : dwiic.c 
sys/dev/pci: dwiic_pci.c 

Log message:
dwiic_activate did not inform sub-devices with config_activate_children()
calls from the correct places, so their DVACT_QUIESCE and DVACT_WAKEUP
were incorrect, and led to those sub-drivers (ihidev and imt) racing
against dwiic hardware re-initialization.
ok kettenis mlarkin

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/16 20:14:21

Modified files:
sys/dev/ic : dwiic.c 
sys/dev/pci: dwiic_pci.c 

Log message:
dwiic resume is almost exclusively a "hardware state restore", and
not a "restart transaction", so the job should get done at DVACT_RESUME
time.
ok kettenis mlarkin

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/16 10:57:02

Modified files:
distrib/sets/lists/base: mi 

Log message:
sync

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/16 09:27:11

Modified files:
sys/dev/ic : dwiic.c 

Log message:
whitespace

Re: CVS: cvs.openbsd.org: src

[Theo de Raadt]

I'm no sure we should call it "BROKEN SUSPEND".
It suspends, in our way.  It just has a bug in CRS for RESUME.

So maybe BROKEN_CRS?

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/15 22:14:27

Modified files:
sys/dev/ic : dwiic.c 

Log message:
delete disabled ACPI-related code in here, this power management is
done at a different level, and nothing needs to be done here
ok kettenis

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/15 11:30:40

Modified files:
sys/dev/acpi   : acpisurface.c 

Log message:
whitespace

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/15 10:55:06

Modified files:
distrib/sets/lists/base: mi 

Log message:
sync

CVS: cvs.openbsd.org: src

[Theo de Raadt]

CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2024/08/15 08:43:28

Modified files:
distrib/sets/lists/comp: mi 

Log message:
sync