Re: CVS commit: src/sys/kern

2009-03-26 Thread David Laight
On Wed, Mar 25, 2009 at 09:48:37PM +, David Young wrote:
 Module Name:  src
 Committed By: dyoung
 Date: Wed Mar 25 21:48:37 UTC 2009
 
 Modified Files:
   src/sys/kern: subr_autoconf.c
 
 Log Message:
 ctags(1) gets confused by 'typedef struct X { } X_t', so break 'typedef
 struct pmf_private { ... } pmf_private_t' into a struct definition and a
 typedef definition.

Surely it is better to fix ctags 

David

-- 
David Laight: da...@l8s.co.uk


Re: CVS commit: othersrc/zfs/external/cddl/osnet/dist

2009-03-26 Thread Simon Burge
Andrew Doran wrote:

 Module Name:  othersrc
 Committed By: ad
 Date: Thu Mar 26 21:50:47 UTC 2009
 
 Modified Files:
 
   othersrc/zfs/external/cddl/osnet/dist/cmd/zpool: zpool_vdev.c
   othersrc/zfs/external/cddl/osnet/dist/cmd/ztest: ztest.c
   othersrc/zfs/external/cddl/osnet/dist/uts/common/fs/zfs: arc.c dmu.c
   dsl_deleg.c spa.c spa_history.c vdev_disk.c zfs_ctldir.c zfs_dir.c
   zfs_ioctl.c zfs_vfsops.c zfs_znode.c zvol.c
   othersrc/zfs/external/cddl/osnet/dist/uts/common/fs/zfs/sys:
   vdev_disk.h zfs_znode.h zvol.h
 
 Log Message:
 
 Apply NetBSD changes.

Just out of interest...


Index: othersrc/zfs/external/cddl/osnet/dist/uts/common/fs/zfs/arc.c
diff -u othersrc/zfs/external/cddl/osnet/dist/uts/common/fs/zfs/arc.c:1.1.1.1 
othersrc/zfs/external/cddl/osnet/dist/uts/common/fs/zfs/arc.c:1.2
--- othersrc/zfs/external/cddl/osnet/dist/uts/common/fs/zfs/arc.c:1.1.1.1   
Fri Mar 27 08:43:43 2009
+++ othersrc/zfs/external/cddl/osnet/dist/uts/common/fs/zfs/arc.c   Fri Mar 
27 08:50:47 2009
@@ -133,6 +133,42 @@
 #include sys/callb.h
 #include sys/kstat.h
   
+#ifdef __NetBSD__
+#include uvm/uvm.h
+#definebtop(x) ((x) * PAGE_SIZE)
  [ ... ]

Isn't that working out pages to bytes and not bytes to pages ?

Unless btop() means something non-obvious in Solaris land...

Simon.


Re: CVS commit: othersrc/zfs/external/cddl/osnet/dist

2009-03-26 Thread Andrew Doran
On Thu, Mar 26, 2009 at 10:21:49PM +, Andrew Doran wrote:
 On Fri, Mar 27, 2009 at 09:14:40AM +1100, Simon Burge wrote:
 
  +#ifdef __NetBSD__
  +#include uvm/uvm.h
  +#definebtop(x) ((x) * PAGE_SIZE)
[ ... ]
  
  Isn't that working out pages to bytes and not bytes to pages ?
  
  Unless btop() means something non-obvious in Solaris land...
 
 Probably, please fix ;-)

By the way, this is basically the tarball that I posted to tech-kern in
January: it doesn't work yet. Interest has been expressed in finishing it.


Re: CVS commit: src/usr.bin/make

2009-03-26 Thread David Holland
On Tue, Mar 24, 2009 at 11:41:11AM -0400, Perry E. Metzger wrote:
 Consider building NetBSD 0.9 today.  As it was, MAKE_VERSION would
 seem quite modern, but the make would really be quite old.
  
   Using the last rcsid time would at least fix that...
  
  Not really, because branches have non-linear temporal connections to
  each other.

It would fix NetBSD 5.0 vs. NetBSD 0.9, though, because those branches
are strictly ordered.

  Again, I think that if one wanted to be serious about
  this, one would need to have manual management of version
  numbers.

Yes.

Anyhow, I talked to sjg about this and the conclusion is that
MAKE_VERSION does need to get defined to something in all builds of
make, and it really ought to be maintained properly too.

For now the makefile should pass a fixed date stamp (may as well go
with 20090326) and at some future point we can move this out of the
makefile and create a version.h for it.

The version should be bumped when new language features are added,
akin to config(1)'s version.

Do you want to do this or should I?

-- 
David A. Holland
dholl...@netbsd.org