Re: CVS commit: src/sys/kern

2009-08-13 Thread Alan Barrett
On Thu, 13 Aug 2009, Adam Hamsik wrote:
 Modified Files:
   src/sys/kern: sys_generic.c
 
 Log Message:
 Allow undescribed, direct ioctls as used by Unix. This capability was removed 
 in BSD, presumably because nothing used it any more.
 Third party system software written for Unix (like ZFS) requires this to work 
 without significant modifications.

What is an undescribed, direct ioctl, and where is it documented?

I thought NetBSD was a kind of Unix.  Perhaps you meant as used by
insert version of unix here.

And please don't write log messages with lines longer than 80 chars.

 Ok supremeleader@

Who?

--apb (Alan Barrett)


Re: CVS commit: src/sys/kern

2009-08-13 Thread David Laight
On Thu, Aug 13, 2009 at 08:41:36PM +0200, Alan Barrett wrote:
 What is an undescribed, direct ioctl, and where is it documented?

Probably one that doesn't abuse the cmd field to include the length etc!

David

-- 
David Laight: da...@l8s.co.uk


Re: CVS commit: src/sys/kern

2009-08-13 Thread Matthias Drochner

a...@cequrux.com said:
 What is an undescribed, direct ioctl, and where is it documented?

As I understand it this is where the third ioctl argument is used
as data instead of a pointer to data.
This is only useful to provide source compatibility to non-BSD
sources, and there are ways to get that without tainting the
interface at that high level.
Also, there might be problems with 32/64bit compatibility.
Look for the term gross and disgusting hack in
sys/dev/wscons/wsdisplay_compat_usl.c.

best regards
Matthias





Forschungszentrum Juelich GmbH
52425 Juelich
Sitz der Gesellschaft: Juelich
Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498
Vorsitzende des Aufsichtsrats: MinDir'in Baerbel Brumme-Bothe
Geschaeftsfuehrung: Prof. Dr. Achim Bachem (Vorsitzender),
Dr. Ulrich Krafft (stellv. Vorsitzender), Prof. Dr.-Ing. Harald Bolt,
Prof. Dr. Sebastian M. Schmidt




Re: CVS commit: src/usr.bin/error

2009-08-13 Thread David Holland
On Thu, Aug 13, 2009 at 03:46:39PM +, Christos Zoulas wrote:
  XXX: does this program actually do anything useful these days?
  
  Yes, it works just fine :-) I use it all the time.

Better you than me :-)

Maybe it should lose support for compilers that disappeared twenty
years ago, though.

-- 
David A. Holland
dholl...@netbsd.org


Re: CVS commit: src/usr.bin/error

2009-08-13 Thread Christos Zoulas
On Aug 13, 10:19pm, dholland-sourcechan...@netbsd.org (David Holland) wrote:
-- Subject: Re: CVS commit: src/usr.bin/error

| On Thu, Aug 13, 2009 at 03:46:39PM +, Christos Zoulas wrote:
|   XXX: does this program actually do anything useful these days?
|   
|   Yes, it works just fine :-) I use it all the time.
| 
| Better you than me :-)
| 
| Maybe it should lose support for compilers that disappeared twenty
| years ago, though.

The error reporting syntax has not changed much!

christos


Re: CVS commit: src/usr.bin/error

2009-08-13 Thread M. Warner Losh
In message: 20090814021047.91ed856...@rebar.astron.com
chris...@zoulas.com (Christos Zoulas) writes:
: On Aug 13, 10:19pm, dholland-sourcechan...@netbsd.org (David Holland) wrote:
: -- Subject: Re: CVS commit: src/usr.bin/error
: 
: | On Thu, Aug 13, 2009 at 03:46:39PM +, Christos Zoulas wrote:
: |   XXX: does this program actually do anything useful these days?
: |   
: |   Yes, it works just fine :-) I use it all the time.
: | 
: | Better you than me :-)
: | 
: | Maybe it should lose support for compilers that disappeared twenty
: | years ago, though.
: 
: The error reporting syntax has not changed much!

Besides, how much space would it really save?

Warner


Re: CVS commit: src/usr.bin/error

2009-08-13 Thread David Holland
On Thu, Aug 13, 2009 at 08:38:18PM -0600, M. Warner Losh wrote:
  : | Maybe it should lose support for compilers that disappeared twenty
  : | years ago, though.
  : 
  : The error reporting syntax has not changed much!
  
  Besides, how much space would it really save?

In the brain of the next person hacking that code? Quite a bit... :-|

-- 
David A. Holland
dholl...@netbsd.org