Re: CVS commit: src/distrib

2009-09-18 Thread Alan Barrett 
On Fri, 18 Sep 2009, David Brownlee wrote:
 Index: src/distrib/common/runlist.sh
  [...]
 +( while [ X$1 != X ]; do
 + cat $1
 + shift
 +done ) | awk -f ${NETBSDSRCDIR}/distrib/common/list2sh.awk | ${SHELLCMD}

Why is the while loop necessary?  Why not just use

awk -f .../list2sh.awk $@

As far as I can tell, the only difference between the while loop an my
suggestion is in the behaviour when there are no args (which might
never happen, or which can be handled by an additional test), or the
behaviour when one of the args is an empty string (which I hope never
happens).

--apb (Alan Barrett)

Re: CVS commit: src/usr.sbin/puffs/rump_smbfs

2009-09-18 Thread David Laight 
On Thu, Sep 17, 2009 at 09:05:38AM +0100, Nick Hudson wrote:
 
  People are most welcome to fix this ugliness 
  properly by helping to get rid of link sets in the kernel.
 
 I'm glad you agree that link sets are ugly. On the matter of a getting rid of 
 them I did offer to discuss a solution, but was ignored. 

Like all things they have their place, but overuse can be a problem.

For instance they could solve the problem of getting an intial entry
point (code or data) into a kernel 'module' that has being linked
into a kernel with 'ld -r'.
(when modules are loaded it is possibly to do a symbol lookup...)

There are probably other places where it is difficult to call an
explicit initialiser.

It is all rather similar to the proliferation of memory pools - for
things where 'malloc' would be fine.

David

-- 
David Laight: da...@l8s.co.uk

Re: CVS commit: src/usr.sbin/puffs/rump_smbfs

2009-09-18 Thread Jason Thorpe 


On Sep 18, 2009, at 9:10 AM, David Laight wrote:


It is all rather similar to the proliferation of memory pools - for
things where 'malloc' would be fine.


The old-school kernel malloc was almost never fine ... but pools  
have another advantage -- use of a direct-mapped segment on  
architectures so-equipped.  And for those not so-equipped, greatly  
reduced pressure on kmem_map.


Now, if we could only get rid of kmem_map / kernel malloc completely  
(which requires making it illegal to allocate memory in interrupt  
context).


-- thorpej