Re: CVS commit: src/gnu/dist/gdb6/gdb

2009-11-28 Thread David Laight
On Sat, Nov 28, 2009 at 08:29:43AM +0900, enami tsugutomo wrote:
   i wonder if we can re-add proc0paddr, defined to be = lwp0.l_addr
   at some point in main, to help this work with older gdb?
   
   this seems like a worth-while change since it's part of bsd-kvm.c.
  
  would need to be in md code since L_ADDR needs to come from assym.h.
  
  .globl  _C_LABEL(proc0paddr)
  _C_LABEL(proc0paddr) = _C_LABEL(lwp0) + L_ADDR
 
 Is initializing it in main() too late?  I mean putting proc0paddr =
 lwp_getpcb(lwp0) at the beginning of main().

The above is defining a global symbol that referes to the middle of
a struct, not setting a memory location to the address of the it.

David

-- 
David Laight: da...@l8s.co.uk


Re: CVS commit: src/gnu/dist/gdb6/gdb

2009-11-28 Thread enami tsugutomo
 The above is defining a global symbol that referes to the middle of
 a struct, not setting a memory location to the address of the it.

Do you mean lwp0.l_addr may vary during execution?

enami.


Re: CVS commit: src/sys/compat

2009-11-28 Thread David Laight
On Sat, Nov 28, 2009 at 11:21:30PM +0100, Joerg Sonnenberger wrote:
 Are you sure about the PR?

should have been 31368 :-(

David

-- 
David Laight: da...@l8s.co.uk


Re: CVS commit: src/sys/net

2009-11-28 Thread Tetsuya Isaki
At Sat, 28 Nov 2009 10:23:44 +0100,
Marc Balmer wrote:
  +   case ETHERTYPE_AARP:
  /* probably this should be done with a NETISR as well */
  -   aarpinput(ifp, m); /* XXX */
  -   return;
  +   arpinput(ifp, m); /* XXX */
  +   return;
  #endif /* NETATALK */
  default:
  m_freem(m);
  
 
 the last hunk is wrong and broke the release build.  note that you stripped 
 an 'a' from the aarpinput() funtion name.
 (I fixed it in the tree, btw.)

Oops, sorry. and thank you to fix it.
---
Tetsuya Isaki is...@netbsd.org