Re: CVS commit: src/lib/libc/arch/m68k/gen
In article 20091129042013.gm4...@x300.tombi.co.jp, Masao Uebayashi uebay...@tombi.co.jp wrote: Module Name: src Committed By:christos Date:Sat Nov 28 23:46:39 UTC 2009 Modified Files: src/lib/libc/arch/m68k/gen: Makefile.inc Added Files: src/lib/libc/arch/m68k/gen: fpfake.c Log Message: Add no/op routines for m68000 for the sticky, mask, and round settings. Could you consider to improve the quality of commit messages always explain the reason of the changes? :) Fixes the build? Does not link otherwise? christos
Re: CVS commit: src/share/mk
On Sun, Nov 29, 2009 at 04:00:00PM +, Masao Uebayashi wrote:
Module Name: src
Committed By: uebayasi
Date: Sun Nov 29 16:00:00 UTC 2009
Modified Files:
src/share/mk: bsd.subdir.mk
Log Message:
Remove an unneeded test (.if defined(V)) in .for v in ${V} ... .endfor.
Tested by running build.sh distribution.
Some versions of make error ${V} when V is undefined.
Safer is ${V:U}
David
--
David Laight: da...@l8s.co.uk
re: CVS commit: src/sys
Tobias Nygren t...@netbsd.org wrote: Log Message: Restore exporting of lwp_getpcb() to userland and fix DDB properly. While the header might be abstracted better, it is a separate issue. This causes breakage for programs that compile with -ansi or -std=c89: ... In file included from /usr/include/sys/proc.h:83, from /usr/include/sys/sysctl.h:46, from test.c:2: /usr/include/sys/lwp.h:200: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'void' I've committed a quick fix. However, the problem here is that sys/sysctl.h, sys/proc.h and sys/lwp.h are exposing structures for KVM grovellers to all userspace. Therefore struct kinfo_proc2, sys/proc.h and friends should not even be seen. We will revisit this, hopefully.. struct kinfo_proc2 is _100%_ for exporting to userland. that's the sole purpose it exists... .mrg.
Re: CVS commit: src/sys
matthew green m...@eterna.com.au wrote: I've committed a quick fix. However, the problem here is that sys/sysctl.h, sys/proc.h and sys/lwp.h are exposing structures for KVM grovellers to all userspace. Therefore struct kinfo_proc2, sys/proc.h and friends should not even be seen. We will revisit this, hopefully.. struct kinfo_proc2 is _100%_ for exporting to userland. that's the sole purpose it exists... Yes, but does it need to be in public namespace in sysctl.h? It is a part of separate interface - kvm(3), rarely used by regular applications. And more to the point, it includes struct proc, struct lwp and so on, which is messy. I realise that we probably cannot do much without breaking backwards compatibility, though.. -- Mindaugas
re: CVS commit: src/sys
matthew green m...@eterna.com.au wrote: I've committed a quick fix. However, the problem here is that sys/sysctl.h, sys/proc.h and sys/lwp.h are exposing structures for KVM grovellers to all userspace. Therefore struct kinfo_proc2, sys/proc.h and friends should not even be seen. We will revisit this, hopefully.. struct kinfo_proc2 is _100%_ for exporting to userland. that's the sole purpose it exists... Yes, but does it need to be in public namespace in sysctl.h? It is a part of separate interface - kvm(3), rarely used by regular applications. And more to the point, it includes struct proc, struct lwp and so on, which is messy. I realise that we probably cannot do much without breaking backwards compatibility, though.. you're misreading something. struct kinfo_proc is not binary compatable. but a long time ago we introduced struct kinfo_proc2 that _is_ forwards compatible and is part of the reason that ps(1) works just fine on new kernels these days. .mrg.
Re: CVS commit: src/share/mk
On Sun, Nov 29, 2009 at 06:43:10PM +, David Laight wrote:
Modified Files:
src/share/mk: bsd.subdir.mk
Log Message:
Remove an unneeded test (.if defined(V)) in .for v in ${V} ... .endfor.
Tested by running build.sh distribution.
Some versions of make error ${V} when V is undefined.
Safer is ${V:U}
...versions of *our* make?
--
David A. Holland
dholl...@netbsd.org
