re: CVS commit: src/lib/libc/stdio

2009-11-30 Thread matthew green

   Module Name: src
   Committed By:roy
   Date:Tue Dec  1 00:03:53 UTC 2009
   
   Modified Files:
src/lib/libc/stdio: fgetstr.c getdelim.c local.h
   
   Log Message:
   Remove __getdelim and just use getdelim.


this isn't right.  now someone can provide their own getdelim
function and override what fgetstr.c uses.

please put getdelim() under the same protection in namepsace.h
that all the other functions there have.



.mrg.


Re: CVS commit: src/lib/libc/stdio

2009-11-30 Thread Joerg Sonnenberger
On Mon, Nov 30, 2009 at 10:51:46PM +, Roy Marples wrote:
> Module Name:  src
> Committed By: roy
> Date: Mon Nov 30 22:51:46 UTC 2009
> 
> Modified Files:
>   src/lib/libc/stdio: getdelim.3
> 
> Log Message:
> Note that EOF returns -1 when no characters are read.
> Add code example.

Should this be explicit that errno is *not* set, but only feof() will be
true?

Joerg


Re: CVS commit: src/sys/arch/arm/arm32

2009-11-30 Thread Rafal Boni
On Sat, Nov 28, 2009 at 11:44:45AM +, Steve Woodford wrote:
> Module Name:  src
> Committed By: scw
> Date: Sat Nov 28 11:44:45 UTC 2009
> 
> Modified Files:
>   src/sys/arch/arm/arm32: pmap.c
> 
> Log Message:
> Apply some band-aid to pmap_activate() for PR kern/41058:
> 
> There's a corner case here which can leave turds in the cache as
> reported in kern/41058. They're probably left over during tear-down and
> switching away from an exiting process. Until the root cause is identified
> and fixed, zap the cache when switching pmaps. This will result in a few
> unnecessary cache flushes, but that's better than silently corrupting data.
> 
> Also remove an extraneous return statement in pmap_page_protect() which
> crept in during the matt-armv6 merge.

Hmm, this reminds me of port-arm/38950, where we were seeing hangs on exit
due to some don't-need-to-do-full-context-switch optimizations.  Could the
two issues be related?  I haven't looked at this issue, but I did do a bunch
of analysis for port-arm/38950, there's a fair bit of background there.

--rafal

-- 
  Time is an illusion; lunchtime, doubly so. |/\/\|   Rafal Boni
   -- Ford Prefect   |\/\/|  ra...@pobox.com