CVS commit: src/sys/miscfs/genfs
Module Name:src Committed By: uebayasi Date: Sat Jan 30 05:19:20 UTC 2010 Modified Files: src/sys/miscfs/genfs: genfs_io.c Log Message: Slightly more descriptive local variable names. To generate a diff of this commit: cvs rdiff -u -r1.34 -r1.35 src/sys/miscfs/genfs/genfs_io.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/rump/dev/lib/libdisk
Module Name:src Committed By: pooka Date: Sat Jan 30 05:09:24 UTC 2010 Removed Files: src/sys/rump/dev/lib/libdisk: dummy.c Log Message: no longer used To generate a diff of this commit: cvs rdiff -u -r1.1 -r0 src/sys/rump/dev/lib/libdisk/dummy.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.sbin/envstat
Module Name:src Committed By: pgoyette Date: Sat Jan 30 02:56:39 UTC 2010 Modified Files: src/usr.sbin/envstat: envstat.8 envstat.c Log Message: Since we never have both a limit value and a limit %capacity value, remove the Capacity column. Reduce inter-column spacing, and display all four limits on one page, rather than using the -W command line option to switch between critical and warning limits. (The -W option is still permitted, but has no effect.) %capacity limits are displayed in the WarnMin and CritMin columns, but have a trailing % sign. To generate a diff of this commit: cvs rdiff -u -r1.51 -r1.52 src/usr.sbin/envstat/envstat.8 cvs rdiff -u -r1.72 -r1.73 src/usr.sbin/envstat/envstat.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/sysmon
Module Name:src Committed By: pgoyette Date: Sat Jan 30 02:46:53 UTC 2010 Modified Files: src/sys/dev/sysmon: sysmon_envsys.c sysmon_envsys_events.c Log Message: Validate limit-based monitoring in one place, so we can apply the constraints to both driver-requested and user-requested monitoring. While here, clean up some of the debugging DPRINTFs. To generate a diff of this commit: cvs rdiff -u -r1.90 -r1.91 src/sys/dev/sysmon/sysmon_envsys.c cvs rdiff -u -r1.76 -r1.77 src/sys/dev/sysmon/sysmon_envsys_events.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src
> 4. Could be. I don't like to code solutions for future/non existing >problems though. Well I had a patch with the solution and was waiting feedback, but you beated me without any comments for my patch. I was disgusted a bit since I spent a day to prepare the patch. Sorry. --- Izumi Tsutsui
CVS commit: src/sys/dev/sbus
Module Name:src Committed By: macallan Date: Fri Jan 29 23:50:01 UTC 2010 Modified Files: src/sys/dev/sbus: agten.c Log Message: avoid using PAGE_SIZE directly so sparc/GENERIC builds again To generate a diff of this commit: cvs rdiff -u -r1.23 -r1.24 src/sys/dev/sbus/agten.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/lib/libc/net
Module Name:src Committed By: is Date: Fri Jan 29 22:26:48 UTC 2010 Modified Files: src/lib/libc/net: getnameinfo.c Log Message: Print AppleTalk phase 2 range, too, if available. To generate a diff of this commit: cvs rdiff -u -r1.48 -r1.49 src/lib/libc/net/getnameinfo.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src
On Jan 30, 1:34am, tsut...@ceres.dti.ne.jp (Izumi Tsutsui) wrote:
-- Subject: Re: CVS commit: src
| > I know all that, but you are not answering the question. What is broken
| > right now and what are you trying to fix? There is no struct winsize
| > anymore in roken.h...
|
| Hmm.
|
| * Isn't it better to have no changes against src/crypto/dist other
|than including nbtools_config.h just for dumb two host tools?
| * It is not a good idea to edit a generated and expoterd file, either.
|You removed asnprintf() and vasnprintf() from roken.h
|but not roken.h.in, for example.
| * src/tools/compat/configure doesn't check all header files
|referred in src/include/heimdal/roken.h, and the roken.h
|doesn't have HAVE_FOO_H checks.
|Some OS might still fail in asn1_compile and compile_et.
| * There might also be more function decls that don't match for
|ones in some OS like asnprintf().
| * get_windows_size() is an exported function in /usr/lib/libroken.so
|and src/include/heimdal/roken.h is also installed as .
|You might have to bump major if you changed an ABI, strictly.
|
| If you don't think these could be called broken,
| I'm just a paranoia and will shut up.
1. We use nbtools_config.h to provide portability compiling netbsd
programs on other platforms. For things like gcc we use the native
config system. The two heimdal programs look more like netbsd applications
than standalone config candidates.
2. Whoever generated roken.h from roken.h.in, hand edited it afterwards
anyway. The autoconfiguration found that we did not have asnprintf
and vasnprintf and included those functions in roken.h. We never
added sprintf.c in the Makefile for libroken so that was just wrong.
Removing them from roken.h.in is not a change that will be accepted
upstream.
3. For the most part roken.h includes (or should include) posix headers.
I would like to move into that direction instead. Right now it includes
the kitchensink and it does not need to.
4. Could be. I don't like to code solutions for future/non existing
problems though.
5. Yes, perhaps changing the api was a mistake from the perspective
that kerberos programs might expect the old API. It was a stupid
API decision in the first place, but what can we do. I have not
found anything that breaks from that change yet, that is why I
have not reverted it, have you? I still can revert the change
and declare the struct conditionally:
#ifndef TIOCGWINSZ
struct winsize {
...
}
#endif
and avoid using autoconf. I just thought it was silly to depend on
the actual non-portable API to get the number of lines and columns
portably :-)
christos
CVS commit: src/sys/arch/amiga/dev
Module Name:src Committed By: phx Date: Fri Jan 29 19:56:41 UTC 2010 Modified Files: src/sys/arch/amiga/dev: siop.c siop2.c Log Message: Define DCIAS() for amigappc. To generate a diff of this commit: cvs rdiff -u -r1.64 -r1.65 src/sys/arch/amiga/dev/siop.c cvs rdiff -u -r1.36 -r1.37 src/sys/arch/amiga/dev/siop2.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src
> I know all that, but you are not answering the question. What is broken > right now and what are you trying to fix? There is no struct winsize > anymore in roken.h... Hmm. * Isn't it better to have no changes against src/crypto/dist other than including nbtools_config.h just for dumb two host tools? * It is not a good idea to edit a generated and expoterd file, either. You removed asnprintf() and vasnprintf() from roken.h but not roken.h.in, for example. * src/tools/compat/configure doesn't check all header files referred in src/include/heimdal/roken.h, and the roken.h doesn't have HAVE_FOO_H checks. Some OS might still fail in asn1_compile and compile_et. * There might also be more function decls that don't match for ones in some OS like asnprintf(). * get_windows_size() is an exported function in /usr/lib/libroken.so and src/include/heimdal/roken.h is also installed as . You might have to bump major if you changed an ABI, strictly. If you don't think these could be called broken, I'm just a paranoia and will shut up. --- Izumi Tsutsui
CVS commit: src/doc
Module Name:src Committed By: ahoka Date: Fri Jan 29 14:34:32 UTC 2010 Modified Files: src/doc: CHANGES Log Message: Mention new sysinst defaults for cypher selection. To generate a diff of this commit: cvs rdiff -u -r1.1350 -r1.1351 src/doc/CHANGES Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/doc
Module Name:src Committed By: ahoka Date: Fri Jan 29 14:30:58 UTC 2010 Modified Files: src/doc: CHANGES Log Message: Mention wscons font addition. To generate a diff of this commit: cvs rdiff -u -r1.1349 -r1.1350 src/doc/CHANGES Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src
On Jan 29, 8:04pm, tsut...@ceres.dti.ne.jp (Izumi Tsutsui) wrote: -- Subject: Re: CVS commit: src | > Well the manually edited roken.h will need to have HAVE_FOO for each feature | > in order to work across different platforms. What is currently broken in | > the one we have? As far as resolv.h and arpa/nameser.h we need them elsewhere | > too, so we have to fix them anyway. | | * src/crypto/dist/heimdal/lib/roken/roken.h.in has HAVE_FOO for each feature |in order to work across different platforms: I know all that, but you are not answering the question. What is broken right now and what are you trying to fix? There is no struct winsize anymore in roken.h... christos
CVS commit: src/sys/rump/net/rumptest
Module Name:src Committed By: pooka Date: Fri Jan 29 12:34:17 UTC 2010 Modified Files: src/sys/rump/net/rumptest: rumptest_net.c Log Message: * add comment explaining why we randomize the last source ip octet * fix bug in randomization (well, at least with the current configuration ..) To generate a diff of this commit: cvs rdiff -u -r1.18 -r1.19 src/sys/rump/net/rumptest/rumptest_net.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/acpi
Module Name:src Committed By: jruoho Date: Fri Jan 29 12:22:00 UTC 2010 Modified Files: src/sys/dev/acpi: asus_acpi.c Log Message: If we failed to obtain the brightness level during suspend, do not try to restore it with a possible garbage value during resume. To generate a diff of this commit: cvs rdiff -u -r1.14 -r1.15 src/sys/dev/acpi/asus_acpi.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/acpi
Module Name:src Committed By: jruoho Date: Fri Jan 29 11:57:37 UTC 2010 Modified Files: src/sys/dev/acpi: asus_acpi.c Log Message: Replace all AcpiEvaluateObject() calls with acpi_eval_set_integer(). (As the return buffers are not used for anything, no need to make unnecessary temporary allocations.) Compile tested only. ok jmcneill@ To generate a diff of this commit: cvs rdiff -u -r1.13 -r1.14 src/sys/dev/acpi/asus_acpi.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/share/man/man9
Module Name:src Committed By: jruoho Date: Fri Jan 29 11:24:31 UTC 2010 Modified Files: src/share/man/man9: sysmon_pswitch.9 Log Message: Add couple instances of .Pp. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/share/man/man9/sysmon_pswitch.9 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/dev/acpi
Module Name:src Committed By: jruoho Date: Fri Jan 29 11:23:25 UTC 2010 Modified Files: src/sys/dev/acpi: asus_acpi.c Log Message: Fix a memory leak in the resume handler. To generate a diff of this commit: cvs rdiff -u -r1.12 -r1.13 src/sys/dev/acpi/asus_acpi.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src
[should I move this to tech-toolchain?]
chris...@zoulas.com wrote:
> | > | > I think that vasnprintf and asnprintf are not used by anything in
> | > | > heimdal and can safely be removed. Combined with the winsize fix,
> | > | > this fixes the cygwin problems with minimal changes. I am trying a
> | > | > build now.
> | > |
> | > | Note roken.h includes and that don't
> | > | exist on Cygwin so we had to handle it in src/tools/compat/configure.
> | > | (toolchain/29032)
> | >
> | > Which is fine; I'd rather have one place to keep roken.h and deal with
> | > portability in compat, rather than 2.
> |
> | But src/include/heimdal/roken.h is a generated file for NetBSD
> | with unusual method.
> |
> | We might be able to generate roken.h for tools host from
> | src/crypto/dist/heimdal/lib/roken/roken.h.in using
> | src/crypto/dist/heimdal/lib/roken/roken.awk as defined
> | in src/crypto/dist/heimdal/lib/roken/Makefile.am:
> | ---
> | roken.h: make-roken$(EXEEXT)
> | @./make-roken$(EXEEXT) > tmp.h ;\
> | if [ -f roken.h ] && cmp -s tmp.h roken.h ; then rm -f tmp.h ; \
> | else rm -f roken.h; mv tmp.h roken.h; fi
> |
> | make-roken.c: roken.h.in roken.awk
> | $(AWK) -f $(srcdir)/roken.awk $(srcdir)/roken.h.in > make-roken.c
> | ---
> | but it requires all macros like HAVE_FOO referred in roken.h.in
> | and we have to add checks for them into src/tools/compat/configure.ac,
> | as defined in src/include/heimdal/config.h configured for NetBSD.
> |
> | Is it really worth than adding a manually edited dumb roken.h for tools?
>
> Well the manually edited roken.h will need to have HAVE_FOO for each feature
> in order to work across different platforms. What is currently broken in
> the one we have? As far as resolv.h and arpa/nameser.h we need them elsewhere
> too, so we have to fix them anyway.
* src/crypto/dist/heimdal/lib/roken/roken.h.in has HAVE_FOO for each feature
in order to work across different platforms:
---
#ifdef HAVE_ARPA_NAMESER_H
#include
#endif
#ifdef HAVE_RESOLV_H
#include
#endif
:
#if !defined(HAVE_ASNPRINTF) || defined(NEED_ASNPRINTF_PROTO)
int ROKEN_LIB_FUNCTION
asnprintf (char **, size_t, const char *, ...)
__attribute__ ((format (printf, 3, 4)));
#endif
#if !defined(HAVE_VASNPRINTF) || defined(NEED_VASNPRINTF_PROTO)
int ROKEN_LIB_FUNCTION
vasnprintf (char **, size_t, const char *, va_list)
__attribute__((format (printf, 3, 0)));
#endif
:
int ROKEN_LIB_FUNCTION issuid(void);
#ifndef HAVE_STRUCT_WINSIZE
struct winsize {
unsigned short ws_row, ws_col;
unsigned short ws_xpixel, ws_ypixel;
};
#endif
int ROKEN_LIB_FUNCTION get_window_size(int fd, struct winsize *);
:
---
* But heimdal doesn't use it as is for a header file to be installed to
a target system.
* Makefiles in heimdal generate "make-roken.c" from roken.h.in using
src/crypto/dist/heimdal/lib/roken/roken.awk.
* generated make-roken.c is a dumb program to print "pre-processed" lines:
---
#ifdef HAVE_CONFIG_H
#include
#endif
#include
int main(int argc, char **argv)
{
:
#ifdef HAVE_ARPA_NAMESER_H
puts("#include ");
#endif
#ifdef HAVE_RESOLV_H
puts("#include ");
#endif
:
#if !defined(HAVE_ASNPRINTF) || defined(NEED_ASNPRINTF_PROTO)
puts("int ROKEN_LIB_FUNCTION");
puts("asnprintf (char **, size_t, const char *, ...)");
puts(" __attribute__ ((format (printf, 3, 4)));");
#endif
puts("");
#if !defined(HAVE_VASNPRINTF) || defined(NEED_VASNPRINTF_PROTO)
puts("int ROKEN_LIB_FUNCTION");
puts("vasnprintf (char **, size_t, const char *, va_list)");
puts(" __attribute__((format (printf, 3, 0)));");
#endif
puts("");
:
puts("int ROKEN_LIB_FUNCTION issuid(void);");
puts("");
#ifndef HAVE_STRUCT_WINSIZE
puts("struct winsize {");
puts(" unsigned short ws_row, ws_col;");
puts(" unsigned short ws_xpixel, ws_ypixel;");
puts("};");
#endif
puts("");
puts("int ROKEN_LIB_FUNCTION get_window_size(int fd, struct winsize *);");
puts("");
---
* Then generated roken.h (installed into src/include/heimdal/ in NetBSD)
looks like:
---
#include
#include
#include
#include
#include
:
int ROKEN_LIB_FUNCTION
asnprintf (char **, size_t, const char *, ...)
__attribute__ ((format (printf, 3, 4)));
int ROKEN_LIB_FUNCTION
vasnprintf (char **, size_t, const char *, va_list)
__attribute__((format (printf, 3, 0)));
:
int ROKEN_LIB_FUNCTION issuid(void);
int ROKEN_LIB_FUNCTION get_window_size(int fd, struct winsize *);
---
quoted again:
> Well the manually edited roken.h will need to have HAVE_FOO for each feature
> in order to work across different platforms. What is currently broken in
> the one we have?
* As mentioned above, src/include/heimdal/roken.h doesn't have HAVE_FOO
for each features in order to work across different platforms,
so we should not use it for tools build. That's the broken point.
* roken.h required to build src/tools/asn1_compile and src/tools/compile_et
on tools hosts needs to have HAVE_FOO for ea
CVS commit: src/external/bsd/libelf/dist
Module Name:src Committed By: wiz Date: Fri Jan 29 10:49:07 UTC 2010 Modified Files: src/external/bsd/libelf/dist: elf_getdata.3 Log Message: Mark up NULL. Join two sections describing same error. Remove trailing whitespace. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/external/bsd/libelf/dist/elf_getdata.3 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/share/man/man4
Module Name:src Committed By: wiz Date: Fri Jan 29 10:48:45 UTC 2010 Modified Files: src/share/man/man4: ddb.4 Log Message: Bump date for more powerpc commands. To generate a diff of this commit: cvs rdiff -u -r1.132 -r1.133 src/share/man/man4/ddb.4 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sbin/wsconsctl
Module Name:src Committed By: drochner Date: Fri Jan 29 09:49:34 UTC 2010 Modified Files: src/sbin/wsconsctl: keysym.c Log Message: follow KS_GROUP_Ascii->KS_GROUP_Plain rename in kernel, noticed by Andreas Gustafsson To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10 src/sbin/wsconsctl/keysym.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
