CVS commit: src/sbin/gpt
Module Name:src Committed By: mlelstv Date: Sat Feb 20 08:47:10 UTC 2010 Modified Files: src/sbin/gpt: gpt.c Log Message: Initialize device_name before opendisk to avoid unable to open device '(null)' error messages when the opendisk fails. To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10 src/sbin/gpt/gpt.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/lib/libcurses
Module Name:src Committed By: wiz Date: Sat Feb 20 10:23:05 UTC 2010 Modified Files: src/lib/libcurses: curses_line.3 Log Message: Bump date for previous. To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/lib/libcurses/curses_line.3 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/uvm
Module Name:src Committed By: drochner Date: Sat Feb 20 13:21:58 UTC 2010 Modified Files: src/sys/uvm: uvm_map.c Log Message: rename the new sysctl to vm.user_va0_disable, for consistency with the majority of existing sysctl flags, suggested by yamt To generate a diff of this commit: cvs rdiff -u -r1.288 -r1.289 src/sys/uvm/uvm_map.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/rump/dev/lib/libugenhc
Module Name:src Committed By: pooka Date: Sat Feb 20 13:56:29 UTC 2010 Modified Files: src/sys/rump/dev/lib/libugenhc: ugenhc.c Log Message: Fix snafu with error reporting in bulk transfers. To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/sys/rump/dev/lib/libugenhc/ugenhc.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/tools/host-mkdep
Module Name:src Committed By: joerg Date: Sat Feb 20 15:04:04 UTC 2010 Modified Files: src/tools/host-mkdep: host-mkdep.in Log Message: Rewrite argument processing to deal with spaces and other meta characters in options. This was exposed by the NetBSD 5.99 argument of mandoc. To generate a diff of this commit: cvs rdiff -u -r1.17 -r1.18 src/tools/host-mkdep/host-mkdep.in Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/sparc64
Module Name:src Committed By: martin Date: Sat Feb 20 16:46:38 UTC 2010 Modified Files: src/sys/arch/sparc64/include: sparc64.h src/sys/arch/sparc64/sparc64: ipifuncs.c ofw_machdep.c Log Message: Select the shutdown method for secondary CPUs by available firmware methods, not properties of the CPU. Inspired by OpenSolaris, pointed out by eeh. To generate a diff of this commit: cvs rdiff -u -r1.10 -r1.11 src/sys/arch/sparc64/include/sparc64.h cvs rdiff -u -r1.30 -r1.31 src/sys/arch/sparc64/sparc64/ipifuncs.c cvs rdiff -u -r1.36 -r1.37 src/sys/arch/sparc64/sparc64/ofw_machdep.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: [uebayasi-xip] src/sys/arch/arm/arm32
Module Name:src Committed By: uebayasi Date: Sat Feb 20 16:48:57 UTC 2010 Modified Files: src/sys/arch/arm/arm32 [uebayasi-xip]: pmap.c Log Message: Fix \!DIAGNOSTIC build. To generate a diff of this commit: cvs rdiff -u -r1.211.2.7 -r1.211.2.8 src/sys/arch/arm/arm32/pmap.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/tools/tic
Module Name:src Committed By: roy Date: Sat Feb 20 19:04:48 UTC 2010 Modified Files: src/tools/tic: Makefile Log Message: Use HOST_SRCS instead of adding to SRCS for hash.c To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/tools/tic/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/bin/sh
Module Name:src Committed By: christos Date: Sat Feb 20 23:15:17 UTC 2010 Modified Files: src/bin/sh: main.c Log Message: default to the original behavior for $ENV unless POSIXLY_CORRECT is set. To generate a diff of this commit: cvs rdiff -u -r1.54 -r1.55 src/bin/sh/main.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/cddl/osnet
Module Name:src Committed By: darran Date: Sun Feb 21 00:50:01 UTC 2010 Modified Files: src/external/cddl/osnet/dist/cmd/dtrace: dtrace.c src/external/cddl/osnet/dist/lib/libctf/common: ctf_lib.c ctf_subr.c src/external/cddl/osnet/dist/lib/libdtrace/common: drti.c dt_aggregate.c dt_cc.c dt_cg.c dt_consume.c dt_dof.c dt_error.c dt_errtags.h dt_handle.c dt_ident.c dt_impl.h dt_lex.l dt_link.c dt_map.c dt_module.c dt_open.c dt_options.c dt_parser.c dt_pid.c dt_pragma.c dt_printf.c dt_proc.c dt_proc.h dt_program.c dt_provider.c dt_subr.c dt_work.c dtrace.h mkerrtags.sh mknames.sh src/external/cddl/osnet/dist/lib/libgen/common: gmatch.c src/external/cddl/osnet/dist/tools/ctf/common: list.c memory.c src/external/cddl/osnet/dist/tools/ctf/cvt: alist.c alist.h barrier.c barrier.h ctf.c ctfconvert.c ctfmerge.c ctfmerge.h ctftools.h dwarf.c fixup_tdescs.c hash.c iidesc.c input.c merge.c output.c st_parse.c stabs.c strtab.c strtab.h tdata.c traverse.c traverse.h util.c src/external/cddl/osnet/dist/tools/ctf/dump: dump.c src/external/cddl/osnet/dist/uts/common/dtrace: dtrace.c fasttrap.c lockstat.c profile.c sdt_subr.c systrace.c src/external/cddl/osnet/dist/uts/common/sys: ctf.h ctf_api.h dtrace.h dtrace_impl.h src/external/cddl/osnet/include: alloca.h devid.h fcntl.h fsshare.h libintl.h mnttab.h priv.h solaris.h stdio.h stdlib.h strings.h unistd.h zone.h src/external/cddl/osnet/lib: Makefile Makefile.inc src/external/cddl/osnet/lib/libavl: Makefile src/external/cddl/osnet/lib/libnvpair: Makefile src/external/cddl/osnet/lib/libumem: Makefile src/external/cddl/osnet/lib/libuutil: Makefile src/external/cddl/osnet/lib/libzfs: Makefile src/external/cddl/osnet/lib/libzpool: Makefile src/external/cddl/osnet/sys/sys: atomic.h bitmap.h byteorder.h cmn_err.h cpupart.h cpuvar.h cred.h cyclic.h debug.h dirent.h dkio.h dnlc.h elf.h kcondvar.h kidmap.h kmem.h kobj.h kstat.h lock.h misc.h mman.h mnttab.h modctl.h mount.h mutex.h objfs.h param.h pathname.h pcpu.h policy.h proc.h random.h rwlock.h sdt.h sid.h stat.h string.h sunddi.h sysmacros.h systm.h time.h types.h uio.h varargs.h vfs.h vnode.h zone.h Added Files: src/external/cddl/osnet/dev: prototype.c src/external/cddl/osnet/dev/cyclic: cyclic.c cyclic_test.c src/external/cddl/osnet/dev/cyclic/amd64: cyclic_machdep.c src/external/cddl/osnet/dev/cyclic/i386: cyclic_machdep.c src/external/cddl/osnet/dev/dtmalloc: dtmalloc.c src/external/cddl/osnet/dev/dtrace: dtrace_anon.c dtrace_cddl.h dtrace_clone.c dtrace_debug.c dtrace_hacks.c dtrace_ioctl.c dtrace_load.c dtrace_modevent.c dtrace_sysctl.c dtrace_test.c dtrace_unload.c dtrace_vtime.c src/external/cddl/osnet/dev/dtrace/amd64: dis_tables.c dis_tables.h dtrace_asm.S dtrace_isa.c dtrace_subr.c instr_size.c src/external/cddl/osnet/dev/dtrace/i386: dis_tables.c dis_tables.h dtrace_asm.S dtrace_isa.c dtrace_subr.c instr_size.c src/external/cddl/osnet/dev/fbt: fbt.c src/external/cddl/osnet/dev/lockstat: lockstat.c src/external/cddl/osnet/dev/profile: profile.c src/external/cddl/osnet/dev/sdt: sdt.c src/external/cddl/osnet/dev/systrace: systrace.c src/external/cddl/osnet/dist/uts/common/sys: processor.h src/external/cddl/osnet/include: assert.h dtrace.h libproc.h libshare.h src/external/cddl/osnet/lib/drti: Makefile src/external/cddl/osnet/lib/libctf: Makefile src/external/cddl/osnet/lib/libdtrace: Makefile errno.d net.d nfs.d psinfo.d sched.d signal.d unistd.d src/external/cddl/osnet/sys/sys: acl.h cpuvar_defs.h cyclic_impl.h feature_tests.h file.h mntent.h refstr.h sema.h sig.h src/external/cddl/osnet/usr.bin/ctfconvert: Makefile src/external/cddl/osnet/usr.bin/ctfdump: Makefile src/external/cddl/osnet/usr.bin/ctfmerge: Makefile src/external/cddl/osnet/usr.sbin/dtrace: Makefile Log Message: Add the FreeBSD 8-RC1 changes for DTrace. Ok with c...@. To generate a diff of this commit: cvs rdiff -u -r0 -r1.1 src/external/cddl/osnet/dev/prototype.c cvs rdiff -u -r0 -r1.1 src/external/cddl/osnet/dev/cyclic/cyclic.c \ src/external/cddl/osnet/dev/cyclic/cyclic_test.c cvs rdiff -u -r0 -r1.1 \ src/external/cddl/osnet/dev/cyclic/amd64/cyclic_machdep.c cvs rdiff -u -r0 -r1.1 \ src/external/cddl/osnet/dev/cyclic/i386/cyclic_machdep.c cvs rdiff -u -r0 -r1.1 src/external/cddl/osnet/dev/dtmalloc/dtmalloc.c cvs rdiff -u -r0 -r1.1 src/external/cddl/osnet/dev/dtrace/dtrace_anon.c \
CVS commit: src/external/cddl/osnet
Module Name:src Committed By: darran Date: Sun Feb 21 01:46:36 UTC 2010 Modified Files: src/external/cddl/osnet/dev: prototype.c src/external/cddl/osnet/dev/cyclic: cyclic.c cyclic_test.c src/external/cddl/osnet/dev/cyclic/amd64: cyclic_machdep.c src/external/cddl/osnet/dev/cyclic/i386: cyclic_machdep.c src/external/cddl/osnet/dev/dtmalloc: dtmalloc.c src/external/cddl/osnet/dev/dtrace: dtrace_anon.c dtrace_cddl.h dtrace_clone.c dtrace_debug.c dtrace_hacks.c dtrace_ioctl.c dtrace_load.c dtrace_modevent.c dtrace_sysctl.c dtrace_test.c dtrace_unload.c dtrace_vtime.c src/external/cddl/osnet/dev/dtrace/amd64: dis_tables.c dis_tables.h dtrace_asm.S dtrace_isa.c dtrace_subr.c instr_size.c src/external/cddl/osnet/dev/dtrace/i386: dis_tables.c dis_tables.h dtrace_asm.S dtrace_isa.c dtrace_subr.c instr_size.c src/external/cddl/osnet/dev/fbt: fbt.c src/external/cddl/osnet/dev/lockstat: lockstat.c src/external/cddl/osnet/dev/profile: profile.c src/external/cddl/osnet/dev/sdt: sdt.c src/external/cddl/osnet/dev/systrace: systrace.c src/external/cddl/osnet/dist/common/ctf: ctf_create.c ctf_open.c src/external/cddl/osnet/dist/lib/libctf/common: ctf_lib.c src/external/cddl/osnet/dist/lib/libdtrace/common: dt_aggregate.c dt_consume.c dt_module.c dt_open.c dt_options.c dt_pid.c dt_proc.c dt_subr.c dtrace.h src/external/cddl/osnet/dist/tools/ctf/cvt: alist.c ctfmerge.c ctfmerge.h dwarf.c output.c src/external/cddl/osnet/dist/uts/common/dtrace: dtrace.c src/external/cddl/osnet/dist/uts/common/sys: dtrace.h dtrace_impl.h processor.h src/external/cddl/osnet/include: alloca.h assert.h devid.h dtrace.h fcntl.h fsshare.h libintl.h libproc.h libshare.h mnttab.h priv.h solaris.h stdio.h stdlib.h strings.h unistd.h zone.h src/external/cddl/osnet/lib: Makefile Makefile.inc src/external/cddl/osnet/lib/libavl: Makefile src/external/cddl/osnet/lib/libctf: Makefile src/external/cddl/osnet/lib/libdtrace: Makefile errno.d net.d nfs.d psinfo.d sched.d signal.d unistd.d src/external/cddl/osnet/lib/libnvpair: Makefile src/external/cddl/osnet/lib/libumem: Makefile src/external/cddl/osnet/lib/libuutil: Makefile src/external/cddl/osnet/lib/libzfs: Makefile src/external/cddl/osnet/lib/libzpool: Makefile src/external/cddl/osnet/sys/machine: endian.h src/external/cddl/osnet/sys/sys: acl.h atomic.h bitmap.h byteorder.h cmn_err.h cpupart.h cpuvar.h cpuvar_defs.h cred.h cyclic.h cyclic_impl.h debug.h dirent.h dkio.h dnlc.h elf.h feature_tests.h file.h idmap.h kcondvar.h kidmap.h kmem.h kobj.h kstat.h lock.h misc.h mman.h mntent.h mnttab.h modctl.h mount.h mutex.h objfs.h param.h pathname.h pcpu.h policy.h proc.h random.h refstr.h rwlock.h sdt.h sema.h sid.h sig.h stat.h string.h sunddi.h sysmacros.h systm.h time.h types.h uio.h varargs.h vfs.h vnode.h zone.h src/external/cddl/osnet/sys/sys/acl: acl_common.h src/external/cddl/osnet/usr.bin: Makefile src/external/cddl/osnet/usr.bin/ctfconvert: Makefile src/external/cddl/osnet/usr.bin/ctfdump: Makefile src/external/cddl/osnet/usr.bin/ctfmerge: Makefile src/external/cddl/osnet/usr.sbin: Makefile src/external/cddl/osnet/usr.sbin/dtrace: Makefile Added Files: src/external/cddl/osnet: Makefile.inc src/external/cddl/osnet/lib/libctf: shlib_version src/external/cddl/osnet/lib/libdtrace: shlib_version src/external/cddl/osnet/sys: elf.h src/external/cddl/osnet/sys/sys: mutex_impl.h rwlock_impl.h Removed Files: src/external/cddl/osnet/sys/sys: processor.h Log Message: Apply NetBSD changes to DTrace. Ok with c...@. To generate a diff of this commit: cvs rdiff -u -r0 -r1.1 src/external/cddl/osnet/Makefile.inc cvs rdiff -u -r1.1 -r1.2 src/external/cddl/osnet/dev/prototype.c cvs rdiff -u -r1.1 -r1.2 src/external/cddl/osnet/dev/cyclic/cyclic.c \ src/external/cddl/osnet/dev/cyclic/cyclic_test.c cvs rdiff -u -r1.1 -r1.2 \ src/external/cddl/osnet/dev/cyclic/amd64/cyclic_machdep.c cvs rdiff -u -r1.1 -r1.2 \ src/external/cddl/osnet/dev/cyclic/i386/cyclic_machdep.c cvs rdiff -u -r1.1 -r1.2 src/external/cddl/osnet/dev/dtmalloc/dtmalloc.c cvs rdiff -u -r1.1 -r1.2 src/external/cddl/osnet/dev/dtrace/dtrace_anon.c \ src/external/cddl/osnet/dev/dtrace/dtrace_cddl.h \ src/external/cddl/osnet/dev/dtrace/dtrace_clone.c \ src/external/cddl/osnet/dev/dtrace/dtrace_debug.c \ src/external/cddl/osnet/dev/dtrace/dtrace_hacks.c \ src/external/cddl/osnet/dev/dtrace/dtrace_ioctl.c \
CVS commit: src/share/mk
Module Name:src Committed By: darran Date: Sun Feb 21 01:48:03 UTC 2010 Modified Files: src/share/mk: bsd.own.mk Log Message: Add a MKDTRACE build knob for DTrace, off by default. To generate a diff of this commit: cvs rdiff -u -r1.617 -r1.618 src/share/mk/bsd.own.mk Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/distrib/sets
Module Name:src Committed By: darran Date: Sun Feb 21 03:18:47 UTC 2010 Modified Files: src/distrib/sets: sets.subr src/distrib/sets/lists/base: mi shl.elf shl.mi src/distrib/sets/lists/comp: mi shl.mi src/distrib/sets/lists/man: mi src/distrib/sets/lists/modules: mi Log Message: Add DTrace to sets. To generate a diff of this commit: cvs rdiff -u -r1.120 -r1.121 src/distrib/sets/sets.subr cvs rdiff -u -r1.858 -r1.859 src/distrib/sets/lists/base/mi cvs rdiff -u -r1.202 -r1.203 src/distrib/sets/lists/base/shl.elf cvs rdiff -u -r1.522 -r1.523 src/distrib/sets/lists/base/shl.mi cvs rdiff -u -r1.1393 -r1.1394 src/distrib/sets/lists/comp/mi cvs rdiff -u -r1.105 -r1.106 src/distrib/sets/lists/comp/shl.mi cvs rdiff -u -r1.1191 -r1.1192 src/distrib/sets/lists/man/mi cvs rdiff -u -r1.6 -r1.7 src/distrib/sets/lists/modules/mi Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/conf
Module Name:src Committed By: darran Date: Sun Feb 21 04:00:47 UTC 2010 Modified Files: src/sys/conf: files Log Message: Add the DTrace kernel hooks file to the kernel build. To generate a diff of this commit: cvs rdiff -u -r1.974 -r1.975 src/sys/conf/files Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src
Module Name:src Committed By: cnst Date: Sun Feb 21 05:16:29 UTC 2010 Modified Files: src/distrib/sets/lists/man: mi src/share/man/man4: Makefile isa.4 lm.4 src/sys/arch/amd64/conf: GENERIC XEN3_DOM0 src/sys/arch/i386/conf: ALL GENERIC XEN3_DOM0 src/sys/dev/isa: files.isa lm_isa.c Added Files: src/share/man/man4: wbsio.4 src/sys/dev/isa: wbsio.c Log Message: New wbsio(4) driver for Winbond Super I/O attachment of lm(4) on any port. http://mail-index.netbsd.org/tech-kern/2010/02/17/msg007338.html Reviewed by pgoyette, tech-kern. To generate a diff of this commit: cvs rdiff -u -r1.1192 -r1.1193 src/distrib/sets/lists/man/mi cvs rdiff -u -r1.504 -r1.505 src/share/man/man4/Makefile cvs rdiff -u -r1.40 -r1.41 src/share/man/man4/isa.4 cvs rdiff -u -r1.31 -r1.32 src/share/man/man4/lm.4 cvs rdiff -u -r0 -r1.1 src/share/man/man4/wbsio.4 cvs rdiff -u -r1.266 -r1.267 src/sys/arch/amd64/conf/GENERIC cvs rdiff -u -r1.49 -r1.50 src/sys/arch/amd64/conf/XEN3_DOM0 cvs rdiff -u -r1.238 -r1.239 src/sys/arch/i386/conf/ALL cvs rdiff -u -r1.968 -r1.969 src/sys/arch/i386/conf/GENERIC cvs rdiff -u -r1.28 -r1.29 src/sys/arch/i386/conf/XEN3_DOM0 cvs rdiff -u -r1.158 -r1.159 src/sys/dev/isa/files.isa cvs rdiff -u -r1.22 -r1.23 src/sys/dev/isa/lm_isa.c cvs rdiff -u -r0 -r1.1 src/sys/dev/isa/wbsio.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src/sys
On Sun, Feb 21, 2010 at 02:11:40AM +, Darran Hunt wrote: Module Name: src Committed By: darran Date: Sun Feb 21 02:11:40 UTC 2010 Modified Files: src/sys/arch/i386/i386: trap.c vector.S src/sys/kern: kern_lwp.c kern_proc.c kern_synch.c src/sys/sys: lwp.h proc.h Added Files: src/sys/sys: dtrace_bsd.h Log Message: Add the DTrace hooks to the kernel (KDTRACE_HOOKS config option). Please defflag that option in conf/files and use the resulting include file as necessary. -- Quentin Garnier - c...@cubidou.net - c...@netbsd.org See the look on my face from staying too long in one place [...] every time the morning breaks I know I'm closer to falling KT Tunstall, Saving My Face, Drastic Fantastic, 2007. pgpJfg7miHoR2.pgp Description: PGP signature
Re: CVS commit: src/sys
Quentin Garnier c...@cubidou.net wrote: On Sun, Feb 21, 2010 at 02:11:40AM +, Darran Hunt wrote: Module Name:src Committed By: darran Date: Sun Feb 21 02:11:40 UTC 2010 Modified Files: src/sys/arch/i386/i386: trap.c vector.S src/sys/kern: kern_lwp.c kern_proc.c kern_synch.c src/sys/sys: lwp.h proc.h Added Files: src/sys/sys: dtrace_bsd.h Log Message: Add the DTrace hooks to the kernel (KDTRACE_HOOKS config option). Please defflag that option in conf/files and use the resulting include file as necessary. I think these #ifdefs for KDTRACE_HOOKS should be removed and empty stubs provided for no-DTrace case. Code will get cleaner and perhaps more modular. -- Mindaugas
CVS commit: src/sys
Module Name:src Committed By: darran Date: Sun Feb 21 07:01:58 UTC 2010 Modified Files: src/sys/conf: files src/sys/kern: kern_lwp.c kern_proc.c kern_synch.c Log Message: Added a defflag option for KDTRACE_HOOKS and included opt_dtrace.h in the relevant files. (Per Quentin Garnier - thanks!). To generate a diff of this commit: cvs rdiff -u -r1.975 -r1.976 src/sys/conf/files cvs rdiff -u -r1.138 -r1.139 src/sys/kern/kern_lwp.c cvs rdiff -u -r1.160 -r1.161 src/sys/kern/kern_proc.c cvs rdiff -u -r1.276 -r1.277 src/sys/kern/kern_synch.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src/sys
The new code is modular - it has its own kern_dtrace.c module. I'm not sure that replacing the #ifdefs with stub functions is the best idea - won't that make the proc and lwp functions a bit less efficient with calls to the empty functions? On 21/02/2010, at 6:31 PM, Mindaugas Rasiukevicius wrote: Quentin Garnier c...@cubidou.net wrote: On Sun, Feb 21, 2010 at 02:11:40AM +, Darran Hunt wrote: Module Name:src Committed By: darran Date: Sun Feb 21 02:11:40 UTC 2010 Modified Files: src/sys/arch/i386/i386: trap.c vector.S src/sys/kern: kern_lwp.c kern_proc.c kern_synch.c src/sys/sys: lwp.h proc.h Added Files: src/sys/sys: dtrace_bsd.h Log Message: Add the DTrace hooks to the kernel (KDTRACE_HOOKS config option). Please defflag that option in conf/files and use the resulting include file as necessary. I think these #ifdefs for KDTRACE_HOOKS should be removed and empty stubs provided for no-DTrace case. Code will get cleaner and perhaps more modular. -- Mindaugas
Re: CVS commit: src/sys
Darran Hunt dar...@netbsd.org wrote:
The new code is modular - it has its own kern_dtrace.c module. I'm
not sure that replacing the #ifdefs with stub functions is the best
idea - won't that make the proc and lwp functions a bit less efficient
with calls to the empty functions?
Compiler will optimise them out. We already do that in various places,
including threading and scheduling code. Also:
+ if (dtrace_vtime_active) {
+ (*dtrace_vtime_switch_func)(newl);
+ }
It is worth to give a separate cache line for dtrace_vtime_active and
use __predict_false().
P.S. It seems you forgot to commit kern_dtrace.c module. :)
--
Mindaugas
CVS commit: src/sys/kern
Module Name:src Committed By: darran Date: Sun Feb 21 07:28:51 UTC 2010 Added Files: src/sys/kern: kern_dtrace.c Log Message: DTrace: missed kern_dtrace.c (thanks rmind!) To generate a diff of this commit: cvs rdiff -u -r0 -r1.1 src/sys/kern/kern_dtrace.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src/sys
On Sun, Feb 21, 2010 at 07:18:20AM +, Mindaugas Rasiukevicius wrote:
Darran Hunt dar...@netbsd.org wrote:
The new code is modular - it has its own kern_dtrace.c module. I'm
not sure that replacing the #ifdefs with stub functions is the best
idea - won't that make the proc and lwp functions a bit less efficient
with calls to the empty functions?
Compiler will optimise them out. We already do that in various places,
including threading and scheduling code.
It will if they are #defined out (rather than being functions that just
return). However a moderm x86 cpu should prefetch through such a function
(all the jumps are fully predicted).
Also:
+ if (dtrace_vtime_active) {
+ (*dtrace_vtime_switch_func)(newl);
+ }
It is worth to give a separate cache line for dtrace_vtime_active and
use __predict_false().
__predict_false() yes, but separating things into their own cache lines
is probably a pessimalisation - mainly because it increases the working
set (of cache lines) of the code.
David
--
David Laight: da...@l8s.co.uk
