Re: CVS commit: src/sys
Yeah, in retrospect that would probably have been a simpler course to
follow.
I'd be happy to re-work this if you want, but it will probably take a
couple days - the day job needs some attention right now.
On Tue, 25 May 2010, David Young wrote:
On Mon, May 24, 2010 at 08:29:49PM +, Paul Goyette wrote:
Module Name:src
Committed By: pgoyette
Date: Mon May 24 20:29:49 UTC 2010
Modified Files:
src/sys/arch/i386/pci: gcscehci.c
src/sys/dev/cardbus: ehci_cardbus.c ohci_cardbus.c uhci_cardbus.c
src/sys/dev/pci: azalia.c cs4280.c ehci_pci.c ohci_pci.c uhci_pci.c
Log Message:
Update all callers of the pci_find{vendor,product} routines to now call
these routines through their global pointers.
It was not necessary to change all of the pci_find{vendor,product}
calls, was it? You could have tucked the call through
pci_find{vendor,product}_vec into pci_find{vendor,product}() like this:
const char *
pci_findvendor(pcireg_t id)
{
return (*pci_findvendor_vec)(id);
}
Dave
--
David Young OJC Technologies
dyo...@ojctech.com Urbana, IL * (217) 278-3933
-
| Paul Goyette | PGP Key fingerprint: | E-mail addresses: |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com|
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer | | pgoyette at netbsd.org |
-
re: CVS commit: src/sys
Yeah, in retrospect that would probably have been a simpler course to follow. I'd be happy to re-work this if you want, but it will probably take a couple days - the day job needs some attention right now. please do this when you have time. thanks! (this change also should have bumped the kernel version, right, since pci_findvendor() died. but if you fix it really soon then perhaps it isn't necessary...) .mrg.
re: CVS commit: src/sys
On Tue, 25 May 2010, matthew green wrote: Yeah, in retrospect that would probably have been a simpler course to follow. I'd be happy to re-work this if you want, but it will probably take a couple days - the day job needs some attention right now. please do this when you have time. thanks! Will try for next 24 hours. (this change also should have bumped the kernel version, right, since pci_findvendor() died. but if you fix it really soon then perhaps it isn't necessary...) Hmmm, yeah. - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/sys/dev/ieee1394
Hello Christos! From: chris...@zoulas.com (Christos Zoulas) Subject: Re: CVS commit: src/sys/dev/ieee1394 Date: Mon, 24 May 2010 10:36:49 -0400 | In many cases, there is a case that cannot be fixed in several days. For | instance, MIPS cannot be booted since merge mips64. This is not also not acceptable it has pissed off everyone owning a MIPS box who cannot boot current. If I had a MIPS box and could test this, I would have reverted the MIPS changes too. (Hi Matt!). You can test with gxemul. cd /usr/pkgsrc/emulators/gxemul make package gxemul -e mobilepro770 -X -M 512 hpcmipskernel/netbsd20091130 ... boot OK gxemul -e mobilepro770 -X -M 512 hpcmipskernel/netbsd20091231 ... boot FAIL see more information; http://www.netbsd.org/cgi-bin/query-pr-single.pl?number=42934 -- jun ebihara
Re: CVS commit: src/sys/dev/ieee1394
On May 25, 4:33pm, j...@soum.co.jp (Jun Ebihara) wrote: -- Subject: Re: CVS commit: src/sys/dev/ieee1394 | Hello Christos! | | From: chris...@zoulas.com (Christos Zoulas) | Subject: Re: CVS commit: src/sys/dev/ieee1394 | Date: Mon, 24 May 2010 10:36:49 -0400 | | | In many cases, there is a case that cannot be fixed in several days. For | | instance, MIPS cannot be booted since merge mips64. | This is not also not acceptable it has pissed off everyone owning a MIPS box | who cannot boot current. If I had a MIPS box and could test this, I would | have reverted the MIPS changes too. (Hi Matt!). | | You can test with gxemul. | | cd /usr/pkgsrc/emulators/gxemul | make package | gxemul -e mobilepro770 -X -M 512 hpcmipskernel/netbsd20091130 ... boot OK | gxemul -e mobilepro770 -X -M 512 hpcmipskernel/netbsd20091231 ... boot FAIL | | see more information; | http://www.netbsd.org/cgi-bin/query-pr-single.pl?number=42934 Good idea! christos
Re: CVS commit: src/sys/ufs/ufs
On Tue, 25 May 2010, Antti Kantee wrote: Modified Files: src/sys/ufs/ufs: ufs_wapbl.c Log Message: Add a comment describing an observed boom-crash-burn problem in the code. Fixing it will require a full tank of gas, half a pack of cigarettes, sunglasses, darkness, and most importantly: someone else. What would I have to do from userland to tickle this bug? --apb (Alan Barrett)
Re: CVS commit: src/sys/dev/ieee1394
chris...@zoulas.com (Christos Zoulas) wrote: | Yes. It knows I was broken, too. However, it worked on my ofppc and | it booted my amd64. Try booting with DIAGNOSTIC. If you make any changes to the kernel you should be really compiling with DIAGNOSTIC. It should be tested both with DEBUG and DIAGNOSTIC enabled. If involves locking, then also LOCKDEBUG. -- Mindaugas
Re: CVS commit: src/sys/ufs/ufs
On Tue May 25 2010 at 15:55:35 +0200, Alan Barrett wrote: On Tue, 25 May 2010, Antti Kantee wrote: Modified Files: src/sys/ufs/ufs: ufs_wapbl.c Log Message: Add a comment describing an observed boom-crash-burn problem in the code. Fixing it will require a full tank of gas, half a pack of cigarettes, sunglasses, darkness, and most importantly: someone else. What would I have to do from userland to tickle this bug? You need to unlink and create a file after the first namei in sys_rename but before VOP_RENAME runs, i.e. trigger a race condition. Running tests/fs/ffs/t_renamerace a few times should suffice. It uses rump, so your host is safe. If you have a uniprocessor host, set RUMP_NCPU to 2 to have both threads run in the rump kernel in parallel (well, they run virtually parallel on a uniprocessor system, but YKWIM). This makes the race more likely to trigger.
Re: CVS commit: src/sys/ufs/ufs
On Tue, May 25, 2010 at 11:02:07AM +, Antti Kantee wrote: Add a comment describing an observed boom-crash-burn problem in the code. Fixing it will require a full tank of gas, half a pack of cigarettes, sunglasses, darkness, and most importantly: someone else. Thanks for the merge conflict :-p -- David A. Holland dholl...@netbsd.org
