Re: CVS commit: src/usr.bin/pkill

2010-12-05 Thread enami tsugutomo
> cvs rdiff -u -r1.25 -r1.26 src/usr.bin/pkill/pkill.c

Looks like -l option is necessary for prenice also.

enami.


Re: CVS commit: src/sys/dev

2010-12-05 Thread Warner Losh

On 12/05/2010 02:35, Antti Kantee wrote:

On Sat Dec 04 2010 at 18:44:07 +, Christos Zoulas wrote:

In article<20101204173951.3ae6e17...@cvs.netbsd.org>,
Antti Kantee  wrote:

-=-=-=-=-=-

Module Name:src
Committed By:   pooka
Date:   Sat Dec  4 17:39:51 UTC 2010

Modified Files:
src/sys/dev: rnd.c

Log Message:
Don't allow "goes to 11^H^Hhyperspace" len field for RNDADDATA.


Should be EINVAL; E2BIG has a very specific meaning (unless we want to change
that).

EINVAL is used too much and I try to pick more descriptive remotely
fitting errnos when possible.

If someone feels strongly otherwise, please change it.

At least update intro(2) to document the new meaning.

Warner


Re: CVS commit: src/sys/dev

2010-12-05 Thread Christos Zoulas
In article <20101205093557.ga24...@cs.hut.fi>,
Antti Kantee   wrote:
>On Sat Dec 04 2010 at 18:44:07 +, Christos Zoulas wrote:
>> In article <20101204173951.3ae6e17...@cvs.netbsd.org>,
>> Antti Kantee  wrote:
>> >-=-=-=-=-=-
>> >
>> >Module Name:src
>> >Committed By:   pooka
>> >Date:   Sat Dec  4 17:39:51 UTC 2010
>> >
>> >Modified Files:
>> >src/sys/dev: rnd.c
>> >
>> >Log Message:
>> >Don't allow "goes to 11^H^Hhyperspace" len field for RNDADDATA.
>> >
>> 
>> Should be EINVAL; E2BIG has a very specific meaning (unless we want to change
>> that).
>
>EINVAL is used too much and I try to pick more descriptive remotely
>fitting errnos when possible.
>
>If someone feels strongly otherwise, please change it.

I agree with the overuse of EINVAL and I have tried in the past to avoid it.
What I am saying is that if we are going to re-purpose other errnos, we need
to change their descriptions to make them less specific.

christos



Re: CVS commit: src/sys/dev

2010-12-05 Thread Antti Kantee
On Sat Dec 04 2010 at 18:44:07 +, Christos Zoulas wrote:
> In article <20101204173951.3ae6e17...@cvs.netbsd.org>,
> Antti Kantee  wrote:
> >-=-=-=-=-=-
> >
> >Module Name: src
> >Committed By:pooka
> >Date:Sat Dec  4 17:39:51 UTC 2010
> >
> >Modified Files:
> > src/sys/dev: rnd.c
> >
> >Log Message:
> >Don't allow "goes to 11^H^Hhyperspace" len field for RNDADDATA.
> >
> 
> Should be EINVAL; E2BIG has a very specific meaning (unless we want to change
> that).

EINVAL is used too much and I try to pick more descriptive remotely
fitting errnos when possible.

If someone feels strongly otherwise, please change it.

-- 
älä karot toivorikkauttas, kyl rätei ja lumpui piisaa