Re: CVS commit: src/lib/libc/gen

2010-12-12 Thread David Holland
On Thu, Dec 09, 2010 at 09:27:32PM +, Joerg Sonnenberger wrote:
  Log Message:
  Wrap sys_errlist constants in a macro to make it easier to extract
  the strings reliably with sed/awk.

Why two layers of parentheses?

Also, if we're going to be extracting strings anyway, errlist.c and
whatever else ought to be built from errno.h.

-- 
David A. Holland
dholl...@netbsd.org


Re: CVS commit: src/lib/libc/gen

2010-12-12 Thread Joerg Sonnenberger
On Sun, Dec 12, 2010 at 08:34:25AM +, David Holland wrote:
 On Thu, Dec 09, 2010 at 09:27:32PM +, Joerg Sonnenberger wrote:
   Log Message:
   Wrap sys_errlist constants in a macro to make it easier to extract
   the strings reliably with sed/awk.
 
 Why two layers of parentheses?

In case someone decides to add () or so. It also seemed to provide a
somewhat more sane alignment in the end.

 Also, if we're going to be extracting strings anyway, errlist.c and
 whatever else ought to be built from errno.h.

If you find out how to deal with the pseudo-errors, I wouldn't mind that
either.

Joerg


Re: CVS commit: src/sys/dev/pci

2010-12-12 Thread David Young
On Sat, Dec 11, 2010 at 11:18:12PM -0800, Matt Thomas wrote:
 On Dec 11, 2010, at 11:02 AM, David Young wrote:
  Why does this need to be #ifdef'd ?
 
 It doesn't but it never ever match on anything other
 than a PowerPC so why have the code when it can never
 be executed?

IMO, it's not worth a few bytes' savings in instructions to clutter code
with conditional compilation.

Dave

-- 
David Young OJC Technologies
dyo...@ojctech.com  Urbana, IL * (217) 278-3933


Re: CVS commit: src/external/bsd/openldap/dist

2010-12-12 Thread Bernd Ernesti
On Sun, Dec 12, 2010 at 03:25:26PM +, Adam Ciarcinski wrote:
 Module Name:  src
 Committed By: adam
 Date: Sun Dec 12 15:25:26 UTC 2010
 
 Update of /cvsroot/src/external/bsd/openldap/dist
 In directory ivanova.netbsd.org:/tmp/cvs-serv1493
 
 Log Message:
 Imported openldap-2.4.23
 
 Status:
 
 Vendor Tag:   OPENLDAP
 Release Tags: OPENLDAP_2_4_23
   
 U src/external/bsd/openldap/dist/aclocal.m4
[..]

Please include a changelog in your commit message even if it is a small
one when you import an updated version.

Bernd



re: CVS commit: src/external/historical/nawk/bin

2010-12-12 Thread matthew green

 Module Name:  src
 Committed By: christos
 Date: Sun Dec 12 19:01:04 UTC 2010
 
 Modified Files:
   src/external/historical/nawk/bin: Makefile
 
 Log Message:
 Don't build awk.info because matt removed it.

oh, that was a mistake then.  it should have been moved into
the external gpl directory, i guess.

i'll fix it.


.mrg.


Re: CVS commit: src/sys/dev/pci

2010-12-12 Thread Matt Thomas

On Dec 12, 2010, at 10:56 AM, David Young wrote:

 On Sat, Dec 11, 2010 at 11:18:12PM -0800, Matt Thomas wrote:
 On Dec 11, 2010, at 11:02 AM, David Young wrote:
 Why does this need to be #ifdef'd ?
 
 It doesn't but it never ever match on anything other
 than a PowerPC so why have the code when it can never
 be executed?
 
 IMO, it's not worth a few bytes' savings in instructions to clutter code
 with conditional compilation.

And maybe that's why NetBSD kernels continue to bloat in size.

Removing code from a kernel that could never be executed is a great
use of condition compilation.