Re: CVS commit: src

2011-02-09 Thread Thomas Klausner 
I see that this commit removed blocks that should have stayed.

For example, in rbootd.8:

-.\from: @(#)rbootd.8  8.2 (Berkeley) 12/11/93
-.\
-.\ Utah Hdr: rbootd.man 3.1 92/07/06
-.\ Author: Jeff Forys, University of Utah CSS
-.\


Perhaps it only affects man pages, but please check and restore them.

Thanks,
 Thomas

Re: CVS commit: src/lib/librumphijack

2011-02-09 Thread Joerg Sonnenberger 
On Wed, Feb 09, 2011 at 02:30:38AM +, Christos Zoulas wrote:
 To get the layering correct, we could make the fortification code define
 another prototype and use double rename, e.g.
 
 ssize_t __real_read(int __fd, ...) __RENAME(read);
 
 __ssp_inline ssize_t read(int __fd, ...) __RENAME(__ssp_read);
 
 __sso_inline ssize_t read(int __fd, ...) {
  __ssp_check(__buf, __lean, bos);
  return __real_read(__fd, ...);
 }
 
 Yes, that would work. An extra level of indirection always works.

It isn't really. It is just tricking the compiler into creating the
right external symbols. The result is that using SSP doesn't change
which symbols end up being called.

Joerg

Re: CVS commit: src/lib/librumphijack

2011-02-09 Thread Antti Kantee 
On Wed Feb 09 2011 at 02:32:17 +, Christos Zoulas wrote:
 And, on a tangent, it would really help if we had some mechanism for
 latest version of symbol exported by libc (cf. mess with select,
 pollts, kevent and socket).  For working compat, I guess we'd need to
 bump rumphijack major every time one of them changes, but I can't think
 of a good mechanism for an application to automatically select the major
 that needs to be used.
 
 That would be useful.

Oh, and one other related thing on my wishlist is having libc export
all syscall stubs in WEAKASM _sys style so that use-fd-to-select-kernel
can work on static linked binaries which cannot use RTLD_NEXT.  I guess
another option would be to compile local syscall stubs, but it seems
easier to have them popping out of libc.

-- 
älä karot toivorikkauttas, kyl rätei ja lumpui piisaa

Re: CVS commit: src/lib/librumphijack

2011-02-09 Thread Valeriy E. Ushakov 
On Wed, Feb 09, 2011 at 14:06:08 +0200, Antti Kantee wrote:

 On Wed Feb 09 2011 at 02:32:17 +, Christos Zoulas wrote:
  And, on a tangent, it would really help if we had some mechanism for
  latest version of symbol exported by libc (cf. mess with select,
  pollts, kevent and socket).  For working compat, I guess we'd need to
  bump rumphijack major every time one of them changes, but I can't think
  of a good mechanism for an application to automatically select the major
  that needs to be used.
  
  That would be useful.
 
 Oh, and one other related thing on my wishlist is having libc export
 all syscall stubs in WEAKASM _sys style so that use-fd-to-select-kernel
 can work on static linked binaries which cannot use RTLD_NEXT.  I guess
 another option would be to compile local syscall stubs, but it seems
 easier to have them popping out of libc.

Is source-changes-d really the right place for this discussion?

-uwe

Re: CVS commit: src/lib/librumpclient

2011-02-09 Thread David Laight 
On Wed, Feb 09, 2011 at 02:29:58PM +, Antti Kantee wrote:
 
 Hence, prevent rumpclient from using the special fd's 0-2 for its
 purposes.

Probably worth dup'ing onto quite high numbers (if possible).
Well, above 20 anyway.

David

-- 
David Laight: da...@l8s.co.uk