Re: CVS commit: src/dist/ipf/tools

2011-02-24 Thread David Laight
On Thu, Feb 24, 2011 at 09:33:24AM -0500, Christos Zoulas wrote:
> Module Name:  src
> Committed By: christos
> Date: Thu Feb 24 14:33:23 UTC 2011
> 
> Modified Files:
>   src/dist/ipf/tools: ipmon.c
> 
> Log Message:
> define the format as a constant so that we don't break if sprintf is a macro.
> XXX: make it so that sprintf is not a macro.

The simplest 'fix' is to enclose the sprintf in parenthesis!

David

-- 
David Laight: da...@l8s.co.uk


Re: CVS commit: src

2011-02-24 Thread Joerg Sonnenberger
On Thu, Feb 24, 2011 at 05:23:12PM +0200, Antti Kantee wrote:
> On Thu Feb 24 2011 at 04:28:50 +, Joerg Sonnenberger wrote:
> > Log Message:
> > Allow storing and receiving the LWP private pointer via ucontext_t
> > on all platforms except VAX and IA64. Add fast access via register for
> > AMD64, i386 and SH3 ports. Use this fast access in libpthread to replace
> > the stack based pthread_self(). Implement skeleton support for Alpha,
> > HPPA, PowerPC, SPARC and SPARC64, but leave it disabled.
> > 
> > Ports that support this feature provide __HAVELWP_GETPRIVATE_FAST in
> > machine/types.h and a corresponding __lwp_getprivate_fast in
> > machine/mcontext.h.
> 
> Did you run benchmarks?  The initial data is quite alarming:

I did not.

> Starting from a window including this commit gson's test run timeouts
> due to taking too long.
> 
> Pgoyette's amd64 test run with sources from 2011-02-24 04:20:03 UTC took
> 1:20h to complete and sources from 2011-02-24 09:20:03 UTC took 1:47h
> to complete.
> 
> Also, a few test failures seemed to pop up.

I don't know about qemu performance, but the native case should be
pretty much unchanged. Feel free to perform benchmarks if you want.
There are also changes to EST in that time window...

Joerg


Re: CVS commit: src

2011-02-24 Thread Antti Kantee
On Thu Feb 24 2011 at 04:28:50 +, Joerg Sonnenberger wrote:
> Log Message:
> Allow storing and receiving the LWP private pointer via ucontext_t
> on all platforms except VAX and IA64. Add fast access via register for
> AMD64, i386 and SH3 ports. Use this fast access in libpthread to replace
> the stack based pthread_self(). Implement skeleton support for Alpha,
> HPPA, PowerPC, SPARC and SPARC64, but leave it disabled.
> 
> Ports that support this feature provide __HAVELWP_GETPRIVATE_FAST in
> machine/types.h and a corresponding __lwp_getprivate_fast in
> machine/mcontext.h.

Did you run benchmarks?  The initial data is quite alarming:

Starting from a window including this commit gson's test run timeouts
due to taking too long.

Pgoyette's amd64 test run with sources from 2011-02-24 04:20:03 UTC took
1:20h to complete and sources from 2011-02-24 09:20:03 UTC took 1:47h
to complete.

Also, a few test failures seemed to pop up.

-- 
älä karot toivorikkauttas, kyl rätei ja lumpui piisaa


Re: CVS commit: src/sys/arch

2011-02-24 Thread Jukka Ruohonen
On Thu, Feb 24, 2011 at 10:56:04AM +, Jukka Ruohonen wrote:
> Log Message:
> Move PowerNow! to the cpufeaturebus.

I tried to be very careful, but please test for any fall over.

- Jukka.