Re: CVS commit: src/usr.bin/quota

2011-03-06 Thread Christos Zoulas 
In article <20110306205803.ga15...@antioche.eu.org>,
Manuel Bouyer   wrote:
>On Sun, Mar 06, 2011 at 03:48:00PM -0500, Christos Zoulas wrote:
>> Module Name: src
>> Committed By:christos
>> Date:Sun Mar  6 20:47:59 UTC 2011
>> 
>> Modified Files:
>>  src/usr.bin/quota: Makefile getvfsquota.c getvfsquota.h printquota.c
>>  printquota.h quota.c
>> 
>> Log Message:
>> - WARNS=4
>> - KNF
>> - don't cast malloc
>> - don't use static buffers
>> - fix types
>> - remove extra \n's from errors
>> - fix prototypes
>
>this breaks the build. These utitilies are used bu other quota tools.
>Why did you #if 0 timepprt() ? it's used by edquota

I'll add them back.

christos

Re: CVS commit: src/usr.bin/quota

2011-03-06 Thread Manuel Bouyer 
On Sun, Mar 06, 2011 at 03:48:00PM -0500, Christos Zoulas wrote:
> Module Name:  src
> Committed By: christos
> Date: Sun Mar  6 20:47:59 UTC 2011
> 
> Modified Files:
>   src/usr.bin/quota: Makefile getvfsquota.c getvfsquota.h printquota.c
>   printquota.h quota.c
> 
> Log Message:
> - WARNS=4
> - KNF
> - don't cast malloc
> - don't use static buffers
> - fix types
> - remove extra \n's from errors
> - fix prototypes

this breaks the build. These utitilies are used bu other quota tools.
Why did you #if 0 timepprt() ? it's used by edquota

-- 
Manuel Bouyer 
 NetBSD: 26 ans d'experience feront toujours la difference
--

Re: CVS commit: src/sys/dev/marvell

2011-03-06 Thread Jonathan A. Kollasch 
On Sun, Mar 06, 2011 at 12:00:16PM -0500, Christos Zoulas wrote:
> Module Name:  src
> Committed By: christos
> Date: Sun Mar  6 17:00:16 UTC 2011
> 
> Modified Files:
>   src/sys/dev/marvell: if_mvgbe.c
> 
> Log Message:
> don't abuse cf_unit, requested by phone.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.6 -r1.7 src/sys/dev/marvell/if_mvgbe.c

This doesn't compile.

Also, it prevents detection of my:
mvgbec0 at mvsoc0 unit 0 offset 0x7-0x73fff: Marvell Gigabit Ethernet 
Controller
mvgbe0 at mvgbec0 port 0 irq 21
mvgbe0: Ethernet address 00:0a:e4:88:fa:88
makphy0 at mvgbe0 phy 8: Marvell 88E1116 Gigabit PHY, rev. 1
makphy0: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, 1000baseT, 
1000baseT-FDX, auto

Note it's address is 8, not 0 or 1.