Re: CVS commit: src

2011-04-11 Thread David Laight 
On Mon, Apr 11, 2011 at 08:03:46PM +, Martin Husemann wrote:
> Module Name:  src
> Committed By: martin
> Date: Mon Apr 11 20:03:45 UTC 2011
> 
> Modified Files:
>   src/distrib/sets/lists/etc: mi
>   src/etc: Makefile
>   src/etc/mtree: NetBSD.dist.base special
> 
> Log Message:
> When run as root, tcpdump will chroot to /var/run/tcpdump - but it can
> not look up /etc/protcols in there. So install a copy of /etc/protocols
> into the chroot area.
> Fixes PR bin/44721.

Wouldn't it be less confusing to have opened /etc/protocols before
doing the chroot ??
This might mean persuading the library code to open /dev/fd/n

David

-- 
David Laight: da...@l8s.co.uk

Re: CVS commit: src/tests/lib/libcurses/slave

2011-04-11 Thread Alan Barrett 

On Tue, 12 Apr 2011, matthew green wrote:

>+static int
>+internal_vw_printw(WINDOW *win, char *arg1, ...)

This code looks identical to that in wprintw().  Why does it 
need to be duplicated under another name?


well, the test is about testing vw_printw() directly, not 
wprintw().


Ah, of course.

--apb (Alan Barrett)

re: CVS commit: src/tests/lib/libcurses/slave

2011-04-11 Thread matthew green 

> On Mon, 11 Apr 2011, Brett Lymn wrote:
> >Modified Files:
> > src/tests/lib/libcurses/slave: curses_commands.c
> > 
> >+static int
> >+internal_vw_printw(WINDOW *win, char *arg1, ...)
> >+{
> >+va_list va;
> >+int rv;
> >+
> >+va_start(va, arg1);
> >+rv = vw_printw(win, arg1, va);
> >+va_end(va);
> >+
> >+return rv;
> >+}
> 
> This code looks identical to that in wprintw().  Why does it need to
> be duplicated under another name?

well, the test is about testing vw_printw() directly, not
wprintw().


.mrg.

Re: CVS commit: src/sys

2011-04-11 Thread Mindaugas Rasiukevicius 
"Mindaugas Rasiukevicius"  wrote:
> Log Message:
> Highly rewrite POSIX semaphore.  Use file descriptor subsystem, greatly
> simplify reference counting, and fix various bugs which existed before,
> e.g. some incorrect locking or mq_unlink() not checking for permissions.
 ^^^

Highly wrong!  Should be sem_unlink(); I did check mq_unlink() for bugs.

> 
> Also, fixes PR/43452.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.29 -r1.30 src/sys/kern/uipc_sem.c
> cvs rdiff -u -r1.71 -r1.72 src/sys/sys/file.h
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
> 

-- 
Mindaugas

Re: CVS commit: src/tests/lib/libcurses/slave

2011-04-11 Thread Alan Barrett 

On Mon, 11 Apr 2011, Brett Lymn wrote:

Modified Files:
src/tests/lib/libcurses/slave: curses_commands.c

+static int
+internal_vw_printw(WINDOW *win, char *arg1, ...)
+{
+   va_list va;
+   int rv;
+
+   va_start(va, arg1);
+   rv = vw_printw(win, arg1, va);
+   va_end(va);
+
+   return rv;
+}


This code looks identical to that in wprintw().  Why does it need to
be duplicated under another name?

--apb (Alan Barrett)