Re: CVS commit: src/sys/kern

2011-08-17 Thread David Holland
On Wed, Aug 17, 2011 at 08:31:27AM +, Martin Husemann wrote:
  Modified Files:
   src/sys/kern: vfs_syscalls.c
  
  Log Message:
  add missing prototype

shouldn't that be in a header file somewhere?

-- 
David A. Holland
dholl...@netbsd.org


Re: CVS commit: src/sys/kern

2011-08-17 Thread Martin Husemann
On Wed, Aug 17, 2011 at 09:17:18AM +, David Holland wrote:
 On Wed, Aug 17, 2011 at 08:31:27AM +, Martin Husemann wrote:
   Modified Files:
  src/sys/kern: vfs_syscalls.c
   
   Log Message:
   add missing prototype
 
 shouldn't that be in a header file somewhere?

Dunno - I just needed a quick build fix. Manu?

Martin


Re: CVS commit: src/sys/kern

2011-08-17 Thread Emmanuel Dreyfus
On Wed, Aug 17, 2011 at 11:19:02AM +0200, Martin Husemann wrote:
  shouldn't that be in a header file somewhere?
 Dunno - I just needed a quick build fix. Manu?

Yes, there was a missing header, I just fixed it (and rolled back
the prototype in vfs_syscalls.c).

-- 
Emmanuel Dreyfus
m...@netbsd.org


Re: CVS commit: src

2011-08-17 Thread Iain Hibbert
On Thu, 21 Jul 2011, matthew green wrote:

 Module Name:  src
 Committed By: mrg
 Date: Thu Jul 21 03:13:32 UTC 2011

 Modified Files:
   src/compat/amd64/i386: bsd.i386.mk
   src/compat/mips64/64: bsd.64.mk
   src/compat/mips64/o32: bsd.o32.mk
   src/compat/sparc64/sparc: bsd.sparc.mk
   src/distrib/sets/lists/base: ad.mips64eb ad.mips64el md.amd64
   md.sparc64
   src/distrib/sets/lists/comp: ad.mips64eb ad.mips64el md.amd64
   md.sparc64 mi shl.mi
   src/external/gpl3/gcc/usr.bin: Makefile.backend Makefile.inc
   src/external/gpl3/gcc/usr.bin/cc1: Makefile
   src/external/gpl3/gcc/usr.bin/cc1obj: Makefile
   src/external/gpl3/gcc/usr.bin/cc1plus: Makefile
   src/external/lgpl2/mpc/lib/libmpc: Makefile
   src/external/lgpl3/gmp/lib/libgmp: Makefile
   src/external/lgpl3/mpfr/lib/libmpfr: Makefile
   src/lib: Makefile

 Log Message:
 build GMP, MPFR and MPC as private libraries just for GCC.  don't
 install the headers or librarys into the system.

in lib/Makefile should this really be

 .if (${MKGCC} != no)  ${HAVE_GCC} = 45

rather than

 .if defined(HAVE_GCC)  ${HAVE_GCC} = 45

?

I think that HAVE_GCC is always defined, these days..

iain


re: CVS commit: src

2011-08-17 Thread matthew green

  Log Message:
  build GMP, MPFR and MPC as private libraries just for GCC.  don't
  install the headers or librarys into the system.
 
 in lib/Makefile should this really be
 
  .if (${MKGCC} != no)  ${HAVE_GCC} = 45
 
 rather than
 
  .if defined(HAVE_GCC)  ${HAVE_GCC} = 45
 
 ?
 
 I think that HAVE_GCC is always defined, these days..

it should have both.  we shouldn't rely on HAVE_GCC always
being defined.  i thought it wasn't defined for pcc builds?


.mrg.


Re: CVS commit: src/external/bsd/mdocml

2011-08-17 Thread Joerg Sonnenberger
Could you please stop randomly changing 3rd party code without
contacting the maintainer?

Joerg

On Wed, Aug 17, 2011 at 05:30:14AM -0400, Christos Zoulas wrote:
 Module Name:  src
 Committed By: christos
 Date: Wed Aug 17 09:30:14 UTC 2011
 
 Modified Files:
   src/external/bsd/mdocml/dist: mdoc_validate.c
   src/external/bsd/mdocml/lib/libmandoc: Makefile
 
 Log Message:
 fix cast warnings
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.1.1.13 -r1.2 src/external/bsd/mdocml/dist/mdoc_validate.c
 cvs rdiff -u -r1.2 -r1.3 src/external/bsd/mdocml/lib/libmandoc/Makefile
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.
 


Re: CVS commit: src/usr.bin/unzip

2011-08-17 Thread Joerg Sonnenberger
Did you test this change for breaking compatibility with 3rd party
scripts that parse the output of unzip?

Joerg

On Wed, Aug 17, 2011 at 09:37:40AM -0400, Christos Zoulas wrote:
 Module Name:  src
 Committed By: christos
 Date: Wed Aug 17 13:37:40 UTC 2011
 
 Modified Files:
   src/usr.bin/unzip: unzip.c
 
 Log Message:
 kill 2 digit year format.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.15 -r1.16 src/usr.bin/unzip/unzip.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.
 


Re: CVS commit: src/external/bsd/mdocml

2011-08-17 Thread Christos Zoulas
In article 20110817212805.gb16...@britannica.bec.de,
Joerg Sonnenberger  jo...@britannica.bec.de wrote:
Could you please stop randomly changing 3rd party code without
contacting the maintainer?

Unless the rules have changed, for simple compilation fixes we don't do that.
Otherwise the overhead of doing so would be too large. In this particular
case, do you have a different/better way of fixing this? If yes, I'd like
to know now.

christos



Re: CVS commit: src/usr.bin/unzip

2011-08-17 Thread Christos Zoulas
In article 20110817212950.gc16...@britannica.bec.de,
Joerg Sonnenberger  jo...@britannica.bec.de wrote:
Did you test this change for breaking compatibility with 3rd party
scripts that parse the output of unzip?


I thought about that, but where does one find such scripts? Providing
a flag to make backwards compatible output is another way of doing it,
but is it worth it?

christos



Re: CVS commit: src/usr.bin/unzip

2011-08-17 Thread Bernd Ernesti
On Thu, Aug 18, 2011 at 01:49:30AM +, Christos Zoulas wrote:
 In article 20110817212950.gc16...@britannica.bec.de,
 Joerg Sonnenberger  jo...@britannica.bec.de wrote:
 Did you test this change for breaking compatibility with 3rd party
 scripts that parse the output of unzip?
 
 
 I thought about that, but where does one find such scripts? Providing
 a flag to make backwards compatible output is another way of doing it,
 but is it worth it?

No, just back the change out because the output should look the same as
the 'normal' unzip does.
The change is nice but should not be done as long as the official unzip
still use the old output.

Bernd