Re: CVS commit: src
In the absence of both the prototype and a cast, NULL (which can be 0) will be passed as an int, not as a pointer. These need not be the same size, leading to a situation where the termination of the list will not be guaranteed if there's stack garbage that is non-zero in the other half of the pointer. The whole issue of defining NULL to be 0 or (void *)0 can be debated. Each definition catches some class of bugs, while letting other classes of bugs through. Both definitions are 100% standards compliant for C. Given that NetBSD's charter is to create portable code, reverting the variadic function argument cast removal seems the most portable thing to do. Warner On Aug 31, 2011, at 7:03 PM, David Young wrote: > On Thu, Sep 01, 2011 at 03:47:29AM +0400, Valeriy E. Ushakov wrote: >> On Thu, Sep 01, 2011 at 01:24:12 +0200, Joerg Sonnenberger wrote: >> >>> Please revert this. It is incorrect at least for execl and other >>> variadic functions. >> >> What Joerg said. I know, Xenix 286 is, fortunately, no longer with >> us, but I learned its lessons the hard way :) > > Joerg, Valeriy, > > Please explain your objection. > > Dave > > -- > David Young OJC Technologies > dyo...@ojctech.com Urbana, IL * (217) 344-0444 x24 > >
Re: CVS commit: src/share/man/man4
Martin Husemann wrote: >On Tue, Aug 30, 2011 at 01:31:50PM +0100, Matthias Scheler wrote: >> It is supported by "pkgsrc/multimedia/fxtv" which the last time I had >> an analog TV feed worked well enough to watch TV. > >Just curious: are there analog TV feeds out there, anywhere, still? > New Zealand, for not much longer.
Re: CVS commit: src
On Thu, Sep 01, 2011 at 03:47:29AM +0400, Valeriy E. Ushakov wrote: > On Thu, Sep 01, 2011 at 01:24:12 +0200, Joerg Sonnenberger wrote: > > > Please revert this. It is incorrect at least for execl and other > > variadic functions. > > What Joerg said. I know, Xenix 286 is, fortunately, no longer with > us, but I learned its lessons the hard way :) Joerg, Valeriy, Please explain your objection. Dave -- David Young OJC Technologies dyo...@ojctech.com Urbana, IL * (217) 344-0444 x24
Re: CVS commit: src
On Thu, Sep 01, 2011 at 01:24:12 +0200, Joerg Sonnenberger wrote: > Please revert this. It is incorrect at least for execl and other > variadic functions. What Joerg said. I know, Xenix 286 is, fortunately, no longer with us, but I learned its lessons the hard way :) > On Wed, Aug 31, 2011 at 04:25:02PM +, Iain Hibbert wrote: > > Module Name:src > > Committed By: plunky > > Date: Wed Aug 31 16:25:00 UTC 2011 > > > > Modified Files: > > src/bin/csh: func.c > > src/bin/ksh: c_ksh.c c_sh.c history.c > > src/bin/pax: ar_io.c ar_subs.c options.c sel_subs.c > > src/bin/sh: cd.c eval.c expand.c parser.c redir.c > > src/games/adventure: init.c > > src/games/arithmetic: arithmetic.c > > src/games/boggle/boggle: help.c mach.c > > src/games/ching/printching: printching.c > > src/games/cribbage: instr.c > > src/games/fish: fish.c > > src/games/fortune/strfile: strfile.c > > src/games/hack: hack.pager.c hack.unix.c > > src/games/hunt/hunt: hunt.c > > src/games/hunt/huntd: driver.c execute.c shots.c > > src/games/mille: mille.c move.c varpush.c > > src/games/phantasia: misc.c > > src/games/rogue: machdep.c > > src/games/tetris: tetris.c > > src/games/worms: worms.c > > src/games/wump: wump.c > > src/usr.bin/chpass: chpass.c edit.c > > src/usr.bin/col: col.c > > src/usr.bin/find: ls.c > > src/usr.bin/grep: queue.c > > src/usr.bin/login: login.c > > src/usr.bin/make: parse.c > > src/usr.bin/msgs: msgs.c > > src/usr.bin/passwd: local_passwd.c > > src/usr.bin/radioctl: radioctl.c > > src/usr.bin/rpcgen: rpc_cout.c rpc_main.c rpc_svcout.c rpc_tblout.c > > rpc_util.c > > src/usr.bin/sdiff: edit.c > > src/usr.bin/shlock: shlock.c > > src/usr.bin/su: su.c > > src/usr.bin/talk: get_addrs.c > > src/usr.bin/time: time.c > > src/usr.bin/write: write.c > > src/usr.sbin/bad144: bad144.c > > src/usr.sbin/isdn/isdnd: log.c main.c process.c > > src/usr.sbin/isdn/isdntrace: trace.c > > src/usr.sbin/lpr/lpc: cmds.c > > src/usr.sbin/mrouted: kern.c main.c > > src/usr.sbin/pwd_mkdb: pwd_mkdb.c > > src/usr.sbin/route6d: route6d.c > > src/usr.sbin/rpc.pcnfsd: pcnfsd_misc.c pcnfsd_v1.c pcnfsd_v2.c > > src/usr.sbin/rpc.yppasswdd: rpc.yppasswdd.c > > src/usr.sbin/rpcbind: rpcb_svc.c rpcb_svc_4.c rpcb_svc_com.c rpcbind.c > > src/usr.sbin/sup/source: scan.c scm.c scmio.c supcmain.c supcmeat.c > > supcmisc.c supfilesrv.c supmsg.c supscan.c > > src/usr.sbin/syslogd: syslogd.c > > src/usr.sbin/tcpdchk: inetcf.c > > src/usr.sbin/user: defs.h > > src/usr.sbin/vipw: vipw.c > > > > Log Message: > > NULL does not need a cast > > > > > > To generate a diff of this commit: > > cvs rdiff -u -r1.37 -r1.38 src/bin/csh/func.c > > cvs rdiff -u -r1.16 -r1.17 src/bin/ksh/c_ksh.c > > cvs rdiff -u -r1.13 -r1.14 src/bin/ksh/c_sh.c > > cvs rdiff -u -r1.10 -r1.11 src/bin/ksh/history.c > > cvs rdiff -u -r1.52 -r1.53 src/bin/pax/ar_io.c > > cvs rdiff -u -r1.55 -r1.56 src/bin/pax/ar_subs.c > > cvs rdiff -u -r1.111 -r1.112 src/bin/pax/options.c > > cvs rdiff -u -r1.23 -r1.24 src/bin/pax/sel_subs.c > > cvs rdiff -u -r1.43 -r1.44 src/bin/sh/cd.c > > cvs rdiff -u -r1.101 -r1.102 src/bin/sh/eval.c > > cvs rdiff -u -r1.85 -r1.86 src/bin/sh/expand.c > > cvs rdiff -u -r1.79 -r1.80 src/bin/sh/parser.c > > cvs rdiff -u -r1.31 -r1.32 src/bin/sh/redir.c > > cvs rdiff -u -r1.19 -r1.20 src/games/adventure/init.c > > cvs rdiff -u -r1.25 -r1.26 src/games/arithmetic/arithmetic.c > > cvs rdiff -u -r1.6 -r1.7 src/games/boggle/boggle/help.c > > cvs rdiff -u -r1.20 -r1.21 src/games/boggle/boggle/mach.c > > cvs rdiff -u -r1.4 -r1.5 src/games/ching/printching/printching.c > > cvs rdiff -u -r1.12 -r1.13 src/games/cribbage/instr.c > > cvs rdiff -u -r1.20 -r1.21 src/games/fish/fish.c > > cvs rdiff -u -r1.33 -r1.34 src/games/fortune/strfile/strfile.c > > cvs rdiff -u -r1.19 -r1.20 src/games/hack/hack.pager.c > > cvs rdiff -u -r1.15 -r1.16 src/games/hack/hack.unix.c > > cvs rdiff -u -r1.39 -r1.40 src/games/hunt/hunt/hunt.c > > cvs rdiff -u -r1.20 -r1.21 src/games/hunt/huntd/driver.c > > cvs rdiff -u -r1.9 -r1.10 src/games/hunt/huntd/execute.c > > cvs rdiff -u -r1.11 -r1.12 src/games/hunt/huntd/shots.c > > cvs rdiff -u -r1.19 -r1.20 src/games/mille/mille.c > > cvs rdiff -u -r1.17 -r1.18 src/games/mille/move.c > > cvs rdiff -u -r1.11 -r1.12 src/games/mille/varpush.c > > cvs rdiff -u -r1.19 -r1.20 src/games/phantasia/misc.c > > cvs rdiff -u -r1.17 -r1.18 src/games/rogue/machdep.c > > cvs rdiff -u -r1.23 -r1.24 src/games/tetris/tetris.c > > cvs rdiff -u -r1.20 -r1.21 src/games/worms/worms.c > > cvs rdiff -u -r1.27 -r1.28 src/games/wump/wump.c > > cvs rdiff -u -r1.34 -r1.35 src/usr.bin/chpass/chpass.c > > cvs rdiff -u -r1.20 -r1.21 src/usr.bin/chpass/edit.c > > cvs rdiff -u -r1.16 -r1.17 src/usr.bin/col/col.c > > cvs rdiff -u -r1.20 -r1.21 src/usr.
Re: CVS commit: src
Please revert this. It is incorrect at least for execl and other variadic functions. Joerg On Wed, Aug 31, 2011 at 04:25:02PM +, Iain Hibbert wrote: > Module Name: src > Committed By: plunky > Date: Wed Aug 31 16:25:00 UTC 2011 > > Modified Files: > src/bin/csh: func.c > src/bin/ksh: c_ksh.c c_sh.c history.c > src/bin/pax: ar_io.c ar_subs.c options.c sel_subs.c > src/bin/sh: cd.c eval.c expand.c parser.c redir.c > src/games/adventure: init.c > src/games/arithmetic: arithmetic.c > src/games/boggle/boggle: help.c mach.c > src/games/ching/printching: printching.c > src/games/cribbage: instr.c > src/games/fish: fish.c > src/games/fortune/strfile: strfile.c > src/games/hack: hack.pager.c hack.unix.c > src/games/hunt/hunt: hunt.c > src/games/hunt/huntd: driver.c execute.c shots.c > src/games/mille: mille.c move.c varpush.c > src/games/phantasia: misc.c > src/games/rogue: machdep.c > src/games/tetris: tetris.c > src/games/worms: worms.c > src/games/wump: wump.c > src/usr.bin/chpass: chpass.c edit.c > src/usr.bin/col: col.c > src/usr.bin/find: ls.c > src/usr.bin/grep: queue.c > src/usr.bin/login: login.c > src/usr.bin/make: parse.c > src/usr.bin/msgs: msgs.c > src/usr.bin/passwd: local_passwd.c > src/usr.bin/radioctl: radioctl.c > src/usr.bin/rpcgen: rpc_cout.c rpc_main.c rpc_svcout.c rpc_tblout.c > rpc_util.c > src/usr.bin/sdiff: edit.c > src/usr.bin/shlock: shlock.c > src/usr.bin/su: su.c > src/usr.bin/talk: get_addrs.c > src/usr.bin/time: time.c > src/usr.bin/write: write.c > src/usr.sbin/bad144: bad144.c > src/usr.sbin/isdn/isdnd: log.c main.c process.c > src/usr.sbin/isdn/isdntrace: trace.c > src/usr.sbin/lpr/lpc: cmds.c > src/usr.sbin/mrouted: kern.c main.c > src/usr.sbin/pwd_mkdb: pwd_mkdb.c > src/usr.sbin/route6d: route6d.c > src/usr.sbin/rpc.pcnfsd: pcnfsd_misc.c pcnfsd_v1.c pcnfsd_v2.c > src/usr.sbin/rpc.yppasswdd: rpc.yppasswdd.c > src/usr.sbin/rpcbind: rpcb_svc.c rpcb_svc_4.c rpcb_svc_com.c rpcbind.c > src/usr.sbin/sup/source: scan.c scm.c scmio.c supcmain.c supcmeat.c > supcmisc.c supfilesrv.c supmsg.c supscan.c > src/usr.sbin/syslogd: syslogd.c > src/usr.sbin/tcpdchk: inetcf.c > src/usr.sbin/user: defs.h > src/usr.sbin/vipw: vipw.c > > Log Message: > NULL does not need a cast > > > To generate a diff of this commit: > cvs rdiff -u -r1.37 -r1.38 src/bin/csh/func.c > cvs rdiff -u -r1.16 -r1.17 src/bin/ksh/c_ksh.c > cvs rdiff -u -r1.13 -r1.14 src/bin/ksh/c_sh.c > cvs rdiff -u -r1.10 -r1.11 src/bin/ksh/history.c > cvs rdiff -u -r1.52 -r1.53 src/bin/pax/ar_io.c > cvs rdiff -u -r1.55 -r1.56 src/bin/pax/ar_subs.c > cvs rdiff -u -r1.111 -r1.112 src/bin/pax/options.c > cvs rdiff -u -r1.23 -r1.24 src/bin/pax/sel_subs.c > cvs rdiff -u -r1.43 -r1.44 src/bin/sh/cd.c > cvs rdiff -u -r1.101 -r1.102 src/bin/sh/eval.c > cvs rdiff -u -r1.85 -r1.86 src/bin/sh/expand.c > cvs rdiff -u -r1.79 -r1.80 src/bin/sh/parser.c > cvs rdiff -u -r1.31 -r1.32 src/bin/sh/redir.c > cvs rdiff -u -r1.19 -r1.20 src/games/adventure/init.c > cvs rdiff -u -r1.25 -r1.26 src/games/arithmetic/arithmetic.c > cvs rdiff -u -r1.6 -r1.7 src/games/boggle/boggle/help.c > cvs rdiff -u -r1.20 -r1.21 src/games/boggle/boggle/mach.c > cvs rdiff -u -r1.4 -r1.5 src/games/ching/printching/printching.c > cvs rdiff -u -r1.12 -r1.13 src/games/cribbage/instr.c > cvs rdiff -u -r1.20 -r1.21 src/games/fish/fish.c > cvs rdiff -u -r1.33 -r1.34 src/games/fortune/strfile/strfile.c > cvs rdiff -u -r1.19 -r1.20 src/games/hack/hack.pager.c > cvs rdiff -u -r1.15 -r1.16 src/games/hack/hack.unix.c > cvs rdiff -u -r1.39 -r1.40 src/games/hunt/hunt/hunt.c > cvs rdiff -u -r1.20 -r1.21 src/games/hunt/huntd/driver.c > cvs rdiff -u -r1.9 -r1.10 src/games/hunt/huntd/execute.c > cvs rdiff -u -r1.11 -r1.12 src/games/hunt/huntd/shots.c > cvs rdiff -u -r1.19 -r1.20 src/games/mille/mille.c > cvs rdiff -u -r1.17 -r1.18 src/games/mille/move.c > cvs rdiff -u -r1.11 -r1.12 src/games/mille/varpush.c > cvs rdiff -u -r1.19 -r1.20 src/games/phantasia/misc.c > cvs rdiff -u -r1.17 -r1.18 src/games/rogue/machdep.c > cvs rdiff -u -r1.23 -r1.24 src/games/tetris/tetris.c > cvs rdiff -u -r1.20 -r1.21 src/games/worms/worms.c > cvs rdiff -u -r1.27 -r1.28 src/games/wump/wump.c > cvs rdiff -u -r1.34 -r1.35 src/usr.bin/chpass/chpass.c > cvs rdiff -u -r1.20 -r1.21 src/usr.bin/chpass/edit.c > cvs rdiff -u -r1.16 -r1.17 src/usr.bin/col/col.c > cvs rdiff -u -r1.20 -r1.21 src/usr.bin/find/ls.c > cvs rdiff -u -r1.4 -r1.5 src/usr.bin/grep/queue.c > cvs rdiff -u -r1.97 -r1.98 src/usr.bin/login/login.c > cvs rdiff -u -r1.178 -r1.179 src/usr.bin/make/parse.c > cvs rdiff -u -r1.20 -r1.21 src/usr.bin/msgs/msgs.c > cvs rdiff -u -r1.34 -r1.35 src/usr.bin/passwd/local_passwd.c > cvs r
