Re: CVS commit: src/usr.bin/look
Am 23.02.12 23:57, schrieb Joerg Sonnenberger:
> Module Name: src
> Committed By: joerg
> Date: Thu Feb 23 22:57:53 UTC 2012
>
> Modified Files:
> src/usr.bin/look: look.c
>
> Log Message:
> Don't use while-loop with empty body.
I see you did several such changes. What is the reason behind this,
i.e. what is wrong with such loops?
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.15 -r1.16 src/usr.bin/look/look.c
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
>
>
>
>
> Modified files:
>
> Index: src/usr.bin/look/look.c
> diff -u src/usr.bin/look/look.c:1.15 src/usr.bin/look/look.c:1.16
> --- src/usr.bin/look/look.c:1.15 Sun Sep 4 20:29:32 2011
> +++ src/usr.bin/look/look.c Thu Feb 23 22:57:53 2012
> @@ -1,4 +1,4 @@
> -/* $NetBSD: look.c,v 1.15 2011/09/04 20:29:32 joerg Exp $ */
> +/* $NetBSD: look.c,v 1.16 2012/02/23 22:57:53 joerg Exp $ */
>
> /*-
> * Copyright (c) 1991, 1993
> @@ -42,7 +42,7 @@ __COPYRIGHT("@(#) Copyright (c) 1991, 19
> #if 0
> static char sccsid[] = "@(#)look.c 8.2 (Berkeley) 5/4/95";
> #endif
> -__RCSID("$NetBSD: look.c,v 1.15 2011/09/04 20:29:32 joerg Exp $");
> +__RCSID("$NetBSD: look.c,v 1.16 2012/02/23 22:57:53 joerg Exp $");
> #endif /* not lint */
>
> /*
> @@ -218,7 +218,7 @@ look(char *string, char *front, char *ba
> * more trouble than it's worth.
> */
> #define SKIP_PAST_NEWLINE(p, back) \
> - while (p < back && *p++ != '\n');
> + while (p < back && *p++ != '\n') continue;
>
> static char *
> binary_search(char *string, char *front, char *back)
>
--
\~.The NetBSD Foundation
\~' Marc Balmer, Developer / Marketing
NetBSD
\ mbal...@netbsd.org http://www.NetBSD.org/
Re: CVS commit: [netbsd-6] src/usr.sbin/postinstall
>>> Alan Barrett wrote > If revision 1.132 of postinstall is pulled up, then you also need > revision 1.133. I just sent the pullup request (ticket #44). -- Takeshi Nakayama
re: CVS commit: [jmcneill-usbmp] src/sys
> On Sat, Feb 18, 2012 at 07:36:37AM +, matthew green wrote: > > Module Name:src > > Committed By: mrg > > Date: Sat Feb 18 07:36:03 UTC 2012 > ... > > Log Message: > > merge to -current. > > Don't you mean pullup to -current? or has it been merged into -current? english is fun. we usually call this "sync to -current", but what i wrote also makes sense to me :-) i didn't touch -current itself. .mrg.
Re: CVS commit: [netbsd-6] src/usr.sbin/postinstall
On Thu, 23 Feb 2012, Jeff Rizzo wrote: Modified Files: src/usr.sbin/postinstall [netbsd-6]: postinstall Log Message: Pull up following revision(s) (requested by nakayama in ticket #26): usr.sbin/postinstall/postinstall: revision 1.132 Pass -d option to pwd_mkdb(8) in order to make databases at proper location. If revision 1.132 of postinstall is pulled up, then you also need revision 1.133. --apb (Alan Barrett)
Re: CVS commit: src/sys/arch
On 23 February 2012 20:15, Chuck Silvers wrote: > Module Name: src > Committed By: chs > Date: Thu Feb 23 14:45:55 UTC 2012 > > Modified Files: > src/sys/arch/amd64/amd64: machdep.c > src/sys/arch/i386/i386: machdep.c > src/sys/arch/x86/x86: identcpu.c > > Log Message: > move XEN CPU feature masking into cpu_probe() so that it's applied > to all CPUs, not just the boot CPU. > Oh cool, been scratching my head over this one today. Thanks! -- ~Cherry
Re: CVS commit: src/sys/uvm
On 2/17/12 6:41 PM, Matt Thomas wrote: Module Name:src Committed By: matt Date: Fri Feb 17 23:41:03 UTC 2012 Modified Files: src/sys/uvm: uvm_init.c uvm_param.h Log Message: Make sure to export uvmexp_* if MODULAR is defined. Make the uvmexp_page* be a pointer to a const int as well as having the pointer be const as well. Is this the change that should have supposedly fixed PR port-macppc/46041 ? Because... it doesn't. The built kernels still don't have any of the uvmexp_* symbols in them.
Re: CVS commit: [jmcneill-usbmp] src/sys
On Sat, Feb 18, 2012 at 07:36:37AM +, matthew green wrote: > Module Name: src > Committed By: mrg > Date: Sat Feb 18 07:36:03 UTC 2012 ... > Log Message: > merge to -current. Don't you mean pullup to -current? or has it been merged into -current? Reinoud
