Re: CVS commit: src/external/bsd/cron/dist

2012-12-25 Thread Christos Zoulas
In article <15993.1356420...@splode.eterna.com.au>,
matthew green   wrote:
>
>> On Mon, Dec 24, 2012 at 02:30:46PM -0500, Christos Zoulas wrote:
>>  > Modified Files:
>>  >   src/external/bsd/cron/dist: database.c
>>  > 
>>  > Log Message:
>>  > PR/47362: Brian Marcotte: cron is too restrictive on file permissions
>>  > Allow file being writable by owner.
>>  > XXX: pullup to 6.
>
>wasn't the problem that mode 0400 files were rejected?  ie, read-only
>not writable files.

Yes, it was allowing 0600 and not allowing 0400. Now it allows both.

christos



Re: CVS commit: src/external/bsd/cron/dist

2012-12-25 Thread Bernd Ernesti
On Tue, Dec 25, 2012 at 02:13:57PM +, Christos Zoulas wrote:
> In article <15993.1356420...@splode.eterna.com.au>,
> matthew green   wrote:
> >
> >> On Mon, Dec 24, 2012 at 02:30:46PM -0500, Christos Zoulas wrote:
> >>  > Modified Files:
> >>  > src/external/bsd/cron/dist: database.c
> >>  > 
> >>  > Log Message:
> >>  > PR/47362: Brian Marcotte: cron is too restrictive on file permissions
> >>  > Allow file being writable by owner.
> >>  > XXX: pullup to 6.
> >
> >wasn't the problem that mode 0400 files were rejected?  ie, read-only
> >not writable files.
> 
> Yes, it was allowing 0600 and not allowing 0400. Now it allows both.

The commit message suggested something differently: Allow file being writable 
by owner.

I haven't checked the source but when does this happen and what is the
result of this change now?
Can you now change a read only file in /var/cron/tabs with crontab -e?

Bernd



Re: CVS commit: src/external/bsd/cron/dist

2012-12-25 Thread Christos Zoulas
In article <20121225142253.ge2...@arresum.veego.de>,
Bernd Ernesti   wrote:
>
>The commit message suggested something differently: Allow file being
>writable by owner.
>
It should say not writable. I've fixed it.
>
>I haven't checked the source but when does this happen and what is the
>result of this change now?
>Can you now change a read only file in /var/cron/tabs with crontab -e?

Writing should behave exactly like before.

christos



re: CVS commit: src/external/bsd/cron/dist

2012-12-25 Thread matthew green

> >> On Mon, Dec 24, 2012 at 02:30:46PM -0500, Christos Zoulas wrote:
> >>  > Modified Files:
> >>  > src/external/bsd/cron/dist: database.c
> >>  > 
> >>  > Log Message:
> >>  > PR/47362: Brian Marcotte: cron is too restrictive on file permissions
> >>  > Allow file being writable by owner.
> >>  > XXX: pullup to 6.
> >
> >wasn't the problem that mode 0400 files were rejected?  ie, read-only
> >not writable files.

could you please fix the commit log?  it says the opposite.


.mrg.