Re: CVS commit: src/sys/fs/tmpfs
On Jan 3, 2014, at 10:13 PM, Mindaugas Rasiukevicius wrote: > "Juergen Hannken-Illjes" wrote: >> Module Name: src >> Committed By:hannken >> Date:Fri Jan 3 09:53:12 UTC 2014 >> >> Modified Files: >> src/sys/fs/tmpfs: tmpfs_subr.c tmpfs_vnops.c >> >> Log Message: >> Fix a race where thread1 runs VOP_REMOVE() and gets preempted in >> tmpfs_reclaim() before the call to tmpfs_free_node(). Thread2 >> runs VFS_FHTOVP() and gets a new vnode attached to the node thread1 >> is about to destroy. >> >> Change tmpfs_alloc_node() to always assign non-zero generation number >> and tmpfs_inactive() to set the generation number of unlinked nodes >> to zero. > > Can you explain how does this help? It still seems racy to me. Please describe the race in more detail. Tmpfs_fhtovp() will fail as soon as an unlinked tmpfs node drops its last vnode reference. > Why not just check for tn_links == 0 in tmpfs_fhtovp()? Because it is ok as long as the corresponding vnode is open/referenced. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)
Re: CVS commit: src/sys/fs/tmpfs
"Juergen Hannken-Illjes" wrote: > Module Name: src > Committed By: hannken > Date: Fri Jan 3 09:53:12 UTC 2014 > > Modified Files: > src/sys/fs/tmpfs: tmpfs_subr.c tmpfs_vnops.c > > Log Message: > Fix a race where thread1 runs VOP_REMOVE() and gets preempted in > tmpfs_reclaim() before the call to tmpfs_free_node(). Thread2 > runs VFS_FHTOVP() and gets a new vnode attached to the node thread1 > is about to destroy. > > Change tmpfs_alloc_node() to always assign non-zero generation number > and tmpfs_inactive() to set the generation number of unlinked nodes > to zero. Can you explain how does this help? It still seems racy to me. Why not just check for tn_links == 0 in tmpfs_fhtovp()? -- Mindaugas
Re: CVS commit: src/distrib/sets/lists/modules
On Fri, 3 Jan 2014, KIYOHARA Takashi wrote: Thanks to your commit. However I don't know 'solaris'. I don't know 'solaris' either. That line was present in the file before I made any changes. - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/distrib/sets/lists/modules
Hi! Paul, From: "Paul Goyette" Date: Wed, 1 Jan 2014 16:27:11 + > Module Name: src > Committed By: pgoyette > Date: Wed Jan 1 16:27:11 UTC 2014 > > Modified Files: > src/distrib/sets/lists/modules: md.evbppc mi > > Log Message: > Re-sort > > > To generate a diff of this commit: > cvs rdiff -u -r1.40 -r1.41 src/distrib/sets/lists/modules/md.evbppc > cvs rdiff -u -r1.66 -r1.67 src/distrib/sets/lists/modules/mi > > Please note that diffs are not public domain; they are subject to the > copyright notices on the relevant files. > Thanks to your commit. However I don't know 'solaris'. Index: md.evbppc === RCS file: /cvsroot/src/distrib/sets/lists/modules/md.evbppc,v retrieving revision 1.40 retrieving revision 1.41 diff -u -r1.40 -r1.41 --- md.evbppc 30 Dec 2013 14:17:54 - 1.40 +++ md.evbppc 1 Jan 2014 16:27:10 - 1.41 @@ -397,6 +425,8 @@ ./stand/powerpc-booke/@OSRELEASE@/modules/secmodel_overlay/secmodel_overlay.kmod base-kernel-modules kmod,compatmodules ./stand/powerpc-booke/@OSRELEASE@/modules/securelevel base-kernel-modules kmod,compatmodules ./stand/powerpc-booke/@OSRELEASE@/modules/securelevel/securelevel.kmod base-kernel-modules kmod,compatmodules +./stand/powerpc-booke/@OSRELEASE@/modules/skipjack base-kernel-modules kmod,solaris +./stand/powerpc-booke/@OSRELEASE@/modules/skipjack/skipjack.kmod base-kernel-modules kmod,solaris ./stand/powerpc-booke/@OSRELEASE@/modules/smbfs base-kernel-modules kmod,compatmodules ./stand/powerpc-booke/@OSRELEASE@/modules/smbfs/smbfs.kmod base-kernel-modules kmod,compatmodules ./stand/powerpc-booke/@OSRELEASE@/modules/solaris base-kernel-modules kmod,solaris Thanks, -- kiyohara
Re: CVS commit: src/include
On Jan 2, 6:33pm, "Christos Zoulas" wrote: } } This is a multi-part message in MIME format. } } --_--=_1388705630257000 } Content-Disposition: inline } Content-Transfer-Encoding: 8bit } Content-Type: text/plain; charset="US-ASCII" } } Module Name: src } Committed By: christos } Date: Thu Jan 2 23:33:50 UTC 2014 } } Modified Files: } src/include: unistd.h } } Log Message: } PR/4891: Wiz: readlink moved from xopen to base at issue 5. This should have been PR/48491. PR/4891 cleaned up. }-- End of excerpt from "Christos Zoulas"
