Re: CVS commit: src/bin/ed

2014-03-25 Thread David Holland
On Tue, Mar 25, 2014 at 05:23:37PM +, Joerg Sonnenberger wrote:
 > Modified Files:
 >  src/bin/ed: ed.h
 > 
 > Log Message:
 > Use __printflike.

Oops, sorry about that.

-- 
David A. Holland
dholl...@netbsd.org


Re: CVS commit: src/usr.sbin/rtsold

2014-03-25 Thread David Laight
On Tue, Mar 25, 2014 at 05:17:44PM +, Joerg Sonnenberger wrote:
> Module Name:  src
> Committed By: joerg
> Date: Tue Mar 25 17:17:44 UTC 2014
> 
> Modified Files:
>   src/usr.sbin/rtsold: rtsold.c
> 
> Log Message:
> Don't cast to time_t just to implicitly cast to uint32_t next.

Gah - I hadn't spotted that xtos had added a cast as well.
There is another cast that ought to be pointless two lines later.

David

-- 
David Laight: da...@l8s.co.uk


Re: CVS commit: src/gnu/usr.bin/texinfo/makeinfo

2014-03-25 Thread Matthias Scheler
On Tue, Mar 25, 2014 at 11:56:56AM -0400, Christos Zoulas wrote:
> | > How does it fail? Segv? Syntax error?
> | 
> | It complains about a lot missing links between nodes. All nodes need
> | to have up, next and prev link. And it has code to automatically
> | populate those. But for some reason the string it is coping is empty
> | and it therefore considers the links missing. I've tried to find
> | out what and where goes wrong but failed to do so.
> 
> Thanks! Perhaps it is a real bug...

I guess it is somewhere in the middle. There might be some questionable
code which breaks because of the limit enforcing of fortification.
But I couldn't find it yesterday and I really wanted to have "emacs"
on my NetBSD-current machine.

Kind regards

-- 
Matthias Scheler https://zhadum.org.uk/


Re: CVS commit: src/gnu/usr.bin/texinfo/makeinfo

2014-03-25 Thread Christos Zoulas
On Mar 25,  7:47am, t...@netbsd.org (Matthias Scheler) wrote:
-- Subject: Re: CVS commit: src/gnu/usr.bin/texinfo/makeinfo

| On Mon, Mar 24, 2014 at 11:20:04PM +, Christos Zoulas wrote:
| > In article <20140324230302.1ad1...@cvs.netbsd.org>,
| > Matthias Scheler  wrote:
| > >Module Name:   src
| > >Committed By:  tron
| > >Date:  Mon Mar 24 23:03:02 UTC 2014
| > >
| > >Modified Files:
| > >   src/gnu/usr.bin/texinfo/makeinfo: Makefile
| > >
| > >Log Message:
| > >Don't compile with fortification. It breaks makeinfo(1) for certain
| > >input files (e.g. "cl.texi" shipped with Emacs 23.4) if it is compiled
| > >with GCC 4.8.3 and "USE_SSP" set to "yes".
| > 
| > How does it fail? Segv? Syntax error?
| 
| It complains about a lot missing links between nodes. All nodes need
| to have up, next and prev link. And it has code to automatically
| populate those. But for some reason the string it is coping is empty
| and it therefore considers the links missing. I've tried to find
| out what and where goes wrong but failed to do so.

Thanks! Perhaps it is a real bug...

christos


Re: CVS commit: src/gnu/usr.bin/texinfo/makeinfo

2014-03-25 Thread Matthias Scheler
On Mon, Mar 24, 2014 at 11:20:04PM +, Christos Zoulas wrote:
> In article <20140324230302.1ad1...@cvs.netbsd.org>,
> Matthias Scheler  wrote:
> >Module Name: src
> >Committed By:tron
> >Date:Mon Mar 24 23:03:02 UTC 2014
> >
> >Modified Files:
> > src/gnu/usr.bin/texinfo/makeinfo: Makefile
> >
> >Log Message:
> >Don't compile with fortification. It breaks makeinfo(1) for certain
> >input files (e.g. "cl.texi" shipped with Emacs 23.4) if it is compiled
> >with GCC 4.8.3 and "USE_SSP" set to "yes".
> 
> How does it fail? Segv? Syntax error?

It complains about a lot missing links between nodes. All nodes need
to have up, next and prev link. And it has code to automatically
populate those. But for some reason the string it is coping is empty
and it therefore considers the links missing. I've tried to find
out what and where goes wrong but failed to do so.

Kind regards

-- 
Matthias Scheler https://zhadum.org.uk/