re: CVS commit: src/usr.bin/xlint/lint1
Alan Barrett writes: > On Fri, 18 Apr 2014, matthew green wrote: > >> don't include fmemopen in tools builds. Since tools does not > >> define _NETBSD_SOURCE, we don't get the fmemopen prototype > > > > hmm is that because we define _SOMEOTHER_SOURCE? > > > > _NETBSD_SOURCE should be defined normally, unless you start to > > ask for restricted namespaces... > > src/tools/compat/compat_defs.h goes to a lot of trouble to ensure > that _NETBSD_SOURCE does not get defined. I don't understand why > that is done. indeed. that's probably a good idea in general -- it means that we're going to have a restricted environment for tools, even on netbsd, which helps keep them portable to other platforms. .mrg.
Re: CVS commit: src/sys/arch/x86/acpi
In article <20140418072727.GA2474@marx.bitnet>, Jukka Ruohonen wrote: >On Thu, Apr 17, 2014 at 12:01:24PM -0400, Christos Zoulas wrote: >> Module Name: src >> Committed By:christos >> Date:Thu Apr 17 16:01:24 UTC 2014 >> >> Modified Files: >> src/sys/arch/x86/acpi: acpi_cpu_md.c >> >> Log Message: >> CID/1203191: Out of bounds read > >Oh, nasty. The code was pretty much copy-pasted from ../x86/x86/est.c, >which might be therefore worth to briefly check too. It was correct, but I made it more conservative. christos
re: CVS commit: src/usr.bin/xlint/lint1
On Apr 18, 3:24pm, m...@eterna.com.au (matthew green) wrote: -- Subject: re: CVS commit: src/usr.bin/xlint/lint1 | | "Christos Zoulas" writes: | > Module Name:src | > Committed By: christos | > Date: Fri Apr 18 02:17:14 UTC 2014 | > | > Modified Files: | > src/usr.bin/xlint/lint1: main1.c | > | > Log Message: | > don't include fmemopen in tools builds. Since tools does not define | > _NETBSD_SOURCE, we don't get the fmemopen prototype | | hmm is that because we define _SOMEOTHER_SOURCE? | | _NETBSD_SOURCE should be defined normally, unless you start to ask | for restricted namespaces... Yes, I think we define _POSIX_SOURCE. fmemopen is problematic because it uses funopen() which cannot be easily implemented with 3rd party stdio. christos
Re: CVS commit: src/usr.bin/xlint/lint1
On Fri, 18 Apr 2014, matthew green wrote: don't include fmemopen in tools builds. Since tools does not define _NETBSD_SOURCE, we don't get the fmemopen prototype hmm is that because we define _SOMEOTHER_SOURCE? _NETBSD_SOURCE should be defined normally, unless you start to ask for restricted namespaces... src/tools/compat/compat_defs.h goes to a lot of trouble to ensure that _NETBSD_SOURCE does not get defined. I don't understand why that is done. --apb (Alan Barrett)
Re: CVS commit: src/sys/arch/x86/acpi
On Thu, Apr 17, 2014 at 12:01:24PM -0400, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Thu Apr 17 16:01:24 UTC 2014 > > Modified Files: > src/sys/arch/x86/acpi: acpi_cpu_md.c > > Log Message: > CID/1203191: Out of bounds read Oh, nasty. The code was pretty much copy-pasted from ../x86/x86/est.c, which might be therefore worth to briefly check too. - Jukka.
