Re: CVS commit: src/sys/dev/bluetooth

2015-05-08 Thread Maxime Villard 
Le 30/04/2015 18:01, Christos Zoulas a écrit :
 Module Name:  src
 Committed By: christos
 Date: Thu Apr 30 16:01:52 UTC 2015
 
 Modified Files:
   src/sys/dev/bluetooth: bcsp.c
 
 Log Message:
 Fix more memory leaks by changing the transmit routines to always free the
 mbuf to send.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.26 -r1.27 src/sys/dev/bluetooth/bcsp.c
 

Why didn't you put a goto out here:

1369:if (_m-m_len  0)
1370:return false;

?

Re: CVS commit: src/sys/dev/bluetooth

2015-05-08 Thread Christos Zoulas 
On May 8, 12:05pm, m...@m00nbsd.net (Maxime Villard) wrote:
-- Subject: Re: CVS commit: src/sys/dev/bluetooth

| Why didn't you put a goto out here:
| 
| 1369:if (_m-m_len  0)
| 1370:return false;

I missed it. I don't know if the test is valid though. If this condition
is true it should probably cause an assert... The standard mbuf operations
don't check for this. Nevertheless I will fix it to be consistent for now.

christos