re: CVS commit: src/sys
"Tyler R. Retzlaff" writes: > Module Name: src > Committed By: rtr > Date: Thu May 21 02:04:22 UTC 2015 > > Modified Files: > src/sys/kern: subr_tftproot.c > src/sys/nfs: krpc_subr.c nfs_boot.c nfs_bootdhcp.c nfsdiskless.h > > Log Message: > change nfs_boot_sendrecv to take sockaddr_in * instead of mbuf * > > fixes m_serv (single mbuf leak) leak in kern/subr_tftproot.c nfs can be a module; does this require a version bump? .mrg.
Re: CVS commit: src/sys/sys
On Tue, May 19, 2015 at 11:35:11PM +, Taylor R Campbell wrote: > Module Name: src > Committed By: riastradh > Date: Tue May 19 23:35:11 UTC 2015 > > Modified Files: > src/sys/sys: time.h > > Log Message: > Avoid C99 initializers outside _KERNEL. Two comments. First: C99 initializers are not valid C++, which makes it even more problematic. Second, can't you just write them as plain struct init? It's unlikely that the structures will grow more entries after all... Joerg
Re: CVS commit: src/sys
On 5/21/2015 4:20 AM, matthew green wrote: "Tyler R. Retzlaff" writes: Module Name:src Committed By: rtr Date: Thu May 21 02:04:22 UTC 2015 Modified Files: src/sys/kern: subr_tftproot.c src/sys/nfs: krpc_subr.c nfs_boot.c nfs_bootdhcp.c nfsdiskless.h Log Message: change nfs_boot_sendrecv to take sockaddr_in * instead of mbuf * fixes m_serv (single mbuf leak) leak in kern/subr_tftproot.c nfs can be a module; does this require a version bump? I couldn't see how it could be used from a module sensibly so I opted not to bump. But as you know with everything exported anything is possible. Would you like me to bump? rtr
re: CVS commit: src/sys
Tyler Retzlaff writes: > > On 5/21/2015 4:20 AM, matthew green wrote: > > "Tyler R. Retzlaff" writes: > >> Module Name: src > >> Committed By: rtr > >> Date: Thu May 21 02:04:22 UTC 2015 > >> > >> Modified Files: > >>src/sys/kern: subr_tftproot.c > >>src/sys/nfs: krpc_subr.c nfs_boot.c nfs_bootdhcp.c nfsdiskless.h > >> > >> Log Message: > >> change nfs_boot_sendrecv to take sockaddr_in * instead of mbuf * > >> > >> fixes m_serv (single mbuf leak) leak in kern/subr_tftproot.c > > > > nfs can be a module; does this require a version bump? > > I couldn't see how it could be used from a module sensibly so I opted > not to bump. > > But as you know with everything exported anything is possible. > > Would you like me to bump? pxeboot can load nfs module -- infact, it does it by default. so yeah, this is actually a real problem :-) .mrg.
Re: CVS commit: src/sys
On 5/21/2015 6:08 PM, matthew green wrote: Tyler Retzlaff writes: On 5/21/2015 4:20 AM, matthew green wrote: Would you like me to bump? pxeboot can load nfs module -- infact, it does it by default. so yeah, this is actually a real problem :-) bumped! rtr
