Re: CVS commit: src/sys/dev/gpio
Shouldn't we also add a dependency from the gpio module to require the sysmon_taskq module? On Thu, 15 Oct 2015, Jared D. McNeill wrote: Module Name:src Committed By: jmcneill Date: Thu Oct 15 09:07:49 UTC 2015 Modified Files: src/sys/dev/gpio: files.gpio Log Message: pull in sysmon_taskq To generate a diff of this commit: cvs rdiff -u -r1.13 -r1.14 src/sys/dev/gpio/files.gpio Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. +--+--+-+ | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | (Retired)| FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd.org | +--+--+-+
Re: CVS commit: src/usr.bin/make
On Mon, 12 Oct 2015 16:48:13 + "Simon J. Gerraty" wrote: > Module Name: src > Committed By: sjg > Date: Mon Oct 12 16:48:13 UTC 2015 > > Modified Files: > src/usr.bin/make: var.c > > Log Message: > The conditional expressions used with ':?' can be expensive > eg. exists() does stat(2). > If 'wantit' is FALSE, we are going to discard everything anyway, > so skip evaluating the conditional and expanding either lhs or rhs. /work/src/usr.bin/make/var.c:2772:7: error: variable 'emsg' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] if (wantit) /work/src/usr.bin/make/var.c:2777:7: note: uninitialized use occurs here if (emsg) /work/src/usr.bin/make/var.c:2772:3: note: remove the 'if' if its condition is always true if (wantit) /work/src/usr.bin/make/var.c:2760:19: note: initialize the variable 'emsg' to silence this warning const char *emsg; 1 error generated.
Re: CVS commit: src/sys/dev/gpio
I should have been more clear in the commit message -- I added the dependency on gpiobutton(4), not gpio(4). On Fri, 16 Oct 2015, Paul Goyette wrote: Date: Fri, 16 Oct 2015 15:47:43 +0800 (PHT) From: Paul Goyette Reply-To: p...@whooppee.com To: source-changes-d@NetBSD.org Cc: Jared D. McNeill Subject: Re: CVS commit: src/sys/dev/gpio Shouldn't we also add a dependency from the gpio module to require the sysmon_taskq module? On Thu, 15 Oct 2015, Jared D. McNeill wrote: Module Name:src Committed By: jmcneill Date: Thu Oct 15 09:07:49 UTC 2015 Modified Files: src/sys/dev/gpio: files.gpio Log Message: pull in sysmon_taskq To generate a diff of this commit: cvs rdiff -u -r1.13 -r1.14 src/sys/dev/gpio/files.gpio Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. +--+--+-+ | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | (Retired)| FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd.org | +--+--+-+
