Re: CVS commit: src/tests/lib/libpthread

2016-10-31 Thread Christos Zoulas 
In article <0c9230c6-d206-5332-d89c-e0b93d3de...@gmx.com>,
Kamil Rytarowski   wrote:
>-=-=-=-=-=-
>-=-=-=-=-=-
>
>
>
>On 31.10.2016 21:23, Taylor R Campbell wrote:
>>Date: Mon, 31 Oct 2016 18:29:56 +0100
>>From: Kamil Rytarowski 
>> 
>>pthread_mutex_timedlock(3) is broken and it does not work at all for me,
>>not as a standard mutex (like pthread_mutex_lock(3), sufficiently
>>lengthy timeout makes it a good approximation) neither as a timed variant.
>> 
>> If the test is expected to fail, you should mark it xfail with a
>> reference to a PR so that it doesn't draw needless attention to
>> itself.
>> 
>> The autobuild system is designed to detect and flag unexpected
>> failures; expected ones should be documented in the PR database
>> instead.
>> 
>
>You are right, thank you.
>
>The problem is under investigation right now and is "hot".

I have a patch for it:

http://www.netbsd.org/~christos/deadlock.diff
And a standalone program that reproduces it (from the test):
http://www.netbsd.org/~christos/deadlock.c

christos

Re: CVS commit: src/tests/lib/libpthread

2016-10-31 Thread Kamil Rytarowski 


On 31.10.2016 21:23, Taylor R Campbell wrote:
>Date: Mon, 31 Oct 2016 18:29:56 +0100
>From: Kamil Rytarowski 
> 
>pthread_mutex_timedlock(3) is broken and it does not work at all for me,
>not as a standard mutex (like pthread_mutex_lock(3), sufficiently
>lengthy timeout makes it a good approximation) neither as a timed variant.
> 
> If the test is expected to fail, you should mark it xfail with a
> reference to a PR so that it doesn't draw needless attention to
> itself.
> 
> The autobuild system is designed to detect and flag unexpected
> failures; expected ones should be documented in the PR database
> instead.
> 

You are right, thank you.

The problem is under investigation right now and is "hot".



signature.asc
Description: OpenPGP digital signature

Re: CVS commit: src/tests/lib/libpthread

2016-10-31 Thread Taylor R Campbell 
   Date: Mon, 31 Oct 2016 18:29:56 +0100
   From: Kamil Rytarowski 

   pthread_mutex_timedlock(3) is broken and it does not work at all for me,
   not as a standard mutex (like pthread_mutex_lock(3), sufficiently
   lengthy timeout makes it a good approximation) neither as a timed variant.

If the test is expected to fail, you should mark it xfail with a
reference to a PR so that it doesn't draw needless attention to
itself.

The autobuild system is designed to detect and flag unexpected
failures; expected ones should be documented in the PR database
instead.

Re: CVS commit: src/tests/lib/libpthread

2016-10-31 Thread Kamil Rytarowski 


On 31.10.2016 17:21, Christos Zoulas wrote:
> Module Name:  src
> Committed By: christos
> Date: Mon Oct 31 16:21:23 UTC 2016
> 
> Modified Files:
>   src/tests/lib/libpthread: t_mutex.c t_timedmutex.c
> 
> Log Message:
> Merge and fix the timed mutex tests to use absolute time.
> NB: the new tests are broken?
> 
> 

Tests are good.

pthread_mutex_timedlock(3) is broken and it does not work at all for me,
not as a standard mutex (like pthread_mutex_lock(3), sufficiently
lengthy timeout makes it a good approximation) neither as a timed variant.



signature.asc
Description: OpenPGP digital signature