Re: CVS commit: src/sys
> On 11 Nov 2016, at 22:28, Jaromír Doleček wrote:
>
> 2016-11-11 11:52 GMT+01:00 J. Hannken-Illjes :
>> Returning a pointer to an arbitrary list element and using it
>> later is bad design. Would be better to define as:
>>
>> wapbl_unregister_deallocation(struct wapbl *wl, daddr_t blk, int len)
>> {
>
> I simply want to have it O(1). I think it is useful to keep the error
> path there fast, as it would be quite common for wapbl case. Also just
> passing the (opaque) pointer makes it simpler.
This error path (call UFS_WAPBL_UNREGISTER_DEALLOCATION()) is not that
common and runs not more than once during one run of ffs_truncate().
I don't see a need to have it O(1).
--
J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)
Re: CVS commit: src/sbin/mount_puffs
On 23.11.2016 15:33, Masatake Daimon wrote: > Module Name: src > Committed By: pho > Date: Wed Nov 23 14:33:29 UTC 2016 > > Modified Files: > src/sbin/mount_puffs: mount_puffs.8 mount_puffs.c > > Log Message: > Major rework on mount_puffs(8) so that it can actually start file servers > > Now you can do > # mount_puffs -o rdonly rot13fs#/home/foo /mnt/rot13 > > or in fstab > rot13fs#/home/foo /mnt/rot13 puffs rdonly > > to start rot13fs with arguments identical to > # rot13fs -o rdonly /home/foo /mnt/rot13 > > > To generate a diff of this commit: > cvs rdiff -u -r1.1 -r1.2 src/sbin/mount_puffs/mount_puffs.8 > cvs rdiff -u -r1.4 -r1.5 src/sbin/mount_puffs/mount_puffs.c > > Please note that diffs are not public domain; they are subject to the > copyright notices on the relevant files. > Thanks for improving the man-page, it used to be the most cryptic one I could find in NetBSD! What do you think about adding an entry in a section EXAMPLES linking to src/share/examples/puffs/rot13fs/rot13fs.c as we use rot13fs in example command snippets. It's worth to cross-reference all puffs filesystems out there, there is at least mount_sysctlfs(8). Thank you for your work! signature.asc Description: OpenPGP digital signature
