Re: CVS commit: src/lib/libc/net

2016-12-06 Thread David Holland 
On Tue, Dec 06, 2016 at 01:41:03PM -0500, Christos Zoulas wrote:
 > Module Name: src
 > Committed By:christos
 > Date:Tue Dec  6 18:41:03 UTC 2016
 > 
 > Modified Files:
 >  src/lib/libc/net: linkaddr.c
 > 
 > Log Message:
 > Fix buffer copy without checking the size of input:
 > https://www.kb.cert.org/vuls/id/548487

Doesn't this need 

-   if (out >= obuf + sizeof(obuf)) \
+   if (out >= obuf + sizeof(obuf) - 1) \

to avoid having the null terminator off the end?

-- 
David A. Holland
dholl...@netbsd.org

Re: CVS commit: src/tests/kernel

2016-12-06 Thread Christos Zoulas 
In article <0a6e53d7-4f6e-6e25-cd61-2342e1c4e...@gmx.com>,
Kamil Rytarowski   wrote:
>-=-=-=-=-=-
>-=-=-=-=-=-
>
>On 06.12.2016 19:59, Christos Zoulas wrote:
>> Module Name: src
>> Committed By:christos
>> Date:Tue Dec  6 18:59:00 UTC 2016
>> 
>> Modified Files:
>>  src/tests/kernel: t_ptrace_wait.c
>> 
>> Log Message:
>> switch to using fork so we can see the child output.
>> 
>
>atf_utils_fork() still works however... it outputs to .txt files, one
>file is saved from stdout and the other from stderr.

No, because it overwrites files on multiuple forks and you lose the
order of printing.

>Maybe we should rework atf_utils_fork() in ATF to just work like
>fork(2), with setup for buffering and exit on failure?

Well, I was thinking of enhancing it but then I decided against it.
(too much work for little benefit).

christos

Re: CVS commit: src/tests/kernel

2016-12-06 Thread Kamil Rytarowski 
On 06.12.2016 19:59, Christos Zoulas wrote:
> Module Name:  src
> Committed By: christos
> Date: Tue Dec  6 18:59:00 UTC 2016
> 
> Modified Files:
>   src/tests/kernel: t_ptrace_wait.c
> 
> Log Message:
> switch to using fork so we can see the child output.
> 

atf_utils_fork() still works however... it outputs to .txt files, one
file is saved from stdout and the other from stderr.

Maybe we should rework atf_utils_fork() in ATF to just work like
fork(2), with setup for buffering and exit on failure?



signature.asc
Description: OpenPGP digital signature