Re: sys/modules/spkr

[Paul Goyette]

On Fri, 9 Dec 2016, I wrote (but not cc'd to source-changes-d):


I noticed that you updated spkr.c to retain the existing default behavior
of "spkr* at pcppi?"

Do you have any intention to provide a synth_spkr module which would use
your new capabilities?  It looks like it would be fairly trivial.


Also, rather than using #ifdef PCPPISPEAKER to conditionalize large 
chunks of dev/isa/spkr.c it seems to me that a better approach would 
have been to split the existing file into common code, and adding a new 
file for the pcppi attachment stuff.




+--+--++
| Paul Goyette | PGP Key fingerprint: | E-mail addresses:  |
| (Retired)| FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd.org |
+--+--++

Re: CVS commit: src

[Nathanial Sloss]

Hi,

On Fri, 9 Dec 2016 03:03:04 J. Hannken-Illjes wrote:
> > On 08 Dec 2016, at 15:41, Nathanial Sloss  wrote:
> > 
> > On Thu, 8 Dec 2016 23:57:51 J. Hannken-Illjes wrote:
> >> +#defineD_MCLOSE0x0004
> >> 
> >> What is a MCLOSE device class?
> > 
> > Normally character devices are don't execute the close function untill
> > the last instance of device is closed.  MCLOSE is short for multiple
> > close, for use when you want the close function to run when any instance
> > of the device, in this case audio, is closed.
> 
> So it should become a flag like 0x0400, not a class in the 0x00ff range.
>

Done.  I've just committed a fix.

Best regards,

Nat.

Re: CVS commit: src

[Nathanial Sloss]

Hi,

That was not intended and I've just committed a fix.

Best regards,

Nat.
On Fri, 9 Dec 2016 02:49:27 Kamil Rytarowski wrote:

> > Log Message:
> > Add a synthesized pc beeper and keyboard bell for platforms with an audio
> > device.
> 
> Is it intended that speaker device for aarch64 is called spkr while for
> others speaker?

Re: CVS commit: src

[coypu]

On Thu, Dec 08, 2016 at 05:03:04PM +0100, J. Hannken-Illjes wrote:
> 
> > On 08 Dec 2016, at 15:41, Nathanial Sloss  wrote:
> > 
> > On Thu, 8 Dec 2016 23:57:51 J. Hannken-Illjes wrote:
> >> +#defineD_MCLOSE0x0004
> >> 
> >> What is a MCLOSE device class?
> >> 
> > 
> > Normally character devices are don't execute the close function untill the 
> > last instance of device is closed.  MCLOSE is short for multiple close, for 
> > use when you want the close function to run when any instance of the 
> > device, 
> > in this case audio, is closed.
> 
> So it should become a flag like 0x0400, not a class in the 0x00ff range.
> 
> Where was this change discussed?
> 

Whole change was introduced in a fairly long thread, starting here:
http://mail-index.netbsd.org/tech-kern/2016/05/thread1.html#020572

Re: CVS commit: src

[J. Hannken-Illjes]

> On 08 Dec 2016, at 15:41, Nathanial Sloss  wrote:
> 
> On Thu, 8 Dec 2016 23:57:51 J. Hannken-Illjes wrote:
>> +#defineD_MCLOSE0x0004
>> 
>> What is a MCLOSE device class?
>> 
> 
> Normally character devices are don't execute the close function untill the 
> last instance of device is closed.  MCLOSE is short for multiple close, for 
> use when you want the close function to run when any instance of the device, 
> in this case audio, is closed.

So it should become a flag like 0x0400, not a class in the 0x00ff range.

Where was this change discussed?

--
J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: CVS commit: src

[Kamil Rytarowski]

On 08.12.2016 12:31, Nathanial Sloss wrote:
> Module Name:  src
> Committed By: nat
> Date: Thu Dec  8 11:31:15 UTC 2016
> 
> Modified Files:
>   src/etc/etc.aarch64: MAKEDEV.conf
>   src/etc/etc.algor: MAKEDEV.conf
>   src/etc/etc.amiga: MAKEDEV.conf
>   src/etc/etc.amigappc: MAKEDEV.conf
>   src/etc/etc.atari: MAKEDEV.conf
>   src/etc/etc.cats: MAKEDEV.conf
>   src/etc/etc.cobalt: MAKEDEV.conf
>   src/etc/etc.dreamcast: MAKEDEV.conf
>   src/etc/etc.epoc32: MAKEDEV.conf
>   src/etc/etc.evbarm: MAKEDEV.conf
>   src/etc/etc.evbppc: MAKEDEV.conf
>   src/etc/etc.evbsh3: MAKEDEV.conf
>   src/etc/etc.hpcarm: MAKEDEV.conf
>   src/etc/etc.hpcmips: MAKEDEV.conf
>   src/etc/etc.hppa: MAKEDEV.conf
>   src/etc/etc.landisk: MAKEDEV.conf
>   src/etc/etc.macppc: MAKEDEV.conf
>   src/etc/etc.mmeye: MAKEDEV.conf
>   src/etc/etc.or1k: MAKEDEV.conf
>   src/etc/etc.pmax: MAKEDEV.conf
>   src/etc/etc.sgimips: MAKEDEV.conf
>   src/etc/etc.shark: MAKEDEV.conf
>   src/etc/etc.sparc: MAKEDEV.conf
>   src/etc/etc.sparc64: MAKEDEV.conf
>   src/etc/etc.x68k: MAKEDEV.conf
>   src/etc/etc.zaurus: MAKEDEV.conf
>   src/share/man/man4: speaker.4
>   src/sys/arch/acorn32/conf: EB7500ATX GENERIC INSTALL LOWMEM_WSCONS NC
>   src/sys/arch/algor/conf: majors.algor
>   src/sys/arch/alpha/conf: GENERIC majors.alpha
>   src/sys/arch/amd64/conf: ALL GENERIC XEN3_DOM0 majors.amd64
>   src/sys/arch/amiga/conf: AMIGA DRACO GENERIC GENERIC.in MDINSTALL
>   src/sys/arch/amigappc/conf: GENERIC NULL
>   src/sys/arch/atari/conf: GENERIC.in HADES HADES.in MILAN-ISAIDE
>   MILAN-PCIIDE
>   src/sys/arch/bebox/conf: GENERIC INSTALL majors.bebox
>   src/sys/arch/cats/conf: GENERIC INSTALL
>   src/sys/arch/cobalt/conf: GENERIC INSTALL
>   src/sys/arch/dreamcast/conf: GENERIC
>   src/sys/arch/emips/conf: GENERIC
>   src/sys/arch/epoc32/conf: GENERIC
>   src/sys/arch/evbarm/conf: ALLWINNER_A80 ARMADILLO9 BPI CUBIEBOARD
>   GUMSTIX HDL_G HPT5325 HUMMINGBIRD_A31 IMX23_OLINUXINO LUBBOCK
>   MINI2440 MMNET_GENERIC MPCSA_GENERIC MV2120 POGO RPI SHEEVAPLUG
>   SMDK2410 TEGRA TS7200 TWINTAIL
>   src/sys/arch/evbmips/conf: ALCHEMY LOONGSON MALTA majors.evbmips
>   src/sys/arch/evbppc/conf: EV64260 OPENBLOCKS266_OPT PMPPC
>   src/sys/arch/hp300/conf: GENERIC
>   src/sys/arch/hpcarm/conf: NETBOOKPRO WZERO3
>   src/sys/arch/hpcmips/conf: GENERIC TX3922 VR41XX
>   src/sys/arch/hppa/conf: GENERIC
>   src/sys/arch/i386/conf: ALL GENERIC GENERIC_TINY INSTALL_FLOPPY
>   INSTALL_TINY XEN3_DOM0 majors.i386
>   src/sys/arch/ia64/conf: majors.ia64
>   src/sys/arch/ibmnws/conf: GENERIC
>   src/sys/arch/iyonix/conf: GENERIC
>   src/sys/arch/landisk/conf: GENERIC
>   src/sys/arch/macppc/conf: GENERIC GENERIC_601 POWERMAC_G5
>   src/sys/arch/mmeye/conf: MMEYE_WLF
>   src/sys/arch/netwinder/conf: GENERIC
>   src/sys/arch/ofppc/conf: GENERIC
>   src/sys/arch/playstation2/conf: DEBUG
>   src/sys/arch/pmax/conf: GENERIC GENERIC64 INSTALL INSTALL64
>   src/sys/arch/powerpc/conf: majors.powerpc
>   src/sys/arch/prep/conf: GENERIC majors.prep
>   src/sys/arch/riscv/conf: majors.riscv
>   src/sys/arch/sandpoint/conf: ENCPP1
>   src/sys/arch/sgimips/conf: GENERIC32_IP2x GENERIC32_IP3x
>   src/sys/arch/shark/conf: GENERIC INSTALL
>   src/sys/arch/sparc/conf: GENERIC INSTALL KRUPS MRCOFFEE TADPOLE3GX
>   src/sys/arch/sparc64/conf: GENERIC NONPLUS64
>   src/sys/arch/usermode/conf: GENERIC.common
>   src/sys/arch/vax/conf: GENERIC
>   src/sys/arch/x68k/conf: GENERIC INSTALL
>   src/sys/arch/x86/acpi: acpi_cpu_md.c
>   src/sys/arch/zaurus/conf: GENERIC INSTALL
>   src/sys/conf: majors
>   src/sys/dev: audiobell.c audiobellvar.h files.audio
>   src/sys/dev/isa: files.isa spkr.c
>   src/sys/dev/wscons: wskbd.c
> Added Files:
>   src/sys/dev: spkr_synth.c spkrvar.h
> 
> Log Message:
> Add a synthesized pc beeper and keyboard bell for platforms with an audio
> device.

Is it intended that speaker device for aarch64 is called spkr while for
others speaker?




signature.asc
Description: OpenPGP digital signature

Re: CVS commit: src

[Nathanial Sloss]

On Thu, 8 Dec 2016 23:57:51 J. Hannken-Illjes wrote:
> +#defineD_MCLOSE0x0004
> 
> What is a MCLOSE device class?
> 

Normally character devices are don't execute the close function untill the 
last instance of device is closed.  MCLOSE is short for multiple close, for 
use when you want the close function to run when any instance of the device, 
in this case audio, is closed.


Best regards,

Nat

Re: CVS commit: src

[J. Hannken-Illjes]

> On 08 Dec 2016, at 11:28, Nathanial Sloss  wrote:
> 
> Module Name:  src
> Committed By: nat
> Date: Thu Dec  8 10:28:44 UTC 2016
> 
> Modified Files:
>   src/sys/dev: audio.c audiovar.h files.audio
>   src/sys/miscfs/specfs: spec_vnops.c
>   src/sys/sys: audioio.h conf.h
>   src/usr.bin/audio/ctl: audioctl.1 ctl.c
> 
> Log Message:
> The audio sub-system now supports the following features as
> posted to tech-kern:
> 
>* Simultaneous playback and mixing of multiple streams
>* Playback streams can be of different encoding, frequency, precision
>  and number of channels
>* Simultaneous recording to different formats
>* One audio device per process
>* Sysctls to set the common format frequency, precision and channels
>* Independent mixer controls for recording/playback per stream
>* Utilizes little cpu time for multiple streams / good performance
>* Compatible with existing programs that use OSS/NetBSD audio
>* Changes to audioctl(1) to allow specifying process id for corresponding
>  audio device
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.268 -r1.269 src/sys/dev/audio.c
> cvs rdiff -u -r1.46 -r1.47 src/sys/dev/audiovar.h
> cvs rdiff -u -r1.3 -r1.4 src/sys/dev/files.audio
> cvs rdiff -u -r1.165 -r1.166 src/sys/miscfs/specfs/spec_vnops.c

+#defineD_MCLOSE0x0004

What is a MCLOSE device class?

> cvs rdiff -u -r1.34 -r1.35 src/sys/sys/audioio.h
> cvs rdiff -u -r1.146 -r1.147 src/sys/sys/conf.h
> cvs rdiff -u -r1.19 -r1.20 src/usr.bin/audio/ctl/audioctl.1
> cvs rdiff -u -r1.40 -r1.41 src/usr.bin/audio/ctl/ctl.c
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
> 

--
J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)