re: CVS commit: src/sys/sys

2017-01-05 Thread matthew green
"Paul Goyette" writes:
> Module Name:  src
> Committed By: pgoyette
> Date: Thu Jan  5 22:51:15 UTC 2017
> 
> Modified Files:
>   src/sys/sys: time.h
> 
> Log Message:
> /home/paul/time.msg

interesting!


Re: CVS commit: src/sys/sys

2017-01-05 Thread Christos Zoulas
In article <20170105232440.032b1f...@cvs.netbsd.org>,
Paul Goyette  wrote:
>-=-=-=-=-=-
>
>Module Name:   src
>Committed By:  pgoyette
>Date:  Thu Jan  5 23:24:39 UTC 2017
>
>Modified Files:
>   src/sys/sys: time.h
>
>Log Message:
>Define macros for the time conversion magic numbers.

Since the macros are already cast to uint64_t the second cast is a no-op.

christos



Re: CVS commit: src/sys/sys

2017-01-05 Thread Paul Goyette

On Thu, 5 Jan 2017, Christos Zoulas wrote:


In article <20170105225115.78e7df...@cvs.netbsd.org>,
Paul Goyette  wrote:

-=-=-=-=-=-

Module Name:src
Committed By:   pgoyette
Date:   Thu Jan  5 22:51:15 UTC 2017

Modified Files:
src/sys/sys: time.h

Log Message:
/home/paul/time.msg



Perhaps #define some BINTIME_SCALE_{M,U,N}S constants since they are repeated
in the code?


Sure - sounds like a good idea to me!


+--+--++
| Paul Goyette | PGP Key fingerprint: | E-mail addresses:  |
| (Retired)| FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd.org |
+--+--++


Re: CVS commit: src/sys/sys

2017-01-05 Thread Christos Zoulas
In article <20170105225115.78e7df...@cvs.netbsd.org>,
Paul Goyette  wrote:
>-=-=-=-=-=-
>
>Module Name:   src
>Committed By:  pgoyette
>Date:  Thu Jan  5 22:51:15 UTC 2017
>
>Modified Files:
>   src/sys/sys: time.h
>
>Log Message:
>/home/paul/time.msg
>

Perhaps #define some BINTIME_SCALE_{M,U,N}S constants since they are repeated
in the code?

christos