Re: CVS commit: src/sys/netinet

2017-01-16 Thread Christos Zoulas 
On Jan 16,  8:28pm, r...@marples.name (Roy Marples) wrote:
-- Subject: Re: CVS commit: src/sys/netinet

| So we should do the same for nd6log yes?

I would leave it as it is now because:
1. It is not optional
2. Sometimes takes up to 3 buffers
3. It will churn a lot of code.

christos

Re: CVS commit: src/sys/netinet

2017-01-16 Thread Christos Zoulas 
On Jan 16,  8:28pm, r...@marples.name (Roy Marples) wrote:
-- Subject: Re: CVS commit: src/sys/netinet

| On 16/01/2017 15:14, Christos Zoulas wrote:
| > Module Name:src
| > Committed By:   christos
| > Date:   Mon Jan 16 15:14:16 UTC 2017
| >
| > Modified Files:
| > src/sys/netinet: if_arp.c in_var.h ip_output.c
| >
| > Log Message:
| > rename arplog -> ARPLOG to make it clear that it is a macro and tuck-in the
| > buffer used for address formatting.
| 
| So we should do the same for nd6log yes?

Probably.

christos

Re: CVS commit: src/sys/netinet

2017-01-16 Thread Roy Marples 

On 16/01/2017 15:14, Christos Zoulas wrote:

Module Name:src
Committed By:   christos
Date:   Mon Jan 16 15:14:16 UTC 2017

Modified Files:
src/sys/netinet: if_arp.c in_var.h ip_output.c

Log Message:
rename arplog -> ARPLOG to make it clear that it is a macro and tuck-in the
buffer used for address formatting.


So we should do the same for nd6log yes?

Roy

Re: CVS commit: src/sys

2017-01-16 Thread Ryo Shimizu 

>Yes, and IN6_PRINT(buf, a) does (in6_print(buf, sizeof(buf), a), buf)
>for that exact reason.

Oh! I understand. thanks your cleanup.

--
ryo shimizu

Re: CVS commit: src/sys

2017-01-16 Thread Christos Zoulas 
On Jan 17,  2:06am, r...@nerv.org (Ryo Shimizu) wrote:
-- Subject: Re: CVS commit: src/sys

| >ip6_sprintf -> IN6_PRINT so that we pass the size.
| 
| ip6_sprintf() returns char *, but in6_print() returns int.
| We cannot use in6_print() for log("%s", ...)

Yes, and IN6_PRINT(buf, a) does (in6_print(buf, sizeof(buf), a), buf)
for that exact reason.

christos

Re: CVS commit: src/sys

2017-01-16 Thread Ryo Shimizu 

>Module Name:   src
>Committed By:  christos
>Date:  Mon Jan 16 15:44:47 UTC 2017
>
>Modified Files:
>   src/sys/net: if_llatbl.c if_spppsubr.c
>   src/sys/netinet: dccp_usrreq.c ip_carp.c sctp_asconf.c sctputil.c
>   src/sys/netinet6: icmp6.c in6.c in6_gif.c in6_src.c in6_var.h
>   ip6_forward.c ip6_input.c ip6_mroute.c ip6_output.c mld6.c nd6.c
>   nd6_nbr.c nd6_rtr.c scope6.c
>   src/sys/netipsec: ipsec.c
>
>Log Message:
>ip6_sprintf -> IN6_PRINT so that we pass the size.

ip6_sprintf() returns char *, but in6_print() returns int.
We cannot use in6_print() for log("%s", ...)

--
ryo shimizu

Re: CVS commit: src/etc

2017-01-16 Thread Christos Zoulas 
In article <20170116093926.99ca3f...@cvs.netbsd.org>,
Hauke Fath  wrote:
>-=-=-=-=-=-
>
>Module Name:   src
>Committed By:  hauke
>Date:  Mon Jan 16 09:39:26 UTC 2017
>
>Modified Files:
>   src/etc: protocols
>
>Log Message:
>Add carp as an alias for vrrp - after all, we do not ship vrrp, but we
>do ship carp(4).
>
>Restore the pfsync entry that was added with 1.20, then wiped out by
>the 1.21 import. Please merge any wholesale imports properly.
>
>Remove http://www.sethwklein.net/projects/iana-etc/ which 404s.

This is not how this used to work; you need to add those entries to the
local portion. If that does not work, we need to figure out how to
merge them automatically.

christos