Re: CVS commit: src/tests/lib/libm
> Date: Wed, 26 Jul 2017 00:31:48 +0300 > From: Valery Ushakov > > On Tue, Jul 25, 2017 at 21:29:33 +, co...@sdf.org wrote: > > On Tue, Jul 25, 2017 at 09:26:56PM +, Valeriy E. Ushakov wrote: > > > Revert previous as it breaks at least sparc and hpcsh builds. > > > nearbyint() is not included in libm on all platforms. > > > > The intention was to find which platforms do not install it and change > > them to install it > > You can do that in your tree, not in the public repo. I suggested to he@ that he commit this so we can quickly find which platforms have obviously broken libm, since nobody at the time had the resources to try every platform locally. If you know about sparc and/or hpcsh, can you fix them by adding the right source file in the appropriate place in the libm Makefile? > Date: Wed, 26 Jul 2017 05:32:42 +0700 > From: Robert Elz > > coypu - an alternative would be to make a test that (when run as a test, > rather than when being built) attempts to compile code to use whatever > interface that is, so that the test fails if the interface doesn't exist, > rather than actually breaking the build, if the test cannot be compiled and > installed. This would be needless effort. It is a bug that the symbols are missing. We were shipping a busted libm.
Re: CVS commit: src/tests/lib/libm
Date:Wed, 26 Jul 2017 00:17:49 + From:co...@sdf.org Message-ID: <20170726001748.gd3...@sdf.org> | And it adds an actual test for functionality, to be sure we weren't | wrong in adding the function for that arch. That's useful, but you can get that if you compile, and run, the program as part of the test, rather than compiling as part of the build. And of course. if on all of those less commonly used architectures where no-one (apparently) ever runs tests, you don't get that benefit. kre
Re: CVS commit: src/tests/lib/libm
There is no other way to find and fix these problems. nobody runs sh3 tests, and non-x86 ports have so many failures that it's going to be drowned in the noise. And it adds an actual test for functionality, to be sure we weren't wrong in adding the function for that arch. This is causing packages to fail in a way that cannot be fixed in an existing release.
Re: CVS commit: src/tests/lib/libm
Date:Tue, 25 Jul 2017 22:43:18 + From:co...@sdf.org Message-ID: <20170725224318.ga3...@sdf.org> | It's a minor inconvenience to fix a critical bug. Breaking builds is not a minor inconvenience, it can cause all progress to halt for developers who keep their tree up to date all the time. While build breakages cannot always be avoided, you can generally expect someone to "fix" a breakage you have caused if you don't correct it within a few hours - where "fix" might mean reverting your change, or doing almost anything else to allow the build to succeed. If I had been affected by this, my solution would probably have been to make a dummy function in libm so the program would link, and perhaps even to look in the test, see what result was expected, and simply return that as a constant, so the test "works" as well. What's more, exotic interfaces in libm are, almost by definition, not critical bugs. Stuff that should be supported, should be supported, but if 99% of the applications will work fine without it, then adding it is hardly anything time critical. kre
Re: CVS commit: src/tests/lib/libm
On Wed, Jul 26, 2017 at 05:32:42AM +0700, Robert Elz wrote: > Date:Wed, 26 Jul 2017 00:31:48 +0300 > From:Valery Ushakov > Message-ID: <20170725213148.ga16...@pony.stderr.spb.ru> > > | You can do that in your tree, not in the public repo. > > coypu - an alternative would be to make a test that (when run as a test, > rather than when being built) attempts to compile code to use whatever > interface that is, so that the test fails if the interface doesn't exist, > rather than actually breaking the build, if the test cannot be compiled and > installed. It's a minor inconvenience to fix a critical bug. we have a lot more of those, as libm's makefile is a trainwreck.
Re: CVS commit: src/tests/lib/libm
Date:Wed, 26 Jul 2017 00:31:48 +0300 From:Valery Ushakov Message-ID: <20170725213148.ga16...@pony.stderr.spb.ru> | You can do that in your tree, not in the public repo. coypu - an alternative would be to make a test that (when run as a test, rather than when being built) attempts to compile code to use whatever interface that is, so that the test fails if the interface doesn't exist, rather than actually breaking the build, if the test cannot be compiled and installed. kre
Re: CVS commit: src/tests/lib/libm
On Tue, Jul 25, 2017 at 21:29:33 +, co...@sdf.org wrote: > On Tue, Jul 25, 2017 at 09:26:56PM +, Valeriy E. Ushakov wrote: > > Module Name:src > > Committed By: uwe > > Date: Tue Jul 25 21:26:56 UTC 2017 > > > > Modified Files: > > src/tests/lib/libm: t_fe_round.c > > > > Log Message: > > Revert previous as it breaks at least sparc and hpcsh builds. > > nearbyint() is not included in libm on all platforms. > > The intention was to find which platforms do not install it and change > them to install it You can do that in your tree, not in the public repo. -uwe
Re: CVS commit: src/tests/lib/libm
On Tue, Jul 25, 2017 at 09:26:56PM +, Valeriy E. Ushakov wrote: > Module Name: src > Committed By: uwe > Date: Tue Jul 25 21:26:56 UTC 2017 > > Modified Files: > src/tests/lib/libm: t_fe_round.c > > Log Message: > Revert previous as it breaks at least sparc and hpcsh builds. > nearbyint() is not included in libm on all platforms. The intention was to find which platforms do not install it and change them to install it
Re: CVS commit: src/sys/rump/librump/rumpkern
On Tue, Jul 25, 2017 at 9:08 PM, Paul Goyette wrote: > pullup to 8.0? Yes, I'll do. ozaki-r > > > On Tue, 25 Jul 2017, Ryota Ozaki wrote: > >> Module Name:src >> Committed By: ozaki-r >> Date: Tue Jul 25 05:01:25 UTC 2017 >> >> Modified Files: >> src/sys/rump/librump/rumpkern: Makefile.rumpkern >> >> Log Message: >> Add localcount to rump kernels >> >> >> To generate a diff of this commit: >> cvs rdiff -u -r1.169 -r1.170 >> src/sys/rump/librump/rumpkern/Makefile.rumpkern >> >> Please note that diffs are not public domain; they are subject to the >> copyright notices on the relevant files. >> >> >> !DSPAM:5976d0ab241195299513085! >> >> > > +--+--++ > | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | > | (Retired)| FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com | > | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org | > +--+--++
Re: CVS commit: src/sys/rump/librump/rumpkern
pullup to 8.0? On Tue, 25 Jul 2017, Ryota Ozaki wrote: Module Name:src Committed By: ozaki-r Date: Tue Jul 25 05:01:25 UTC 2017 Modified Files: src/sys/rump/librump/rumpkern: Makefile.rumpkern Log Message: Add localcount to rump kernels To generate a diff of this commit: cvs rdiff -u -r1.169 -r1.170 src/sys/rump/librump/rumpkern/Makefile.rumpkern Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. !DSPAM:5976d0ab241195299513085! +--+--++ | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | (Retired)| FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com | | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org | +--+--++
