IEEE1394
On Tue, Feb 13, 2018 at 10:47:41AM +, Maxime Villard wrote:
> + if (ntohs(ar->ar_hrd) == ARPHRD_IEEE1394) {
> + goto out;
> + }
> +
What makes IEEE-1394 so bad it needs a blacklist rather than a
whitelist? there's some other really weird options for ar_hrd
Re: IEEE1394
I'm reading the rest of the commits now :-) because it doesn't have ar_tha, ok!
Re: CVS commit: src/sys/netinet
This must be revisited - IKE/racoon breaks with 1.240. racoon listens on port 500. packets for port 500 arrive at the interface (tcpdump sees them), but racoon NEVER receives any packets for port 500 (debug/ktuss sees nothing). Frank On 02/10/18 09:17, Maxime Villard wrote: Module Name:src Committed By: maxv Date: Sat Feb 10 08:17:00 UTC 2018 Modified Files: src/sys/netinet: udp_usrreq.c Log Message: If the socket wants a ESP-over-UDP packet, and the packet is incorrect, stop processing it instead of giving it to udp4_sendup. It just doesn't make any sense not to drop it. I was already telling myself this the other day when I visited this place, but I just saw PR/36782 (11 years old) that suggests the exact same thing, so fix it. Now, udp4_espinudp always frees the mbuf, and is made void. The packet is not processed any further afterwards. To generate a diff of this commit: cvs rdiff -u -r1.239 -r1.240 src/sys/netinet/udp_usrreq.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src/sys/netinet6
m...@netbsd.org wrote: >Module Name:src >Committed By: maxv >Date: Tue Jan 30 15:54:03 UTC 2018 > >Modified Files: >src/sys/netinet6: in6.h ip6_input.c ip6_var.h > >Log Message: >Style, localify, remove dead code, and fix typos. No functional change. Please could we make ip6_nexthdr() global again ? It will be used by MobileIPv6. Robert Swindells
Re: CVS commit: src/sys/netinet
I've reverted the change, I'll re-investigate this later. Maxime Le 13/02/2018 à 18:40, Frank Kardel a écrit : This must be revisited - IKE/racoon breaks with 1.240. racoon listens on port 500. packets for port 500 arrive at the interface (tcpdump sees them), but racoon NEVER receives any packets for port 500 (debug/ktuss sees nothing). Frank On 02/10/18 09:17, Maxime Villard wrote: Module Name:src Committed By:maxv Date:Sat Feb 10 08:17:00 UTC 2018 Modified Files: src/sys/netinet: udp_usrreq.c Log Message: If the socket wants a ESP-over-UDP packet, and the packet is incorrect, stop processing it instead of giving it to udp4_sendup. It just doesn't make any sense not to drop it. I was already telling myself this the other day when I visited this place, but I just saw PR/36782 (11 years old) that suggests the exact same thing, so fix it. Now, udp4_espinudp always frees the mbuf, and is made void. The packet is not processed any further afterwards. To generate a diff of this commit: cvs rdiff -u -r1.239 -r1.240 src/sys/netinet/udp_usrreq.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
