Re: CVS commit: src/sys/arch

2018-02-17 Thread Joerg Sonnenberger 
On Sat, Feb 17, 2018 at 10:31:26PM +0100, Maxime Villard wrote:
>  * Rename Xintr_legacyNN -> Xintr_i8259NN, which is even more confusing,
>because the name of the controller ends with numbers, and we are
>concatenating more numbers.

I'd add one more underscore here, but otherwise that sounds like the
better approach.

Joerg

Re: CVS commit: src/sys/arch

2018-02-17 Thread Maxime Villard 

Le 17/02/2018 à 21:56, Joerg Sonnenberger a écrit :

On Sat, Feb 17, 2018 at 06:51:53PM +, Maxime Villard wrote:

Module Name:src
Committed By:   maxv
Date:   Sat Feb 17 18:51:53 UTC 2018

Modified Files:
src/sys/arch/amd64/amd64: vector.S
src/sys/arch/i386/i386: vector.S
src/sys/arch/x86/include: intr.h
src/sys/arch/x86/x86: i8259.c intr.c
src/sys/arch/xen/x86: pintr.c

Log Message:
Rename i8259_stubs -> legacy_stubs. We will want the entries to have the
same name, eg:

legacy_stubs
-> Xintr_legacy0, Xrecurse_legacy0, Xresume_legacy0
-> Xintr_legacy1, Xrecurse_legacy1, Xresume_legacy1
...


I find this change confusing. i8259 is pretty explicit on what it means.
legacy is not clear at all. Is non-MSI(X) legacy?


I couldn't come up with something better. There are two choices:

 * Rename i8259_stubs -> legacy_stubs. We lose i8259, so the name is not
   explicit.

 * Rename Xintr_legacyNN -> Xintr_i8259NN, which is even more confusing,
   because the name of the controller ends with numbers, and we are
   concatenating more numbers.

Maxime

Re: CVS commit: src/sys/arch

2018-02-17 Thread Kamil Rytarowski 
On 17.02.2018 21:56, Joerg Sonnenberger wrote:
> On Sat, Feb 17, 2018 at 06:51:53PM +, Maxime Villard wrote:
>> Module Name: src
>> Committed By:maxv
>> Date:Sat Feb 17 18:51:53 UTC 2018
>>
>> Modified Files:
>>  src/sys/arch/amd64/amd64: vector.S
>>  src/sys/arch/i386/i386: vector.S
>>  src/sys/arch/x86/include: intr.h
>>  src/sys/arch/x86/x86: i8259.c intr.c
>>  src/sys/arch/xen/x86: pintr.c
>>
>> Log Message:
>> Rename i8259_stubs -> legacy_stubs. We will want the entries to have the
>> same name, eg:
>>
>>  legacy_stubs
>>  -> Xintr_legacy0, Xrecurse_legacy0, Xresume_legacy0
>>  -> Xintr_legacy1, Xrecurse_legacy1, Xresume_legacy1
>>  ...
> 
> I find this change confusing. i8259 is pretty explicit on what it means.
> legacy is not clear at all. Is non-MSI(X) legacy?
> 
> Joerg
> 

Personally, I'm familiar with the 'legacy' wording. i8259 might be
explicit but at least from my perspective it's unused.



signature.asc
Description: OpenPGP digital signature

Re: CVS commit: src/sys/arch

2018-02-17 Thread Joerg Sonnenberger 
On Sat, Feb 17, 2018 at 06:51:53PM +, Maxime Villard wrote:
> Module Name:  src
> Committed By: maxv
> Date: Sat Feb 17 18:51:53 UTC 2018
> 
> Modified Files:
>   src/sys/arch/amd64/amd64: vector.S
>   src/sys/arch/i386/i386: vector.S
>   src/sys/arch/x86/include: intr.h
>   src/sys/arch/x86/x86: i8259.c intr.c
>   src/sys/arch/xen/x86: pintr.c
> 
> Log Message:
> Rename i8259_stubs -> legacy_stubs. We will want the entries to have the
> same name, eg:
> 
>   legacy_stubs
>   -> Xintr_legacy0, Xrecurse_legacy0, Xresume_legacy0
>   -> Xintr_legacy1, Xrecurse_legacy1, Xresume_legacy1
>   ...

I find this change confusing. i8259 is pretty explicit on what it means.
legacy is not clear at all. Is non-MSI(X) legacy?

Joerg

Re: CVS commit: src/sys/modules/pf

2018-02-17 Thread Joerg Sonnenberger 
On Sat, Feb 17, 2018 at 08:14:37AM +1100, matthew green wrote:
> "Joerg Sonnenberger" writes:
> > Module Name:src
> > Committed By:   joerg
> > Date:   Mon Feb 12 22:18:36 UTC 2018
> > 
> > Modified Files:
> > src/sys/modules/pf: Makefile
> > 
> > Log Message:
> > Simplify and make the GCC check more precise at the same time.
> 
> ! .if ${HAVE_GCC:U0} == "6"
> 
> FWIW, i usually to write these as ">= 6", as these sorts of
> problems tend to not disappear with a newer GCC.

Depends, sometimes they do, sometimes they don't. As least in the past,
we didn't necessarily use good numeric versions either, so the patterns
were more complicated.

Joerg

Re: CVS commit: src/share/man/man4

2018-02-17 Thread Christos Zoulas 
In article <20180217011307.7ca55f...@cvs.netbsd.org>,
Sevan Janiyan  wrote:
>-=-=-=-=-=-
>
>Module Name:   src
>Committed By:  sevan
>Date:  Sat Feb 17 01:13:07 UTC 2018
>
>Modified Files:
>   src/share/man/man4: ddb.4
>
>Log Message:
>document dumpstack variable.
>Sort built-in variables alphabetically.

This needs to be documented in sysctl.7 too.

christos

Re: CVS commit: src/share/man/man4

2018-02-17 Thread Christos Zoulas 
In article <20180217021101.1123ef...@cvs.netbsd.org>,
Sevan Janiyan  wrote:
>-=-=-=-=-=-
>
>Module Name:   src
>Committed By:  sevan
>Date:  Sat Feb 17 02:11:00 UTC 2018
>
>Modified Files:
>   src/share/man/man4: options.4
>
>Log Message:
>Remove mention of DDB_ONPANIC=2, ddb.dumpstack which is enabled by
>default now handles back traces on panic.

This is still true, right? Why remove it?

christos