Re: Merge majors.{arm32,aarch64} into single file (Re: CVS commit: src/sys/arch/evbarm/conf)
> On Aug 18, 2018, at 5:02 PM, Rin Okuyama wrote: > > (1) rename majors.arm32 to majors.arm > (2) remove majors.aarch64 > (3) make everyone include majors.arm > > I will commit if there's no objection. Correct. Thank you for making this change. -- thorpej
Re: CVS commit: src/lib/libc/arch/aarch64/softfloat
On Sat, Aug 18, 2018 at 07:11:40PM +0900, Ryo Shimizu wrote:
>
> >On Sat, Aug 11, 2018 at 10:06:41AM +, Ryo Shimizu wrote:
> >> Module Name: src
> >> Committed By: ryo
> >> Date: Sat Aug 11 10:06:41 UTC 2018
> >>
> >> Modified Files:
> >>src/lib/libc/arch/aarch64/softfloat: qp.c
> >>
> >> Log Message:
> >> fix multiple definition of __{ge,lt,gt,le,eq,ne,unordt}tf2 in libc and
> >> libgcc.
> >> this fixes the ATF call_once_static, call_once2_static, cxxruntime_static,
> >> static_destructor_static.
>
>
> >This seems just wrong. libgcc shouldn't provide them IMO.
> >Side question, this likely should be replaced with comparetf2.c and
> >friends in libc/compiler_rt/Makefile.
>
> s/libgcc/libc/ ?
>
> I see. then, is it enough to just remove __{ge,lt,gt,le,eq,ne,unordt}tf2 from
> libc?
> currently, clang seems to link libgcc.
libc should be standalone going forward. The libgcc(_s) dependency
should IMO be strongly considered a legacy-only problem and we shouldn't
extend that to new architectures.
That said, I think the main reason this shows up at all is because the
qp.c variant is all-in-one, unlike the code in compiler-rt.
Joerg
Re: Merge majors.{arm32,aarch64} into single file (Re: CVS commit: src/sys/arch/evbarm/conf)
In article <27877.1534674...@splode.eterna.com.au>, matthew green wrote: >> OK. I will leave it as is for now. Please let me know if you >> remember the problems. > >try, and see? :-) > >if nothing else, please make them the same now, and add large >SHOUTING COMMENTS at the top to keep them in sync. Yes, please make them the same and whatever break we will fix. christos
re: Merge majors.{arm32,aarch64} into single file (Re: CVS commit: src/sys/arch/evbarm/conf)
> OK. I will leave it as is for now. Please let me know if you > remember the problems. try, and see? :-) if nothing else, please make them the same now, and add large SHOUTING COMMENTS at the top to keep them in sync. thanks. .mrg.
Re: Merge majors.{arm32,aarch64} into single file (Re: CVS commit: src/sys/arch/evbarm/conf)
On 2018/08/19 14:33, Nick Hudson wrote: ... On 19/08/2018 01:02, Rin Okuyama wrote: It seems harmless to add these devices in majors.aarch64. Therefore, I propose: (1) rename majors.arm32 to majors.arm (2) remove majors.aarch64 (3) make everyone include majors.arm I will commit if there's no objection. ... I support the goal of a single majors file for both arm and aarch64, but when I tried to do this I found problems in MAKEDEV generation or similar. I forget the exact details. OK. I will leave it as is for now. Please let me know if you remember the problems. Thanks, rin
