Re: CVS commit: src/sys/arch
On Mon, Nov 19, 2018 at 10:45:32PM +0700, Robert Elz wrote: > | This also applies to the original commit which broke the build ;-) > > In fairness, as it was, it did work on amd64, just not on i386. Asking > developers to test build every possible port just in case would be a > bit much I think. If the list of possibly affected ports is small, I don't think it is asking too much. Otherwise at least keep an eye on the auto-build results and fix quickly... Martin
Re: CVS commit: src/sys/arch
Date:Mon, 19 Nov 2018 14:46:53 +0100 From:Martin Husemann Message-ID: <20181119134653.ga23...@mail.duskware.de> | > Let us stop committing untested codes in order to just fix build. Yes, sorry about that, I should have tested that one. | This also applies to the original commit which broke the build ;-) In fairness, as it was, it did work on amd64, just not on i386. Asking developers to test build every possible port just in case would be a bit much I think. kre
Re: CVS commit: src/sys/arch
On Mon, Nov 19, 2018 at 10:40:38PM +0900, Rin Okuyama wrote: > > - ci->ci_xen_clockf_usermode = USERMODE(regs->if_tf.tf_cs); > > - ci->ci_xen_clockf_pc = regs->if_tf.tf_rip; > > + ci->ci_xen_clockf_usermode = USERMODE(regs->_INTRFRAME_CS); > > + ci->ci_xen_clockf_pc = regs->_INTRFRAME_IP; > > Let us stop committing untested codes in order to just fix build. This also applies to the original commit which broke the build ;-) Martin
Re: CVS commit: src/sys/arch
On 2018/11/19 19:05, Robert Elz wrote: Module Name:src Committed By: kre Date: Mon Nov 19 10:05:09 UTC 2018 Modified Files: src/sys/arch/amd64/include: frame.h src/sys/arch/i386/include: frame.h src/sys/arch/xen/x86: hypervisor_machdep.c Log Message: Hide differences between i386 and amd64 interrupt frames so XEN does not need to know there is one. Hopefully unbreak i386 build. _INTRFRAME_IP and _CS are reversed for amd64: Index: src/sys/arch/amd64/include/frame.h diff -u src/sys/arch/amd64/include/frame.h:1.18 src/sys/arch/amd64/include/frame.h:1.19 --- src/sys/arch/amd64/include/frame.h:1.18 Wed Jun 14 00:40:05 2017 +++ src/sys/arch/amd64/include/frame.h Mon Nov 19 10:05:09 2018 ... +#ifdef XEN +/* + * Need arch independany way to access IP and CS from intrframe + */ +#define_INTRFRAME_IP if_tf.tf_cs +#define_INTRFRAME_CS if_tf.tf_rip +#endif Index: src/sys/arch/xen/x86/hypervisor_machdep.c diff -u src/sys/arch/xen/x86/hypervisor_machdep.c:1.32 src/sys/arch/xen/x86/hypervisor_machdep.c:1.33 --- src/sys/arch/xen/x86/hypervisor_machdep.c:1.32 Sun Nov 18 23:50:48 2018 +++ src/sys/arch/xen/x86/hypervisor_machdep.c Mon Nov 19 10:05:09 2018 ... - ci->ci_xen_clockf_usermode = USERMODE(regs->if_tf.tf_cs); - ci->ci_xen_clockf_pc = regs->if_tf.tf_rip; + ci->ci_xen_clockf_usermode = USERMODE(regs->_INTRFRAME_CS); + ci->ci_xen_clockf_pc = regs->_INTRFRAME_IP; Let us stop committing untested codes in order to just fix build. Compile-time errors are much better than bugs not detectable by compilers. Thanks, rin
Re: CVS commit: src/external/apache2/mDNSResponder/dist/mDNSPosix
Date:Mon, 19 Nov 2018 12:25:23 + From:Roy Marples Message-ID: <9b4f1054-1005-eac3-cb12-af6227d36...@marples.name> | I can plug a usb stick in later which mdnsd could work with, so xtos's | change is fine. I didn't ever doubt that the change would work, just wondered if there might be a better way. Christos' reply to my message convinced me that the way it is now is fine, even though the code as written is basically nonsense (but harmless nonsense.) kre
Re: CVS commit: src/external/apache2/mDNSResponder/dist/mDNSPosix
On 19/11/2018 10:42, Robert Elz wrote: Date:Mon, 19 Nov 2018 03:14:28 -0500 From:"Christos Zoulas" Message-ID: <20181119081428.def1cf...@cvs.netbsd.org> | Modified Files: |src/external/apache2/mDNSResponder/dist/mDNSPosix: mDNSPosix.c | It is not an error if we did not find any IPv4 interfaces. It could | be the case we never have V4 interfaces (in a V6 system) so this | is bogus. Rather than just removing the test, a better fix would be to move it to after the v6 interfaces are added?That way it really would be testing if there are no interfaces at all (in which case this code is not going to accomplish much). My pinebook only has the loopback interface when it boots and mdnsd bails accordingly. I can plug a usb stick in later which mdnsd could work with, so xtos's change is fine. Roy
Re: CVS commit: src/sys/external/bsd/drm2/include/linux/regulator
Date:Mon, 19 Nov 2018 11:29:27 + From:m...@netbsd.org Message-ID: <20181119112927.ga1...@homeworld.netbsd.org> | The linux includes are local shims on NetBSD. Ah, OK. | As I understand it, I can't use userland headers in the kernel. What's | the rule for that? The rule is as you said it ... I didn't even notice it was a kernel file... Leave it as you have it. Apologies for butting in. kre
Re: CVS commit: src/sys/external/bsd/drm2/include/linux/regulator
On Mon, Nov 19, 2018 at 06:24:12PM +0700, Robert Elz wrote: > Date:Mon, 19 Nov 2018 10:48:59 + > From:"Maya Rashish" > Message-ID: <20181119104859.36f32f...@cvs.netbsd.org> > > | Module Name: src > | Committed By: maya > | Date: Mon Nov 19 10:48:59 UTC 2018 > | > | Modified Files: > | src/sys/external/bsd/drm2/include/linux/regulator: consumer.h > | > | Log Message: > | include machine/limits.h for INT_MAX > > For this one the conventional include (which could be submitted back > to wherever the linux version comes from) would be > > kre > The linux includes are local shims on NetBSD. As I understand it, I can't use userland headers in the kernel. What's the rule for that?
Re: CVS commit: src/sys/external/bsd/drm2/include/linux/regulator
Date:Mon, 19 Nov 2018 10:48:59 + From:"Maya Rashish" Message-ID: <20181119104859.36f32f...@cvs.netbsd.org> | Module Name:src | Committed By: maya | Date: Mon Nov 19 10:48:59 UTC 2018 | | Modified Files: | src/sys/external/bsd/drm2/include/linux/regulator: consumer.h | | Log Message: | include machine/limits.h for INT_MAX For this one the conventional include (which could be submitted back to wherever the linux version comes from) would be kre
Re: CVS commit: src/external/apache2/mDNSResponder/dist/mDNSPosix
The code can handle having no interfaces, because interfaces can be configured in the future. The problem is that if this function returns an error (ie there were no configured interfaces during startup) the daemon will exit, and this is not desirable. Restructuring the code too much will result in merge pain in the future... We should find who maintains that code and contribute all the bug fixes... christos > On Nov 19, 2018, at 12:42 PM, Robert Elz wrote: > >Date:Mon, 19 Nov 2018 03:14:28 -0500 >From:"Christos Zoulas" >Message-ID: <20181119081428.def1cf...@cvs.netbsd.org> > > | Modified Files: > |src/external/apache2/mDNSResponder/dist/mDNSPosix: mDNSPosix.c > > > | It is not an error if we did not find any IPv4 interfaces. It could > | be the case we never have V4 interfaces (in a V6 system) so this > | is bogus. > > Rather than just removing the test, a better fix would be to move it > to after the v6 interfaces are added?That way it really would be > testing if there are no interfaces at all (in which case this code is > not going to accomplish much). > > Otherwise, the "err" variable should just be removed, and the function > made to return 0 as "err" is init'd to 0, tested a couple of times, and then > returned (but never updated) as the code stands now. > > kre
Re: CVS commit: src/external/apache2/mDNSResponder/dist/mDNSPosix
Date:Mon, 19 Nov 2018 03:14:28 -0500 From:"Christos Zoulas" Message-ID: <20181119081428.def1cf...@cvs.netbsd.org> | Modified Files: | src/external/apache2/mDNSResponder/dist/mDNSPosix: mDNSPosix.c | It is not an error if we did not find any IPv4 interfaces. It could | be the case we never have V4 interfaces (in a V6 system) so this | is bogus. Rather than just removing the test, a better fix would be to move it to after the v6 interfaces are added?That way it really would be testing if there are no interfaces at all (in which case this code is not going to accomplish much). Otherwise, the "err" variable should just be removed, and the function made to return 0 as "err" is init'd to 0, tested a couple of times, and then returned (but never updated) as the code stands now. kre
Re: CVS commit: src/sys/dev
Shouldn't this be instead? IMO, pulling in implicitly is generally harmful (there is a lot of namespace pollution there...) > On Nov 19, 2018, at 9:23 AM, Maya Rashish wrote: > > Module Name: src > Committed By: maya > Date: Mon Nov 19 09:23:05 UTC 2018 > > Modified Files: > src/sys/dev: audio_dai.h > > Log Message: > include sys/param.h for EINVAL used in this header. > > (Make it more standalone) > > > To generate a diff of this commit: > cvs rdiff -u -r1.2 -r1.3 src/sys/dev/audio_dai.h > > Please note that diffs are not public domain; they are subject to the > copyright notices on the relevant files. > -- thorpej
Re: CVS commit: src/external/apache2/mDNSResponder/dist/mDNSPosix
Thanks! This has been bothering me for a while, but I hadn’t had a chance to look at it. -- thorpej Sent from my iPhone. > On Nov 19, 2018, at 8:14 AM, Christos Zoulas wrote: > > Module Name:src > Committed By:christos > Date:Mon Nov 19 08:14:28 UTC 2018 > > Modified Files: >src/external/apache2/mDNSResponder/dist/mDNSPosix: mDNSPosix.c > > Log Message: > It is not an error if we did not find any IPv4 interfaces. It could > be the case we never have V4 interfaces (in a V6 system) so this > is bogus. The code was recently changed to ignore loopback interfaces. > If mdnsd was started too early, this means that no interfaces would > be found (since interfaces down, with no addresses, or tentative > are ignored). I put back the loopback interfaces yesterday to avoid > this error, but this seems like the left hand not knowing what the > right hand does because whoever removed the loopback interfaces > from the list, did not read the 'self discovery' comment and the > special code that deals with loopback in this file. Nevertheless, > I think it is better to ignore the loopback interfaces in the long > run, but it is ok to keep them around since the code is handling > them just fine (and works both with and without them). > > > To generate a diff of this commit: > cvs rdiff -u -r1.15 -r1.16 \ >src/external/apache2/mDNSResponder/dist/mDNSPosix/mDNSPosix.c > > Please note that diffs are not public domain; they are subject to the > copyright notices on the relevant files. >
