Re: CVS commit: src/usr.bin/vmstat

2018-12-13 Thread Sevan Janiyan
On 13/12/2018 04:00, Simon Burge wrote:
> While a bit wordier, I think that accurately describes the behaviour.
> LGTM.

Thanks. I had one other thought which I haven't investigated yet but did
we change behaviour intentionally? My committed change complements the
description of -c
"Repeat the display count times.  The first display is for the time
since a reboot and each subsequent report is for the time period since
the last display.  If no wait interval is specified, the default is 1
second."

The other thing was that prior to my commit, I was testing things on an
i7 and there the run queue doesn't change. When you followed up post
commit, I checked on a uniprocessor system & there the run queue does
register.
I want to explore that too and document further (heads up) aside from
this scenario with the first line.


Sevan


Re: CVS commit: src/sys/net

2018-12-13 Thread Jason Thorpe
Panic seems not optimal.  A rate limited log message at LOG_ERROR seems better.

-- thorpej
Sent from my iPhone.

> On Dec 13, 2018, at 12:54 PM, Rin Okuyama  wrote:
> 
> Module Name:src
> Committed By:rin
> Date:Thu Dec 13 20:54:50 UTC 2018
> 
> Modified Files:
>src/sys/net: ether_sw_offload.c
> 
> Log Message:
> Panic rather than silently dropping packets when TX offload options are
> enabled for unsupported frame types.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.3 -r1.4 src/sys/net/ether_sw_offload.c
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
> 



Re: CVS commit: src/external/bsd/file/lib

2018-12-13 Thread Masanobu SAITOH

Oops, sorry. Wrong mail address.

On 2018/12/13 20:54, Masanobu SAITOH wrote:

  Please pullup the following change to netbsd-8 branch.

On 2018/12/12 15:36, SAITOH Masanobu wrote:

Module Name:    src
Committed By:    msaitoh
Date:    Wed Dec 12 06:36:13 UTC 2018

Modified Files:
src/external/bsd/file/lib: Makefile

Log Message:
  Use DPSRCS for magic.h. OK'd by Christos.


To generate a diff of this commit:
cvs rdiff -u -r1.10 -r1.11 src/external/bsd/file/lib/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



  This change can't apply cleanly to netbsd-8, so use the following diff:

Index: Makefile
===
RCS file: /cvsroot/src/external/bsd/file/lib/Makefile,v
retrieving revision 1.8
diff -u -p -r1.8 Makefile
--- Makefile    10 Feb 2017 18:11:18 -    1.8
+++ Makefile    13 Dec 2018 11:53:40 -
@@ -20,6 +20,7 @@ CPPFLAGS+=-I.
  SRCS=    magic.c apprentice.c softmagic.c ascmagic.c compress.c    \
  is_tar.c readelf.c print.c fsmagic.c apptype.c funcs.c \
  cdf.c readcdf.c cdf_time.c encoding.c der.c
+DPSRCS=    magic.h
  MAN=    libmagic.3
  MLINKS+=    libmagic.3 magic_open.3 \
  libmagic.3 magic_close.3 \
@@ -41,5 +42,3 @@ magic.h:    magic.h.in
  CLEANFILES+=    magic.h

  .include 
-
-${ALLOBJS}:    magic.h





--
---
SAITOH Masanobu (msai...@execsw.org
 msai...@netbsd.org)


Re: CVS commit: src/external/bsd/file/lib

2018-12-13 Thread Masanobu SAITOH

 Please pullup the following change to netbsd-8 branch.

On 2018/12/12 15:36, SAITOH Masanobu wrote:

Module Name:src
Committed By:   msaitoh
Date:   Wed Dec 12 06:36:13 UTC 2018

Modified Files:
src/external/bsd/file/lib: Makefile

Log Message:
  Use DPSRCS for magic.h. OK'd by Christos.


To generate a diff of this commit:
cvs rdiff -u -r1.10 -r1.11 src/external/bsd/file/lib/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



 This change can't apply cleanly to netbsd-8, so use the following diff:

Index: Makefile
===
RCS file: /cvsroot/src/external/bsd/file/lib/Makefile,v
retrieving revision 1.8
diff -u -p -r1.8 Makefile
--- Makefile10 Feb 2017 18:11:18 -  1.8
+++ Makefile13 Dec 2018 11:53:40 -
@@ -20,6 +20,7 @@ CPPFLAGS+=-I.
 SRCS=  magic.c apprentice.c softmagic.c ascmagic.c compress.c  \
is_tar.c readelf.c print.c fsmagic.c apptype.c funcs.c \
cdf.c readcdf.c cdf_time.c encoding.c der.c
+DPSRCS=magic.h
 MAN=   libmagic.3
 MLINKS+=   libmagic.3 magic_open.3 \
libmagic.3 magic_close.3 \
@@ -41,5 +42,3 @@ magic.h:magic.h.in
 CLEANFILES+=   magic.h
 
 .include 

-
-${ALLOBJS}:magic.h


--
---
SAITOH Masanobu (msai...@execsw.org
 msai...@netbsd.org)