Re: CVS commit: src/usr.sbin/sysinst

[Martin Husemann]

On Tue, Feb 26, 2019 at 01:09:35PM +, Joerg Sonnenberger wrote:
> Module Name:  src
> Committed By: joerg
> Date: Tue Feb 26 13:09:35 UTC 2019
> 
> Modified Files:
>   src/usr.sbin/sysinst: run.c
> 
> Log Message:
> Avoid string + int warning.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.7 -r1.8 src/usr.sbin/sysinst/run.c

What compiler warns and what are the exact details that make it warn?
The idiom you used is IMHO extremely ugly, and I would usually rework
it - but since I can't test that will likely break your build again.

I would do: const char thirty_dashes[] = "---..---";
and then const char * dashes = thirty_dashes +  m; addstr(dasches);

Martin

Re: CVS commit: src/sys/dev/usb

[Robert Swindells]

Rin Okuyama  wrote:
>I tested StarTech USB21000S2 with Pine A64+. It works well
>with multiple outstanding transfers. If I understand correctly,
>Pine A64+ and Pinebook have (almost?) same SoC. If so, there
>should be the problem elsewhere than host controller itself.
>
>Robert, could you please test it with powered USB hub when
>you have a time?

I don't own a USB hub, I would not want to have to use one with
the Pinebook.

Re: CVS commit: src/sys/dev/usb

[Rin Okuyama]

Hi,

I tested StarTech USB21000S2 with Pine A64+. It works well
with multiple outstanding transfers. If I understand correctly,
Pine A64+ and Pinebook have (almost?) same SoC. If so, there
should be the problem elsewhere than host controller itself.

Robert, could you please test it with powered USB hub when
you have a time?

Thanks,
rin

On 2019/02/06 21:08, Rin Okuyama wrote:

Sorry for my long silence.

On 2019/01/31 23:20, Robert Swindells wrote:
...

The revision number of my device is "1".

Robert Swindells


Hmm, both of my adapters have same revision of "1":

* StarTech USB21000S2

mue1 at uhub3 port 2
mue1: WS (0x424) USB Gigabit LAN (0x7500), rev 2.00/1.00, addr 10
mue1: LAN7500 id 0x7500 rev 0x1
mue1: Ethernet address 
ukphy1 at mue1 phy 1: OUI 0x00800f, model 0x000e, rev. 12
ukphy1: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, 1000baseT, 
1000baseT-FDX, auto

* Z-TEK ZE582

mue1 at uhub3 port 2
mue1: SMSC (0x424) LAN7500 (0x7500), rev 2.00/1.00, addr 10
mue1: LAN7500 id 0x7500 rev 0x1
mue1: Ethernet address 
ukphy1 at mue1 phy 1: OUI 0x00800f, model 0x000e, rev. 12
ukphy1: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, 1000baseT, 
1000baseT-FDX, auto

Multiple outstanding transfers work for both on RPI3B+ (dwctwo) and
ThinkPad X60 (ehci).

Seems like problems on the host controller of Pinebook...

Thanks,
rin