re: CVS commit: src/share/misc
"Sevan Janiyan" writes: > Module Name: src > Committed By: sevan > Date: Tue May 7 21:14:46 UTC 2019 > > Modified Files: > src/share/misc: acronyms.comp > > Log Message: > TMG this doesn't seem in place in acronyms.comp. .mrg.
Re: CVS commit: src/tools
> On May 7, 2019, at 3:52 PM, Herbert J. Skuhra wrote: > > On Tue, 07 May 2019 12:23:12 +0200, "J. Hannken-Illjes" wrote: >> >> >>> On 7. May 2019, at 12:17, matthew green wrote: >>> Diff is NOT reversed. >>> >>> ah yes, i see. please commit. > > Crossbuilding is still broken. I just checked in a fix for this. > > On FreeBSD 12.0-STABLE (amd64) and Arch GNU/Linux building earmv7hf and amd64 > I get: > > # compile libprop/prop_dictionary.lo > cc -O -I/usr/home/herbert/source/netbsd/src/tools/libprop/../compat > -I/usr/home/herbert/source/netbsd/src/tools/libprop/../../common/include > -I/usr/home/herbert/source/netbsd/src/../build/earmv7hf/tools/include/nbinclude > -DHAVE_NBTOOL_CONFIG_H=1 -D_FILE_OFFSET_BITS=64 > -I/usr/home/herbert/source/netbsd/src/../build/earmv7hf/tools/include > -I/usr/home/herbert/source/netbsd/src/../build/earmv7hf/tools/include/nbinclude > -c -o prop_dictionary.lo.o > /usr/home/herbert/source/netbsd/src/tools/libprop/../../common/lib/libprop/prop_dictionary.c > > /usr/home/herbert/source/netbsd/src/tools/libprop/../../common/lib/libprop/prop_dictionary.c:37:10: > fatal error: 'sys/rbtree.h' file not found > #include > > ^~ > > 1 error generated. > > > *** Failed target: prop_dictionary.lo > *** Failed command: cc -O > -I/usr/home/herbert/source/netbsd/src/tools/libprop/../compat > -I/usr/home/herbert/source/netbsd/src/tools/libprop/../../common/include > -I/usr/home/herbert/source/netbsd/src/../build/earmv7hf/tools/include/nbinclude > -DHAVE_NBTOOL_CONFIG_H=1 -D_FILE_OFFSET_BITS=64 > -I/usr/home/herbert/source/netbsd/src/../build/earmv7hf/tools/include > -I/usr/home/herbert/source/netbsd/src/../build/earmv7hf/tools/include/nbinclude > -c -o prop_dictionary.lo.o > /usr/home/herbert/source/netbsd/src/tools/libprop/../../common/lib/libprop/prop_dictionary.c > > *** Error code 1 > > Stop. > > -- > Herbert -- thorpej
Re: CVS commit: src/sys/kern
I hope the slop makes everyone happy :-) christos
Re: CVS commit: src/sys/kern
Date:Wed, 08 May 2019 06:54:04 +1000 From:matthew green Message-ID: <7543.1557262...@splode.eterna.com.au> | > Log Message: | > Use the max limit (aka maxfiles or the moral equivalent of OPEN_MAX) which | > makes poll(2) align with the Posix documentation (which allows EINVAL if | > nfds > OPEN_MAX). From: Anthony Mallet | | this seems to still miss the case kre was talking about: It does, but there also needs to be a limit somewhere (unless we add more complicated code - which we could do for unusualk cases), In practice soming near this limit is very rare, and as long as we have some documented (and ideally posix approved) behaviour, it should be OK. My only issue currently is that rlimit.max can be reduced as well, so I think we should have a value that we always permit, regardless of that limit (ie: max(rlimit.max, 1000) or something). kre
Re: CVS commit: src/tools
I'll take a look at this this evening. > On May 7, 2019, at 3:52 PM, Herbert J. Skuhra wrote: > > On Tue, 07 May 2019 12:23:12 +0200, "J. Hannken-Illjes" wrote: >> >> >>> On 7. May 2019, at 12:17, matthew green wrote: >>> Diff is NOT reversed. >>> >>> ah yes, i see. please commit. > > Crossbuilding is still broken. > > On FreeBSD 12.0-STABLE (amd64) and Arch GNU/Linux building earmv7hf and amd64 > I get: > > # compile libprop/prop_dictionary.lo > cc -O -I/usr/home/herbert/source/netbsd/src/tools/libprop/../compat > -I/usr/home/herbert/source/netbsd/src/tools/libprop/../../common/include > -I/usr/home/herbert/source/netbsd/src/../build/earmv7hf/tools/include/nbinclude > -DHAVE_NBTOOL_CONFIG_H=1 -D_FILE_OFFSET_BITS=64 > -I/usr/home/herbert/source/netbsd/src/../build/earmv7hf/tools/include > -I/usr/home/herbert/source/netbsd/src/../build/earmv7hf/tools/include/nbinclude > -c -o prop_dictionary.lo.o > /usr/home/herbert/source/netbsd/src/tools/libprop/../../common/lib/libprop/prop_dictionary.c > > /usr/home/herbert/source/netbsd/src/tools/libprop/../../common/lib/libprop/prop_dictionary.c:37:10: > fatal error: 'sys/rbtree.h' file not found > #include > > ^~ > > 1 error generated. > > > *** Failed target: prop_dictionary.lo > *** Failed command: cc -O > -I/usr/home/herbert/source/netbsd/src/tools/libprop/../compat > -I/usr/home/herbert/source/netbsd/src/tools/libprop/../../common/include > -I/usr/home/herbert/source/netbsd/src/../build/earmv7hf/tools/include/nbinclude > -DHAVE_NBTOOL_CONFIG_H=1 -D_FILE_OFFSET_BITS=64 > -I/usr/home/herbert/source/netbsd/src/../build/earmv7hf/tools/include > -I/usr/home/herbert/source/netbsd/src/../build/earmv7hf/tools/include/nbinclude > -c -o prop_dictionary.lo.o > /usr/home/herbert/source/netbsd/src/tools/libprop/../../common/lib/libprop/prop_dictionary.c > > *** Error code 1 > > Stop. > > -- > Herbert -- thorpej
Re: CVS commit: src/tools
On Tue, 07 May 2019 12:23:12 +0200, "J. Hannken-Illjes" wrote: > > > > On 7. May 2019, at 12:17, matthew green wrote: > > > >> Diff is NOT reversed. > > > > ah yes, i see. please commit. Crossbuilding is still broken. On FreeBSD 12.0-STABLE (amd64) and Arch GNU/Linux building earmv7hf and amd64 I get: # compile libprop/prop_dictionary.lo cc -O -I/usr/home/herbert/source/netbsd/src/tools/libprop/../compat -I/usr/home/herbert/source/netbsd/src/tools/libprop/../../common/include -I/usr/home/herbert/source/netbsd/src/../build/earmv7hf/tools/include/nbinclude -DHAVE_NBTOOL_CONFIG_H=1 -D_FILE_OFFSET_BITS=64 -I/usr/home/herbert/source/netbsd/src/../build/earmv7hf/tools/include -I/usr/home/herbert/source/netbsd/src/../build/earmv7hf/tools/include/nbinclude -c -o prop_dictionary.lo.o /usr/home/herbert/source/netbsd/src/tools/libprop/../../common/lib/libprop/prop_dictionary.c /usr/home/herbert/source/netbsd/src/tools/libprop/../../common/lib/libprop/prop_dictionary.c:37:10: fatal error: 'sys/rbtree.h' file not found #include ^~ 1 error generated. *** Failed target: prop_dictionary.lo *** Failed command: cc -O -I/usr/home/herbert/source/netbsd/src/tools/libprop/../compat -I/usr/home/herbert/source/netbsd/src/tools/libprop/../../common/include -I/usr/home/herbert/source/netbsd/src/../build/earmv7hf/tools/include/nbinclude -DHAVE_NBTOOL_CONFIG_H=1 -D_FILE_OFFSET_BITS=64 -I/usr/home/herbert/source/netbsd/src/../build/earmv7hf/tools/include -I/usr/home/herbert/source/netbsd/src/../build/earmv7hf/tools/include/nbinclude -c -o prop_dictionary.lo.o /usr/home/herbert/source/netbsd/src/tools/libprop/../../common/lib/libprop/prop_dictionary.c *** Error code 1 Stop. -- Herbert
re: CVS commit: src/sys/kern
"Christos Zoulas" writes: > Module Name: src > Committed By: christos > Date: Tue May 7 20:10:21 UTC 2019 > > Modified Files: > src/sys/kern: sys_select.c > > Log Message: > Use the max limit (aka maxfiles or the moral equivalent of OPEN_MAX) which > makes poll(2) align with the Posix documentation (which allows EINVAL if > nfds > OPEN_MAX). From: Anthony Mallet this seems to still miss the case kre was talking about: > I also don't believe there's any restriction on including the same > fd more than once (with diffent bits set in events probably) - perhaps > might happen in threaded code when one thread is reading from an fd, > and a diffenent one is writing to it (probably a net connection or tty). i think 1000 slop might be reasonable, particular if we document this as kre also suggested :-) .mrg.
Re: CVS commit: src/tools
> On May 7, 2019, at 12:32 PM, matthew green wrote: > > did you start from a clean *tooldir*? that would be the bit > that matters. if one had an existing tooldir with nbpax in > it, then this problem wouldn't occur. > > that's my only guess to what happened... Yah, that's probably it. -- thorpej
re: CVS commit: src/tools
Jason Thorpe writes: > > > On May 7, 2019, at 3:17 AM, matthew green wrote: > > > >> Diff is NOT reversed. > > > > ah yes, i see. please commit. > > I bootstrapped the whole system 3 or 4 times without having this extra > dependency and didn't see a build failure, so I'm a little confused, but > whatever. > > Thanks for fixing it. did you start from a clean *tooldir*? that would be the bit that matters. if one had an existing tooldir with nbpax in it, then this problem wouldn't occur. that's my only guess to what happened... .mrg.
Re: CVS commit: src/lib/libpthread
Pre-emptively making a thread where people can call this an ugly hack
On Tue, May 07, 2019 at 06:12:54PM +, Maya Rashish wrote:
> Module Name: src
> Committed By: maya
> Date: Tue May 7 18:12:53 UTC 2019
>
> Modified Files:
> src/lib/libpthread: Makefile
>
> Log Message:
> Replace the link command for libpthread.a so that we create a single section
> with all the libpthread symbols in it.
> This makes -lpthread behave like to -Wl,--whole-archive -lpthread.
>
> This avoids a situation where threaded static binaries use some libc thread
> stubs, which are racy.
>
> Fixes PR lib/54001: call_once2_32, call_once2_static test cases failing on
> amd64 since gcc7 import.
>
> Suggested by Jonathan Wakely, thanks!
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.92 -r1.93 src/lib/libpthread/Makefile
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
>
> Modified files:
>
> Index: src/lib/libpthread/Makefile
> diff -u src/lib/libpthread/Makefile:1.92 src/lib/libpthread/Makefile:1.93
> --- src/lib/libpthread/Makefile:1.92 Wed Apr 24 11:43:19 2019
> +++ src/lib/libpthread/Makefile Tue May 7 18:12:53 2019
> @@ -1,4 +1,4 @@
> -#$NetBSD: Makefile,v 1.92 2019/04/24 11:43:19 kamil Exp $
> +#$NetBSD: Makefile,v 1.93 2019/05/07 18:12:53 maya Exp $
> #
>
> NOSANITIZER= # defined
> @@ -269,6 +269,20 @@ MLINKS+= tss.3 tss_set.3
>
> INCS+= threads.h
>
> +# PR lib/54001: create libpthread.a as a single large object, with all the
> +# symbols in one section. ensures that if any libpthread function is used,
> +# you get all of them from libpthread, and not the libc stubs.
> +#
> +# This makes -lpthread equivalent to -Wl,--whole-archive -lpthread
> +
> +__archivebuild: .USE
> + ${_MKTARGET_BUILD}
> + @rm -f ${.TARGET}
> + ${LD} -r -o ${.TARGET}.o `NM=${NM} ${LORDER} ${.ALLSRC:M*o} | ${TSORT}`
> + ${AR} ${_ARFL} ${.TARGET} ${.TARGET}.o
> +
> +CLEANFILES+= ${.TARGET}.o
> +
> .include
>
> .else
>
Re: CVS commit: src/tools
> On May 7, 2019, at 3:17 AM, matthew green wrote: > >> Diff is NOT reversed. > > ah yes, i see. please commit. I bootstrapped the whole system 3 or 4 times without having this extra dependency and didn't see a build failure, so I'm a little confused, but whatever. Thanks for fixing it. -- thorpej
Re: CVS commit: src/tools
> On 7. May 2019, at 12:17, matthew green wrote: > >> Diff is NOT reversed. > > ah yes, i see. please commit. Done. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)
re: CVS commit: src/tools
> Diff is NOT reversed. ah yes, i see. please commit.
Re: CVS commit: src/tools
> On 7. May 2019, at 11:54, matthew green wrote:
>
> reversed patch, but i think you don't need the extra .WAIT step.
>
> it worked for me just before ${TOOLCHAIN_BITS} but you can probably
> put it anywhere in that set.
>
> please commit!
Diff is NOT reversed. My Rev. 1.202 makefile has:
SUBDIR+= grep xz-lib libprop
.if ${TOOLS_BUILDRUMP} == "no"
SUBDIR += .WAIT texinfo \
.WAIT tic \
.WAIT pax \
.WAIT ${TOOLCHAIN_BITS} \
Here libprop needs pax, but pax gets built after it.
--
J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)
re: CVS commit: src/tools
reversed patch, but i think you don't need the extra .WAIT step.
it worked for me just before ${TOOLCHAIN_BITS} but you can probably
put it anywhere in that set.
please commit!
.mrg.
Re: CVS commit: src/tools
> On 7. May 2019, at 06:29, Jason R Thorpe wrote: > > Module Name: src > Committed By: thorpej > Date: Tue May 7 04:29:45 UTC 2019 > > Modified Files: > src/tools: Makefile > Added Files: > src/tools/libprop: Makefile > > Log Message: > Add support for libprop as a host tool library. > > > To generate a diff of this commit: > cvs rdiff -u -r1.201 -r1.202 src/tools/Makefile > cvs rdiff -u -r0 -r1.1 src/tools/libprop/Makefile Looks like libprop needs pax. Is the attached diff ok? -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany) Makefile.diff Description: Binary data
