Re: CVS commit: src/usr.sbin/fstyp
On Sat, Dec 28, 2019, 1:31 AM Tomohiro Kusumi wrote: > 2019年12月28日(土) 5:24 Warner Losh : > > > > > > > > On Fri, Dec 27, 2019 at 12:45 PM Sevan Janiyan > wrote: > >> > >> Hi tkusumi, > >> Thanks for the work you are doing. > >> > >> On 27/12/2019 11:06, Tomohiro Kusumi wrote: > >> > taken-from: FreeBSD > (freebsd/freebsd@b4d7ad9f787e74e712423def67de8bd76f71943a) > >> > >> One minor nit, could you please cite the revision in the svn repo which > >> is the source of truth and not the readonly git mirror, this is in case > >> something happens to the mirror and hashes end up changing in the > future. > > > > > > FreeBSD is planning a conversion to git. > > Yes, that's the reason I'm using Git hash here. > Nowadays I don't use their svn repo at all, so if recording Git hash > is not appropriate, I'll just note "taken-from: FreeBSD" without any > specific revision#. > It's a silly reason. Svn revision numbers will be preserved in the conversion process. Git hashes likely won't so this hash may be unconvertable to anything at all in the future... Warner > It's an open question at the moment what happens to the 'beta' readonly > export we're doing to github. There's a number of technical issues with it > which make using it for our source of truth difficult on an ongoing basis, > so there's a real chance the hashes will change for people just grabbing a > FreeBSD tree... > > > > Warner >
Re: CVS commit: src/usr.sbin/fstyp
On Fri, Dec 27, 2019 at 12:45 PM Sevan Janiyan wrote: > Hi tkusumi, > Thanks for the work you are doing. > > On 27/12/2019 11:06, Tomohiro Kusumi wrote: > > taken-from: FreeBSD > (freebsd/freebsd@b4d7ad9f787e74e712423def67de8bd76f71943a) > > One minor nit, could you please cite the revision in the svn repo which > is the source of truth and not the readonly git mirror, this is in case > something happens to the mirror and hashes end up changing in the future. FreeBSD is planning a conversion to git. It's an open question at the moment what happens to the 'beta' readonly export we're doing to github. There's a number of technical issues with it which make using it for our source of truth difficult on an ongoing basis, so there's a real chance the hashes will change for people just grabbing a FreeBSD tree... Warner
Re: CVS commit: src/usr.sbin/fstyp
2019年12月28日(土) 5:24 Warner Losh : > > > > On Fri, Dec 27, 2019 at 12:45 PM Sevan Janiyan > wrote: >> >> Hi tkusumi, >> Thanks for the work you are doing. >> >> On 27/12/2019 11:06, Tomohiro Kusumi wrote: >> > taken-from: FreeBSD >> > (freebsd/freebsd@b4d7ad9f787e74e712423def67de8bd76f71943a) >> >> One minor nit, could you please cite the revision in the svn repo which >> is the source of truth and not the readonly git mirror, this is in case >> something happens to the mirror and hashes end up changing in the future. > > > FreeBSD is planning a conversion to git. Yes, that's the reason I'm using Git hash here. Nowadays I don't use their svn repo at all, so if recording Git hash is not appropriate, I'll just note "taken-from: FreeBSD" without any specific revision#. > It's an open question at the moment what happens to the 'beta' readonly > export we're doing to github. There's a number of technical issues with it > which make using it for our source of truth difficult on an ongoing basis, so > there's a real chance the hashes will change for people just grabbing a > FreeBSD tree... > > Warner
