Re: CVS commit: src
On Sun, Jun 07, 2020 at 02:43:06PM -0700, Jason Thorpe wrote: > > > On Jun 7, 2020, at 1:57 PM, Joerg Sonnenberger wrote: > > > >> Example? > > > > https://gcc.gnu.org/onlinedocs/gcc-4.7.0/gcc/Function-Attributes.html#index-g_t_0040code_007bdeprecated_007d-attribute_002e-2502 > > I meant an example in our tree. We use __warn_reference() in several places > already. I also don't want to introduce compiler warnings just yet. Yes, we do use it in a number of places. Most of them are ancient, some of the modern cases like in XHR are exactly what I am talking about in triggering bugs. The compiler warnings are strictly superior. Joerg
Re: CVS commit: src
> On Jun 7, 2020, at 1:57 PM, Joerg Sonnenberger wrote: > >> Example? > > https://gcc.gnu.org/onlinedocs/gcc-4.7.0/gcc/Function-Attributes.html#index-g_t_0040code_007bdeprecated_007d-attribute_002e-2502 I meant an example in our tree. We use __warn_reference() in several places already. I also don't want to introduce compiler warnings just yet. -- thorpej
Re: CVS commit: src
On 07.06.2020 22:57, Joerg Sonnenberger wrote: > On Sun, Jun 07, 2020 at 01:27:48PM -0700, Jason Thorpe wrote: >> >>> On Jun 7, 2020, at 1:22 PM, Joerg Sonnenberger wrote: >>> >>> On Sat, Jun 06, 2020 at 09:26:00PM +, Jason R Thorpe wrote: ==> Deprecate mutable prop_data(3) and prop_string(3) objects. The old APIs that support them still exist, but will now produce link-time warnings when used. >>> >>> Please replace them with proper deprecration annotation in the headers. >> >> Example? > > https://gcc.gnu.org/onlinedocs/gcc-4.7.0/gcc/Function-Attributes.html#index-g_t_0040code_007bdeprecated_007d-attribute_002e-2502 > > Joerg > Warnings from headers are worse as whenever a symbol is not pulled from the headers the application has no idea that it is using an old deprecated or broken symbol. (I caught with the linker time warning many issues in .NET on NetBSD) So, I'm against this. signature.asc Description: OpenPGP digital signature
Re: CVS commit: src
On 07.06.2020 22:27, Jason Thorpe wrote: > >> On Jun 7, 2020, at 1:22 PM, Joerg Sonnenberger wrote: >> >> On Sat, Jun 06, 2020 at 09:26:00PM +, Jason R Thorpe wrote: >>> ==> Deprecate mutable prop_data(3) and prop_string(3) objects. The old >>>APIs that support them still exist, but will now produce link-time >>>warnings when used. >> >> Please replace them with proper deprecration annotation in the headers. > > Example? > This is our practice and it is very useful in switching users. If that is obnoxious (in reality informative), then the purpose has been served accordingly. > -- thorpej > signature.asc Description: OpenPGP digital signature
Re: CVS commit: src
On Sun, Jun 07, 2020 at 01:27:48PM -0700, Jason Thorpe wrote: > > > On Jun 7, 2020, at 1:22 PM, Joerg Sonnenberger wrote: > > > > On Sat, Jun 06, 2020 at 09:26:00PM +, Jason R Thorpe wrote: > >> ==> Deprecate mutable prop_data(3) and prop_string(3) objects. The old > >>APIs that support them still exist, but will now produce link-time > >>warnings when used. > > > > Please replace them with proper deprecration annotation in the headers. > > Example? https://gcc.gnu.org/onlinedocs/gcc-4.7.0/gcc/Function-Attributes.html#index-g_t_0040code_007bdeprecated_007d-attribute_002e-2502 Joerg
Re: CVS commit: src
> On Jun 7, 2020, at 1:22 PM, Joerg Sonnenberger wrote: > > On Sat, Jun 06, 2020 at 09:26:00PM +, Jason R Thorpe wrote: >> ==> Deprecate mutable prop_data(3) and prop_string(3) objects. The old >>APIs that support them still exist, but will now produce link-time >>warnings when used. > > Please replace them with proper deprecration annotation in the headers. Example? -- thorpej
Re: CVS commit: src
On Sat, Jun 06, 2020 at 09:26:00PM +, Jason R Thorpe wrote: > ==> Deprecate mutable prop_data(3) and prop_string(3) objects. The old > APIs that support them still exist, but will now produce link-time > warnings when used. Please replace them with proper deprecration annotation in the headers. The link-time warnings are obnoxious due to both various ld bugs and any precision in disabling them. Joerg
Re: CVS commit: src/sys/dev/acpi
On 10/08/2018 18:11, Taylor R Campbell wrote: Module Name:src Committed By: riastradh Date: Fri Aug 10 17:11:56 UTC 2018 Modified Files: src/sys/dev/acpi: acpi_bat.c Log Message: Don't hold up boot: defer acpibat(4) inquiry until threads are running. ok jmcneill@ This makes an old hp510 laptop reset without warning around about dhcpcd time. I don't if it matters but the battery doesn't charge anymore. Nick
