Re: CVS import: src/external/bsd/dhcpcd/dist

[Ryo ONODERA]

Hi,

Roy Marples  writes:

> Hi Ryo
>
> On 15/10/2020 02:23, Ryo ONODERA wrote:
>> dhcpcd-9.3.1 do not detect carrier with cdce(4) and urndis(4) devices.
>> dhcpcd-9.2.0 from pkgsrc-2020Q3 branch works without problems.
>> (Maybe 9.3.0 in NetBSD base worked for me.)
>> 
>> cdce and urndis have no "status" line in ifconfig command output.
>> Is this related to my problem?
>
> Does this fix it?

This patch fixes my problem.

Thank you very much!

> diff --git a/src/if.c b/src/if.c
> index 5f4edb86..deb5280b 100644
> --- a/src/if.c
> +++ b/src/if.c
> @@ -198,10 +198,8 @@ if_is_link_up(const struct interface *ifp)
>   {
>
>   return ifp->flags & IFF_UP &&
> - (ifp->carrier == LINK_UP ||
> -  (ifp->carrier == LINK_UNKNOWN &&
> -   !(ifp->options == NULL ||
> - ifp->options->options & DHCPCD_LINK)));
> + (ifp->carrier != LINK_DOWN ||
> +  (ifp->options != NULL && !(ifp->options->options & DHCPCD_LINK)));
>   }
>
>   int

-- 
Ryo ONODERA // r...@tetera.org
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3

Re: CVS commit: src/external/gpl3/gcc/dist/gcc/config/aarch64

[Robert Elz]

Date:Fri, 16 Oct 2020 04:07:31 +
From:"Thomas Mueller" 
Message-ID:  <20201016052422.e063084...@mail.netbsd.org>

  | Should I add ,linux to the end of the procfs line?

You can, but it isn't needed these days -- I used to mount procfs twice,
once without the linux option, on /proc, and once with, on /emul/linux/proc)
but there seems to be little point in that any more (even though the linux
/proc has a whole bunch of trash that has nothing to do with processes, and
should be, and generally is, available from /kern ... /proc/cpuinfo is an
example of that, though that one is missing from kernfs and should be added
there).

I do add "hidden" to the mount option list though, there's essentially
no point in including /proc /kern /dev/pts (or anything else like those)
in default df output (which is the only thing "hidden" generally affects).

kre

Re: CVS commit: src

[Michał Górny]

On Fri, 2020-10-16 at 04:59 +, Martin Husemann wrote:
> On Thu, Oct 15, 2020 at 05:44:45PM +, Micha? G?rny wrote:
> > Module Name:src
> > Committed By:   mgorny
> > Date:   Thu Oct 15 17:44:45 UTC 2020
> > 
> > Modified Files:
> > src/distrib/sets/lists/tests: mi
> > src/etc/mtree: NetBSD.dist.tests
> > src/tests/sys: Makefile
> > Added Files:
> > src/tests/sys/x86: Makefile t_convert_xmm_s87.c
> > 
> > Log Message:
> > Add tests for process_xmm_to_s87() and process_s87_to_xmm()
> 
> This breaks all non-x86 builds, you need to consistently use the same
> conditions for the makefiles, set lists and mtree files.
> 
> Probably easiest way out: create the directories always (but leave empty
> on non-x86). Alternative: do not use arch specific sub dirs.
> 

Thanks for the suggestion.  I've moved the dirs to mi, and hopefully
that'll resolve it for now.

-- 
Best regards,
Michał Górny

Re: CVS commit: src/sys/dev/pci

[SAITOH Masanobu]

On 2020/10/16 14:53, SAITOH Masanobu wrote:

Module Name:src
Committed By:   msaitoh
Date:   Fri Oct 16 05:53:40 UTC 2020

Modified Files:
src/sys/dev/pci: if_wm.c

Log Message:
  Fixes a problem that the attach function reported
"wm_gmii_setup_phytype: Unknown PHY model. OUI=00, model=" and
"PHY type is still unknown."


This was dmesg only problem. The SGMII read/write functions were correctly set
even though error message was printed. This problem was added in if_wm.c
rev. 1.656 which added SFP support.


Don't call wm_gmii_setup_phytype() three times if
the interface uses SGMII with internal MDIO.

  Tested with I354(Rangeley(SGMII(MDIO))) and I350(SERDES(SFP), SGMII(SFP)).


To generate a diff of this commit:
cvs rdiff -u -r1.690 -r1.691 src/sys/dev/pci/if_wm.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.




--
---
SAITOH Masanobu (msai...@execsw.org
 msai...@netbsd.org)