Re: CVS commit: src/sys/dev/pci
On Tue, May 05, 2009 at 10:21:23AM +, Christoph Egger wrote: > Module Name: src > Committed By: cegger > Date: Tue May 5 10:21:23 UTC 2009 > > Modified Files: > src/sys/dev/pci: if_bnx.c > > Log Message: > Attach on BCM5709 chip. > XXX Firmware fails to complete initialization on this chip. IMHO then it should not attach if it is not working. Bernd
Re: CVS commit: src
On Sun, May 24, 2009 at 09:41:44PM +, Andrew Doran wrote: > Module Name: src > Committed By: ad > Date: Sun May 24 21:41:44 UTC 2009 > > Modified Files: > src/dist/ipf/ipsend: sock.c > src/usr.bin/fstat: fstat.c > > Log Message: > More changes to improve kern_descrip.c. Hmm, is the __NetBSD__Version__ check correct in src/dist/ipf/ipsend/sock.c ? It looks revered. You added some new code, but the check enables the old code for -current. IMHO the __NetBSD__Version__ >= 599001200 should be changed to __NetBSD__Version__ < 599001200 Bernd
Re: CVS commit: src (dist/ipf/ipsend/sock.c:1.15)
On Fri, May 29, 2009 at 10:10:08AM +1000, Geoff Wing wrote:
> On Monday 2009-05-25 00:15 +0200, Bernd Ernesti output:
> :On Sun, May 24, 2009 at 09:41:44PM +, Andrew Doran wrote:
> :> Committed By: ad
> :> Date: Sun May 24 21:41:44 UTC 2009
> :> Modified Files:
> :>src/dist/ipf/ipsend: sock.c
> :>src/usr.bin/fstat: fstat.c
> :> Log Message:
> :> More changes to improve kern_descrip.c.
> :
> :Hmm, is the __NetBSD__Version__ check correct in src/dist/ipf/ipsend/sock.c ?
> :It looks revered. You added some new code, but the check enables
> :the old code for -current.
> :IMHO the
> : __NetBSD__Version__ >= 599001200
> :should be changed to
> : __NetBSD__Version__ < 599001200
>
> This one seems to have fallen through the cracks. It works for current
> since the variable isn't spelt correctly.
Ah, I was wondering why that version check didn't cause more problems.
> Regards,
> Geoff
>
> Index: dist/ipf/ipsend/sock.c
> ===
> RCS file: /cvsroot/src/dist/ipf/ipsend/sock.c,v
> retrieving revision 1.15
> diff -u -r1.15 sock.c
> --- dist/ipf/ipsend/sock.c24 May 2009 21:41:44 - 1.15
> +++ dist/ipf/ipsend/sock.c29 May 2009 00:05:45 -
> @@ -329,7 +329,7 @@
> t = NULL;
>
> o = (struct file **)calloc(1, sizeof(*o) * (fd->fd_lastfile + 1));
> -#if defined(__NetBSD_Version__) && __NetBSD__Version__ >= 599001200
> +#if defined(__NetBSD_Version__) && __NetBSD_Version__ < 599001200
> if (KMCPY(o, fd->fd_ofiles, (fd->fd_lastfile + 1) * sizeof(*o)) == -1)
> {
> fprintf(stderr, "read(%#lx,%#lx,%lu) - u_ofile - failed\n",
That looks correct, but I haven't updated my source tree so I can't test
it at the moment.
Bernd
Re: CVS commit: src/sys/netinet6
On Sat, Jul 25, 2009 at 11:12:09PM +, Tonnerre Lombard wrote: > Module Name: src > Committed By: tonnerre > Date: Sat Jul 25 23:12:09 UTC 2009 > > Modified Files: > src/sys/netinet6: nd6.c nd6_rtr.c > > Log Message: > Instead of using the net.inet6.ip6.accept_rtadv sysctl for all devices, > make net.inet6.ip6.accept_rtadv the default for individual per-device > settings so people can use the ndp(8) utility to set per-device whether > or not to accept route advertisements. > > rtadvd changes to follow. > > (Debated on tech-net@ before but almost two weeks passed by without any > comment on the patch.) There was one from David Young: Message-ID: <20090713160131.gg...@ojctech.com> Date: Mon, 13 Jul 2009 11:01:31 -0500 Bernd
Re: CVS commit: src/etc/rc.d
On Thu, Aug 06, 2009 at 10:54:34AM -0400, Perry E. Metzger wrote: > > Frank Kardel writes: > > Actually we can retire ntpdate in rc unless we are very tight on > > memory. ntpd_flags should add the -g flag. This allows for a big > > (time setting) initial (and only one time) step in ntpd. > > I was made aware of that a few days ago. > > If we go that route, however, we will have to move ntpd to start much > earlier (where ntpdate currently runs), because various tools like the > kdc stuff require that the time be properly set before they execute. > > I'm willing to do that for -current but not for 5.0 (the fixes now in > -current are being pulled up.) Huh? The change itself is controversial, so it should NOT be pulled up right now. Bernd
Re: CVS commit: src/sys/dev/acpi
On Sun, Aug 30, 2009 at 01:19:37PM +0100, David Brownlee wrote: > >From: Jared D. McNeill > > > >Modified Files: > > src/sys/dev/acpi: pckbc_acpi.c > > > >Log Message: > >PR# port-i386/39671: panic while booting with an acpi kernel on a 790GX > >board > > > >If the firmware describes duplicate keyboard controller nodes, don't > >panic > >when the driver fails to map registers. > > Is tis suitable for a pullup to netbsd-5? > Thanks :) He will after it has been tested and I didn't have time yet. Bernd
Re: CVS commit: src/sys/sys
On Wed, Sep 02, 2009 at 03:45:10PM +, Thor Lancelot Simon wrote: > Module Name: src > Committed By: tls > Date: Wed Sep 2 15:45:10 UTC 2009 > > Modified Files: > src/sys/sys: param.h > > Log Message: > Bump __NetBSD_Version__ for previous, per ad@ -- welcome to 5.99.16. For which previous? There is no way to tell it from cvs log. Bernd
Re: CVS commit: src/usr.bin/make
On Thu, Nov 19, 2009 at 12:30:25AM +, Simon J. Gerraty wrote: > Module Name: src > Committed By: sjg > Date: Thu Nov 19 00:30:25 UTC 2009 > > Modified Files: > src/usr.bin/make: make.1 nonints.h parse.c var.c > src/usr.bin/make/unit-tests: Makefile test.exp > Added Files: > src/usr.bin/make/unit-tests: unexport unexport-env > > Log Message: > PR: make.unexport > Reviewed by: > Hmm, this is a little unusual commit message. Bernd
Re: CVS commit: src/sys/dev/acpi
On Fri, Dec 04, 2009 at 07:40:10AM +0100, Christoph Egger wrote: [..] > Christoph - who wonder's why this discussion started after commit > instead of after presenting the patch on tech-kern. I would say because you used a link and didn't attach the actual changes to that mail. Bernd
Re: CVS commit: src/sys/arch/hpcsh/dev
On Sun, Dec 20, 2009 at 12:46:31AM +0900, KIYOHARA Takashi wrote: > Hi! > > > From: "Valeriy E. Ushakov" > Date: Sat, 19 Dec 2009 17:07:31 +0300 > > > On Sat, Dec 19, 2009 at 07:08:23 +, KIYOHARA Takashi wrote: > > > > > Module Name: src > > > Committed By: kiyohara > > > Date: Sat Dec 19 07:08:23 UTC 2009 > > > > > > Modified Files: > > > src/sys/arch/hpcsh/dev: psh3tp.c > > > > > > Log Message: > > > http://mail-index.netbsd.org/source-changes/2009/04/05/msg219234.html > > > > Please, fix this and (the other two) log messages to be > > self-contained. [..] > What do you better log-message? A commit message what you did and not a reference to an external url which may wanish at some point. And looking at that url I have no idea why you used that as the commit message. Could it be that you made the same change as in that commit? Then I would use the same commit message and may add a reference saying that it is a copy of the change in rev 1.23 src/sys/arch/hpcsh/dev/j6x0tp.c Bernd
CVS commit: xsrc/external/mit/libFS/include
Module Name:xsrc Committed By: veego Date: Sun Jan 10 09:57:23 UTC 2010 Modified Files: xsrc/external/mit/libFS/include: config.h Log Message: Regenerate to match current source * VERSION updated to 1.0.2 * Commented entry added (HAVE_LIBWS2_32) To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 xsrc/external/mit/libFS/include/config.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: xsrc/external/mit/libXfont/include
Module Name:xsrc Committed By: veego Date: Sun Jan 10 09:58:24 UTC 2010 Modified Files: xsrc/external/mit/libXfont/include: config.h Log Message: Regenerate to match current source * PACKAGE_STRING, PACKAGE_VERSION, PACKAGE_VERSION_PATCHLEVEL and VERSION updated for 1.4.1 * Commented entry added (HAVE_LIBWS2_32) * LT_OBJDIR is now gone To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 xsrc/external/mit/libXfont/include/config.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: xsrc/external/mit/pixman/include
Module Name:xsrc Committed By: veego Date: Sun Jan 10 09:58:32 UTC 2010 Modified Files: xsrc/external/mit/pixman/include: config.h Log Message: Regenerate to match current source * enable HAVE_POSIX_MEMALIGN To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 xsrc/external/mit/pixman/include/config.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: xsrc/external/mit/xf86-video-ati/include
Module Name:xsrc Committed By: veego Date: Sun Jan 10 09:58:42 UTC 2010 Modified Files: xsrc/external/mit/xf86-video-ati/include: config.h Log Message: Regenerate to match current source * HAVE_FREE_SHADOW, HAVE_PCI_DEVICE_ENABLE, HAVE_XF86CRTCCLIPVIDEOHELPER and HAVE_XF86MODEBANDWIDTH are now enabled. Already changed for netbsd-5 but not on HEAD * Commented entry added (HAVE_XEXTPROTO_71) To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 xsrc/external/mit/xf86-video-ati/include/config.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: xsrc/external/mit/xf86-video-glint/include
Module Name:xsrc Committed By: veego Date: Sun Jan 10 09:58:55 UTC 2010 Modified Files: xsrc/external/mit/xf86-video-glint/include: config.h Log Message: Regenerate to match current source * Commented entry added (HAVE_XEXTPROTO_71) * LT_OBJDIR is now gone To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 xsrc/external/mit/xf86-video-glint/include/config.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: xsrc/external/mit/xf86-video-radeonhd/include
Module Name:xsrc Committed By: veego Date: Sun Jan 10 09:59:05 UTC 2010 Modified Files: xsrc/external/mit/xf86-video-radeonhd/include: config.h Log Message: Regenerate to match current source * HAVE_FREE_SHADOW, HAVE_PCI_DEVICE_ENABLE and XF86CRTCFUNCS_HAS_SETMODEMAJOR are now enabled * Commented entry added (HAVE_XEXTPROTO_71) To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 \ xsrc/external/mit/xf86-video-radeonhd/include/config.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: xsrc/external/mit/xf86-video-siliconmotion/include
Module Name:xsrc Committed By: veego Date: Sun Jan 10 09:59:15 UTC 2010 Modified Files: xsrc/external/mit/xf86-video-siliconmotion/include: config.h Log Message: Regenerate to match current source * HAVE_XMODES is now enabled * Commented entry added (HAVE_XEXTPROTO_71) * LT_OBJDIR is now gone To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 \ xsrc/external/mit/xf86-video-siliconmotion/include/config.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: xsrc/external/mit/xf86-video-sis/include
Module Name:xsrc Committed By: veego Date: Sun Jan 10 09:59:27 UTC 2010 Modified Files: xsrc/external/mit/xf86-video-sis/include: config.h Log Message: Regenerate to match current source * Commented entry added (HAVE_XEXTPROTO_71) To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 xsrc/external/mit/xf86-video-sis/include/config.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: xsrc/external/mit/xf86-video-tseng/include
Module Name:xsrc Committed By: veego Date: Sun Jan 10 09:59:37 UTC 2010 Modified Files: xsrc/external/mit/xf86-video-tseng/include: config.h Log Message: Regenerate to match current source * LT_OBJDIR is now gone To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 xsrc/external/mit/xf86-video-tseng/include/config.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: xsrc/external/mit/xf86-video-wsfb/include
Module Name:xsrc Committed By: veego Date: Sun Jan 10 09:59:46 UTC 2010 Modified Files: xsrc/external/mit/xf86-video-wsfb/include: config.h Log Message: Regenerate to match current source * Commented entries added (HAVE_XF1BPP, HAVE_XF4BPP) To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 xsrc/external/mit/xf86-video-wsfb/include/config.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: xsrc/external/mit/xmag/include
Module Name:xsrc Committed By: veego Date: Sun Jan 10 09:59:55 UTC 2010 Modified Files: xsrc/external/mit/xmag/include: config.h Log Message: Regenerate to match current source * PACKAGE_STRING, PACKAGE_VERSION, PACKAGE_VERSION_PATCHLEVEL and VERSION updated for 1.0.3 * Add several defines for headers To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2 xsrc/external/mit/xmag/include/config.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: xsrc/external/mit
Module Name:xsrc Committed By: veego Date: Sun Jan 10 10:00:14 UTC 2010 Modified Files: xsrc/external/mit/xmodmap/include: config.h xsrc/external/mit/xprop/include: config.h xsrc/external/mit/xwininfo/include: config.h Log Message: Regenerate to match current source * Add several defines for headers To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 xsrc/external/mit/xmodmap/include/config.h cvs rdiff -u -r1.2 -r1.3 xsrc/external/mit/xprop/include/config.h cvs rdiff -u -r1.2 -r1.3 xsrc/external/mit/xwininfo/include/config.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
tn3270 removal (was: CVS commit: src)
On Sat, Jan 16, 2010 at 03:34:26PM +, Roy Marples wrote: > Module Name: src > Committed By: roy > Date: Sat Jan 16 15:34:26 UTC 2010 [..] > Log Message: > Remove tn3270 from base system. > If anyone really needs it then it can be put into pkgsrc. > Importing c3270 into pkgsrc is probably a better option though. Where was this discussed before? Bernd
Re: tn3270 removal (was: CVS commit: src)
On Sat, Jan 16, 2010 at 11:47:18PM +0100, Marc Balmer wrote: > > Am 16.01.2010 um 23:29 schrieb Bernd Ernesti: > > > On Sat, Jan 16, 2010 at 03:34:26PM +, Roy Marples wrote: > >> Module Name: src > >> Committed By: roy > >> Date: Sat Jan 16 15:34:26 UTC 2010 > > [..] > > > >> Log Message: > >> Remove tn3270 from base system. > >> If anyone really needs it then it can be put into pkgsrc. > >> Importing c3270 into pkgsrc is probably a better option though. > > > > Where was this discussed before? > > on tech-userlevel I found that thread which didn't make it obvious that this would happen without a WORKING replacement in pkgsrc. Thats is not the way such things where handled in the past. Especially that not even one week was waited after such an thread started. Bernd
Re: CVS commit: src/sys/ufs/mfs
On Tue, Mar 02, 2010 at 05:20:03PM +, Antti Kantee wrote: > Module Name: src > Committed By: pooka > Date: Tue Mar 2 17:20:03 UTC 2010 > > Modified Files: > src/sys/ufs/mfs: mfs_extern.h mfs_vfsops.c > Added Files: > src/sys/ufs/mfs: mfs_miniroot.c > > Log Message: > Make mfs_initminiroot() mandatory. Allows to remove #ifdef MFS. Who will this and the following change work if I have no 'file-system MFS' in my kernel config? Bernd
Re: CVS commit: [netbsd-5] src/sys/dev/ic
On Sat, Mar 06, 2010 at 10:10:46PM +, Stephen Borrill wrote: > Module Name: src > Committed By: sborrill > Date: Sat Mar 6 22:10:46 UTC 2010 > > Modified Files: > src/sys/dev/ic [netbsd-5]: ahcisata_core.c > > Log Message: > Pull up the following revisions(s) (requested by bouyer in ticket #1317): > sys/dev/ic/ahcisata_core.c: revision 1.23 > > Move ahci_channel_start() after BSY has cleared (do not touch SError while > BSY is asserted). Fixes random behaviour of Intel ESB2 controller with some > models of Hitachi drives (serial console corruption/misfunction, misbehavior > of USB controllers, crazy interrupts crashing the Xen hypervisor, etc.). That was maybe not such a good idea to pull it up: http://mail-index.netbsd.org/current-users/2010/03/01/msg012774.html http://mail-index.netbsd.org/current-users/2010/03/04/msg012810.html Bernd
Re: CVS commit: src/sys/dev
On Sun, Mar 07, 2010 at 09:05:19AM +, SAITOH Masanobu wrote: > Module Name: src > Committed By: msaitoh > Date: Sun Mar 7 09:05:19 UTC 2010 > > Modified Files: > src/sys/dev/mii: igphyreg.h > src/sys/dev/pci: if_wm.c if_wmreg.h if_wmvar.h > > Log Message: > - Add code for WOL, ASF, IPMI and Intel AMT. > - wm_enable_wakeup() is disabled by default. If you want to use WOL with > the Magic Packet, define WM_WOL. What do you mean with define WM_WOL? - a kernel options - or change somone header files? Why is it disabled by default? Is it not stable? Bernd
Re: CVS commit: src/sys/kern
On Thu, Jun 10, 2010 at 07:06:26PM +, Antti Kantee wrote: > Module Name: src > Committed By: pooka > Date: Thu Jun 10 19:06:26 UTC 2010 > > Modified Files: > src/sys/kern: kern_proc.c > > Log Message: > smoke the smoke, hack the hack, *beep* the *beep*, _KERNEL_OPT the _KERNEL_POT Sorry but I do not count that as a valid commit message which describes the change. Would it be possible to use something which really describes what you did? Bernd
Re: CVS commit: xsrc/external/mit/pixman/dist
On Tue, Sep 14, 2010 at 07:39:55AM +, Thomas Klausner wrote: > Module Name: xsrc > Committed By: wiz > Date: Tue Sep 14 07:39:55 UTC 2010 > > Update of /cvsroot/xsrc/external/mit/pixman/dist > In directory ivanova.netbsd.org:/tmp/cvs-serv11532 > > Log Message: > Import pixman-0.18.4. IMHO it would be nice if this could go onto the netbsd-5 branch. Having two versions, base and pkgsrc, is not a good thing. Or downgrade the cairo version so it doesn't require the new pixman version. Bernd
Re: CVS commit: src/external/historical/nawk/dist
On Sun, Oct 17, 2010 at 06:12:23PM -0400, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Sun Oct 17 22:12:23 UTC 2010 > > Modified Files: > src/external/historical/nawk/dist: main.c > > Log Message: > PR/43981: Aleksey Cheusov: awk too small limit on number -f options > remove the limit > should we pullup to 5.x? So there is no real upper limit now? I don't like that. Even 200 seems to be a very high number. Bernd
Re: CVS commit: src/sys/arch/powerpc/oea
On Mon, Nov 15, 2010 at 11:24:21AM +0900, Masao Uebayashi wrote: > On Sun, Nov 14, 2010 at 05:52:51AM +, David Holland wrote: > > On Sun, Nov 14, 2010 at 03:32:44AM +, Masao Uebayashi wrote: > > > XXX What is the conclusion about direct vs. indirect #include from > > headers? > > > > Every header file should include the things it requires to compile. > > Therefore, there should in principle be no cases where a header file > > (or source file) needs to #include something it doesn't itself use. > > This clarifies my long-unanswered question, thanks! > > I've (re)built about 300 kernels in the last days. I've found: > > - sys/sysctl.h's struct kinfo_proc should be moved into sys/proc.h > (I've done this locally). Otherwise all sysctl node providers > includes sys/proc.h and uvm/uvm_extern.h. > (This is where I started...) > > - sys/syscallargs.h should be split into pieces, otherwise all its > users have to know unrelated types (sys/mount.h, sys/cpu.h). > > - sys/proc.h's tsleep(), wakeup(), and friends should be moved into > some common header, because it's widely used API. sys/proc.h will > be used only for "struct proc" related things. What are the issues here that we need to fix this right now? Can you please post changes and/or start a thread about all this before you do them on tech-kern? Bernd
Re: CVS commit: src/bin/dd
On Tue, Nov 23, 2010 at 02:42:04PM +0200, Antti Kantee wrote: > On Tue Nov 23 2010 at 12:28:48 +, Matthias Scheler wrote: > > On Mon, Nov 22, 2010 at 09:04:28PM +, Antti Kantee wrote: > > > Module Name: src > > > Committed By: pooka > > > Date: Mon Nov 22 21:04:28 UTC 2010 > > > > > > Modified Files: > > > src/bin/dd: Makefile args.c dd.c dd.h extern.h position.c > > > > > > Log Message: > > > Add two new operands: "rif" and "rof". They operate exactly like > > > "if" and "of" with the exception that the communicate with a rump > > > kernel instead of the host kernel. > > > > This makes "dd" unusable if only "/" but not "/usr" is mounted because > > it now depends on "/usr/lib/librumpclient.so.0". > > > > Utilities in "/bin" and "/sbin" are supposed to work without > > "/usr" mounted. > > Good catch. Fixed. Sorry 'bout that oversight. That doesn't resolve the concerns why this non standard options were added to dd. Can we go back to the previous versions for the moment and discuss it and then do further changes? Bernd
Re: CVS commit: src/external/bsd/openldap/dist
On Sun, Dec 12, 2010 at 03:25:26PM +, Adam Ciarcinski wrote: > Module Name: src > Committed By: adam > Date: Sun Dec 12 15:25:26 UTC 2010 > > Update of /cvsroot/src/external/bsd/openldap/dist > In directory ivanova.netbsd.org:/tmp/cvs-serv1493 > > Log Message: > Imported openldap-2.4.23 > > Status: > > Vendor Tag: OPENLDAP > Release Tags: OPENLDAP_2_4_23 > > U src/external/bsd/openldap/dist/aclocal.m4 [..] Please include a changelog in your commit message even if it is a small one when you import an updated version. Bernd
Re: CVS commit: src/sys/modules
On Mon, Dec 27, 2010 at 03:43:42PM +, Jared D. McNeill wrote: > Module Name: src > Committed By: jmcneill > Date: Mon Dec 27 15:43:41 UTC 2010 > > Added Files: > src/sys/modules/au8522: Makefile > src/sys/modules/auvitek: Makefile auvitek.ioconf > src/sys/modules/xc5k: Makefile > > Log Message: > xc5k, au8522, and auvitek modules Can you also add the new drivers to the x86 kernel configs amd64/GENERIC, i386/ALL and i386/MONOLITHIC so they can be used? Are they usable on other ports which have usb too? Thanks, Bernd
Re: /var/lock
On Mon, Jan 03, 2011 at 02:46:31PM +0100, Adam Hamsik wrote: > > On Jan,Monday 3 2011, at 1:21 PM, Alan Barrett wrote: > > > On Mon, 03 Jan 2011, rud...@eq.cz wrote: > >> Adam Hamsik wrote: > >>> Modified Files: > >>> src/distrib/sets/lists/base: mi > >>> src/etc/mtree: NetBSD.dist.base > >>> > >>> Log Message: > >>> Add /var/lock directory to base set it's used by LVM and other tools. > >>> Change group owner to operator to enable LVM locking for him. > >> > >> Why is /var/run not the right place for your needs? > > > > Also, where was this discussed? If it was discussed, please > > update hier(7) according to the outcome of the discussion. > > It wasn't discussed, but there were couple of changes to dm driver not done > by me which weren't discussed either. Main reason for them was to allow > operator > to see lvm devices status this was last change needed. I can change it to > /var/run would be > /var/run/locks/ better place for it ? IMHO /var/run/lvm would be better since it is used by lvm. Bernd
Re: CVS commit: src/sys/arch/amd64/conf
On Wed, Feb 16, 2011 at 03:16:58AM +, Jean-Yves Migeon wrote: > Module Name: src > Committed By: jym > Date: Wed Feb 16 03:16:58 UTC 2011 > > Modified Files: > src/sys/arch/amd64/conf: GENERIC INSTALL > > Log Message: > Build certain file-systems and options(7) as module(7). 32 and 64 bits > support are still builtin, as well as FFS, NFS, TMPFS, and most COMPAT > code. Saves approx. 750kiB. > > Reflect this in INSTALL kernel, where we have to support more file systems > statically. > > See http://mail-index.netbsd.org/port-amd64/2011/02/13/msg001318.html Are you going to add a MONOLITHIC kernel to match i386? Bernd
Change the subject (defaulting to c99 in userland) was: CVS commit: src/sys/fs/tmpfs
On Sat, May 14, 2011 at 04:45:07PM +, David Holland wrote: > On Sat, May 14, 2011 at 12:07:20PM -0400, Christos Zoulas wrote: > > If we are going to be compiling the kernel in c99 mode, then I > > suggest that we do the same for userland instead of turning it on > > for userland piecemeal. > > +1 > > is there anything we expect to break? It would be nice if this thread was not just on source-changes-d. Bernd
Re: CVS commit: src
On Mon, Jul 04, 2011 at 08:21:05AM +, Emmanuel Dreyfus wrote: > On Mon, Jul 04, 2011 at 11:09:56AM +0300, Jukka Ruohonen wrote: > > It does not seem right to import something to libc without documentation... > > FreeBSD did not document it, so I attempted to do it in xdr.3 (just committed) Hmm, would that require a new MLINKS line for the new function in the Makefile? And the other set list changes too if it is should be done. Bernd
Re: CVS commit: src/sys/dev
On Mon, Aug 01, 2011 at 11:20:28AM +, Matthias Drochner wrote: > Module Name: src > Committed By: drochner > Date: Mon Aug 1 11:20:28 UTC 2011 > > Modified Files: > src/sys/dev/cardbus: adv_cardbus.c ahc_cardbus.c cardbus.c cardbusreg.h > cardbusvar.h com_cardbus.c ehci_cardbus.c fwohci_cardbus.c > if_ath_cardbus.c if_atw_cardbus.c if_ex_cardbus.c if_fxp_cardbus.c > if_ral_cardbus.c if_re_cardbus.c if_rtk_cardbus.c if_rtw_cardbus.c > if_tlp_cardbus.c njata_cardbus.c njs_cardbus.c ohci_cardbus.c > rbus_ppb.c sdhc_cardbus.c siisata_cardbus.c uhci_cardbus.c > src/sys/dev/pci: pccbb.c > > Log Message: > remove some bloat: [..] > -cardbus always uses 3.3V -- no need for a variable to keep track > of the voltage What about a pccard which can be used with a cardbus slot and so you you get 5V cards too? Bernd
Re: CVS commit: src/usr.bin/unzip
On Thu, Aug 18, 2011 at 01:49:30AM +, Christos Zoulas wrote: > In article <20110817212950.gc16...@britannica.bec.de>, > Joerg Sonnenberger wrote: > >Did you test this change for breaking compatibility with 3rd party > >scripts that parse the output of unzip? > > > > I thought about that, but where does one find such scripts? Providing > a flag to make backwards compatible output is another way of doing it, > but is it worth it? No, just back the change out because the output should look the same as the 'normal' unzip does. The change is nice but should not be done as long as the official unzip still use the old output. Bernd
Re: CVS commit: src/distrib/utils/sysinst
On Sun, Oct 30, 2011 at 12:30:57AM +, Jonathan A. Kollasch wrote: > Module Name: src > Committed By: jakllsch > Date: Sun Oct 30 00:30:57 UTC 2011 > > Modified Files: > src/distrib/utils/sysinst: menus.mi > > Log Message: > As both of the "ns-wide.wide.ad.jp" and "light.imasy.or.jp" IPv6 resolvers > now refuse my queries, replace them with "google-public-dns-a.google.com" > and "google-public-dns-b.google.com". IMHO they should be replaced with ?.root-servers.net entries and not a with an address of a private company. Bernd
Re: CVS commit: src/lib/libutil
Hi, On Thu, Oct 20, 2011 at 09:37:59PM -0400, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Fri Oct 21 01:37:59 UTC 2011 > > Modified Files: > src/lib/libutil: Makefile > > Log Message: > Don't use = to assing SRCS, but += so that we can remove snprintb.c, > which was added elsewhere. I find that a little dangerous. Now SRCS could be defined in the environment which may cause different behaviour like including different not wanted source file, build errors ... I do not know if it would work to move the include of the common Makefile.inc at the end, propably not. And yes the common Makefile.inc already used SRCS+= before. That alone should require to move that include after a normal SRCS= Bernd
Re: CVS commit: src/sys/kern
On Thu, Nov 24, 2011 at 02:55:22PM -0500, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Thu Nov 24 19:55:22 UTC 2011 > > Modified Files: > src/sys/kern: kern_exec.c > > Log Message: > fix incomplete statement. > > > To generate a diff of this commit: > cvs rdiff -u -r1.331 -r1.332 src/sys/kern/kern_exec.c Hmm, why did you change two '#ifdef notyet' to '#ifndef notyet'? See the mail from NONAKA Kimihiro on current-users where he now get 'Cannot get path for pid' messages due too this change. Bernd
Re: CVS commit: src/external/mit/lua/dist/src
On Thu, Mar 15, 2012 at 01:25:06AM +, Alexander Nasonov wrote: > Alexander Nasonov wrote: > > Log Message: > > Don't overwrite Roberto's external $Id. > > This made me realise that all external "$Id" were changed to "Id" > by the previous import and that there is a script that does this > replacement (external/mit/lua/dist/lua2netbsd). I will use it next > time. > > Hopefully, everything else is fine, this was my first import over > existing code. It would be great to have a short summary in the cvs import log what changed in the new version instead of just 'Import Lua 5.1.5'. That doesn't have to be the full changelog. Bernd
Re: CVS commit: [netbsd-6] src/etc/root
Hi Havard,
see the issue at the end.
On Sun, Mar 18, 2012 at 01:20:02AM +0400, Aleksej Saushev wrote:
> "Manuel Bouyer" writes:
>
> > Module Name:src
> > Committed By: bouyer
> > Date: Sat Mar 17 17:22:54 UTC 2012
> >
> > Modified Files:
> > src/etc/root [netbsd-6]: dot.cshrc dot.profile
> >
> > Log Message:
> > Pull up following revision(s) (requested by he in ticket #109):
> > etc/root/dot.cshrc: revision 1.23
> > etc/root/dot.cshrc: revision 1.24
> > etc/root/dot.profile: revision 1.26
> > Can't use Bourne shell syntax here... (Even in comments, for PKG_PATH.)
> > Point first to 6.0 packages, then to packages for 5.1 or 5.0.
> > The latter have reduced usefullness in -current or netbsd-6 until
> > we have a compat50 package.
> >
> >
> > To generate a diff of this commit:
> > cvs rdiff -u -r1.22 -r1.22.4.1 src/etc/root/dot.cshrc
> > cvs rdiff -u -r1.25 -r1.25.4.1 src/etc/root/dot.profile
> >
> > Please note that diffs are not public domain; they are subject to the
> > copyright notices on the relevant files.
> >
> >
> > Modified files:
> ...
> > Index: src/etc/root/dot.profile
> > diff -u src/etc/root/dot.profile:1.25 src/etc/root/dot.profile:1.25.4.1
> > --- src/etc/root/dot.profile:1.25 Tue Jun 21 05:31:29 2011
> > +++ src/etc/root/dot.profileSat Mar 17 17:22:54 2012
> > @@ -1,11 +1,12 @@
> > -# $NetBSD: dot.profile,v 1.25 2011/06/21 05:31:29 erh Exp $
> > +# $NetBSD: dot.profile,v 1.25.4.1 2012/03/17 17:22:54 bouyer Exp $
> >
> > export PATH=/sbin:/usr/sbin:/bin:/usr/bin:/usr/pkg/sbin:/usr/pkg/bin
> > export
> > PATH=${PATH}:/usr/X11R7/bin:/usr/X11R6/bin:/usr/local/sbin:/usr/local/bin
> >
> > # Uncomment the following line(s) to install binary packages
> > # from ftp.NetBSD.org via pkg_add. (See also pkg_install.conf)
> > -#export PKG_PATH="ftp://ftp.NetBSD.org/pub/pkgsrc/packages/NetBSD/$(uname
> > -m)/5.1/All"
> > +#export PKG_PATH=ftp://ftp.NetBSD.org/pub/pkgsrc/packages/NetBSD/$(uname
> > -m)/6.0/All
> > +#export
> > PKG_PATH="${PKG_PATH};ftp://ftp.NetBSD.org/pub/pkgsrc/packages/NetBSD/$(uname
> > -m)/5.1/All"
> > #export
> > PKG_PATH="${PKG_PATH};ftp://ftp.NetBSD.org/pub/pkgsrc/packages/NetBSD/$(uname
> > -m)/5.0/All"
> >
> > export BLOCKSIZE=1k
>
> Why were quotes dropped?
You are asking the wrong person. That change come from the HEAD commit
by Havard, this is just the pullup.
Bernd
Re: CVS commit: src/sys/arch/i386/conf
On Sat, Apr 07, 2012 at 01:40:42AM -0400, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Sat Apr 7 05:40:42 UTC 2012 > > Modified Files: > src/sys/arch/i386/conf: GENERIC > > Log Message: > add apple autodiscovery That needs to be added to the ALL config too. Bernd
Re: CVS commit: [netbsd-6] src/usr.bin/login
Hmm, is rev 1.22 of login_pam.c needed too? date: 2012/04/23 09:27:36; author: martin; state: Exp; lines: +3 -3 trimusername (which does not exist) probably was meant to be called trimloginname (which does exist, at least) Bernd On Mon, May 07, 2012 at 04:24:07PM +, Jeff Rizzo wrote: > Module Name: src > Committed By: riz > Date: Mon May 7 16:24:07 UTC 2012 > > Modified Files: > src/usr.bin/login [netbsd-6]: Makefile common.c common.h k5login.c > login.c login_pam.c > > Log Message: > Pull up following revision(s) (requested by christos in ticket #215): > usr.bin/login/login.c: revision 1.100 > usr.bin/login/login.c: revision 1.101 > usr.bin/login/login.c: revision 1.102 > usr.bin/login/common.c: revision 1.4 > usr.bin/login/common.h: revision 1.2 > usr.bin/login/k5login.c: revision 1.28 > usr.bin/login/k5login.c: revision 1.29 > usr.bin/login/login.c: revision 1.99 > usr.bin/login/login_pam.c: revision 1.21 > usr.bin/login/Makefile: revision 1.53 > usr.bin/login/Makefile: revision 1.54 > usr.bin/login/Makefile: revision 1.55 > usr.bin/login/k5login.c: revision 1.30 > usr.bin/login/k5login.c: revision 1.31 > usr.bin/login/k5login.c: revision 1.32 > usr.bin/login/k5login.c: revision 1.33 > make krb5 compile again. XXX: one function left that is deprecated, what's > the new equivalent? > centralize error function processing. > fix the USE_KERBEROS=no USE_PAM=no build. > remove obsolete comment. > make kerberos work again: > 1. make notickets external > 2. don't use the tty as part of the credential cache, since pts/1 will not > work. > 3. Attempt to use the newer functions, but punt for now since it does not work > yet. > don't abuse the instance variable > move more of the compat code in the compat block. > last commit before I nuke the old code. > no more KRB5_DEPRECATED > > > To generate a diff of this commit: > cvs rdiff -u -r1.52 -r1.52.6.1 src/usr.bin/login/Makefile > cvs rdiff -u -r1.3 -r1.3.8.1 src/usr.bin/login/common.c > cvs rdiff -u -r1.1 -r1.1.8.1 src/usr.bin/login/common.h > cvs rdiff -u -r1.27 -r1.27.46.1 src/usr.bin/login/k5login.c > cvs rdiff -u -r1.98 -r1.98.4.1 src/usr.bin/login/login.c > cvs rdiff -u -r1.20 -r1.20.8.1 src/usr.bin/login/login_pam.c > > Please note that diffs are not public domain; they are subject to the > copyright notices on the relevant files. >
Re: CVS commit: src/sys/dev/sbus
On Fri, Jun 22, 2012 at 11:03:58AM +, Julian Coleman wrote: > Module Name: src > Committed By: jdc > Date: Fri Jun 22 11:03:57 UTC 2012 > > Modified Files: > src/sys/dev/sbus: qe.c > > Log Message: > Fix fallout from revision 1.68, and call ether_ioctl() in the default path. > Patch from John D. Baker in PR port-sparc/46572. > > > To generate a diff of this commit: > cvs rdiff -u -r1.60 -r1.61 src/sys/dev/sbus/qe.c Hmm, something is wrong here. That commit was revision 1.61 so there can not be a revision 1.68. Bernd
libterminfo build does not find tic (was: CVS commit: [netbsd-6] src)
Hi,
On Sat, Jun 23, 2012 at 10:55:00PM +, Jeff Rizzo wrote:
> Module Name: src
> Committed By: riz
> Date: Sat Jun 23 22:54:59 UTC 2012
>
> Modified Files:
[..]
> src/lib/libterminfo [netbsd-6]: Makefile.hash compile.c term.c
> term_private.h terminfo.5.in
[..]
> Added Files:
> src/tools/compat [netbsd-6]: cdbr.h cdbw.h
>
> Log Message:
> Pull up following revision(s) (requested by joerg in ticket #328):
[..]
> lib/libterminfo/Makefile.hash: revision 1.5
[..]
I asume this is broken in -current too, but I just updated my netbsd-6
source and this pullup broke a build if you try to only build
src/lib/libterminfo:
dependall ===> libterminfo
Generating terminfo hash
.
Generating termcap hash
.
..
make: don't know how to make tic. Stop
I'm not sure how to change the following line in Makefile.hash so it
builds:
compiled_terms.c: ${TOOL_TIC}
$ grep -r TOOL_TIC /usr/share/mk/
/usr/share/mk/bsd.own.mk:TOOL_TIC= ${TOOLDIR}/bin/${_TOOL_PREFIX}tic
/usr/share/mk/bsd.own.mk:TOOL_TIC= tic
There is another issue that 'NETBSDSRCDIR=${NETBSDSRCDIR:Q}' has to be
set in Makefile.hash for SCRIPT_ENV too, otherwise you will get problems
if you don't have your source code in /usr/src.
Bernd
Re: CVS commit: src/external/bsd/cron/dist
On Tue, Dec 25, 2012 at 02:13:57PM +, Christos Zoulas wrote: > In article <15993.1356420...@splode.eterna.com.au>, > matthew green wrote: > > > >> On Mon, Dec 24, 2012 at 02:30:46PM -0500, Christos Zoulas wrote: > >> > Modified Files: > >> > src/external/bsd/cron/dist: database.c > >> > > >> > Log Message: > >> > PR/47362: Brian Marcotte: cron is too restrictive on file permissions > >> > Allow file being writable by owner. > >> > XXX: pullup to 6. > > > >wasn't the problem that mode 0400 files were rejected? ie, read-only > >not writable files. > > Yes, it was allowing 0600 and not allowing 0400. Now it allows both. The commit message suggested something differently: Allow file being writable by owner. I haven't checked the source but when does this happen and what is the result of this change now? Can you now change a read only file in /var/cron/tabs with crontab -e? Bernd
