CVS commit: src/sys/dev/raidframe

[Jed Davis]

Module Name:src
Committed By:   jld
Date:   Mon Mar  1 21:10:27 UTC 2010

Modified Files:
src/sys/dev/raidframe: rf_disks.c

Log Message:
When setting up a non-autoconfigured RAID set, fail a component if the
attempt to read its label fails.  OKed by os...@.


To generate a diff of this commit:
cvs rdiff -u -r1.72 -r1.73 src/sys/dev/raidframe/rf_disks.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/sys/dev/raidframe

[Jed Davis]

Module Name:src
Committed By:   jld
Date:   Mon Mar  1 21:10:27 UTC 2010

Modified Files:
src/sys/dev/raidframe: rf_disks.c

Log Message:
When setting up a non-autoconfigured RAID set, fail a component if the
attempt to read its label fails.  OKed by os...@.


To generate a diff of this commit:
cvs rdiff -u -r1.72 -r1.73 src/sys/dev/raidframe/rf_disks.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/dev/raidframe/rf_disks.c
diff -u src/sys/dev/raidframe/rf_disks.c:1.72 src/sys/dev/raidframe/rf_disks.c:1.73
--- src/sys/dev/raidframe/rf_disks.c:1.72	Tue Nov 17 18:54:26 2009
+++ src/sys/dev/raidframe/rf_disks.c	Mon Mar  1 21:10:26 2010
@@ -1,4 +1,4 @@
-/*	$NetBSD: rf_disks.c,v 1.72 2009/11/17 18:54:26 jld Exp $	*/
+/*	$NetBSD: rf_disks.c,v 1.73 2010/03/01 21:10:26 jld Exp $	*/
 /*-
  * Copyright (c) 1999 The NetBSD Foundation, Inc.
  * All rights reserved.
@@ -60,7 +60,7 @@
  ***/
 
 #include 
-__KERNEL_RCSID(0, "$NetBSD: rf_disks.c,v 1.72 2009/11/17 18:54:26 jld Exp $");
+__KERNEL_RCSID(0, "$NetBSD: rf_disks.c,v 1.73 2010/03/01 21:10:26 jld Exp $");
 
 #include 
 
@@ -132,7 +132,9 @@
 			goto fail;
 
 		if (disks[c].status == rf_ds_optimal) {
-			raidfetch_component_label(raidPtr, c);
+			ret = raidfetch_component_label(raidPtr, c);
+			if (ret)
+goto fail;
 		}
 
 		if (disks[c].status != rf_ds_optimal) {

Re: CVS commit: src/crypto/external/bsd/netpgp/dist

[Jed Davis]

"Perry E. Metzger"  writes:

> Alistair Crooks  writes:
>> On Wed, May 06, 2009 at 06:47:37PM +0200, Joerg Sonnenberger wrote:
>>> On Wed, May 06, 2009 at 03:52:15PM +0100, Alistair Crooks wrote:
 You're right, if you believe that the failure of a runtime check for
 the length of time_t being greater than or equal to 4 bytes is
[...]
> Often, when one is writing code like this, one assumes something like
> the idea that time_t is always, say, four bytes. Then, later, someone
> like Christos comes along and turns the value into an eight byte
[...]

The check, it is alleged above, was for >=4 bytes, not ==4.  It seems
unlikely that time_t will ever be made smaller than it is now.

-- 
(let ((C call-with-current-continuation)) (apply (lambda (x y) (x y)) (map
((lambda (r) ((C C) (lambda (s) (r (lambda l (apply (s s) l))  (lambda
(f) (lambda (l) (if (null? l) C (lambda (k) (display (car l)) ((f (cdr l))
(C k)))'((#\J #\d #\D #\v #\s) (#\e #\space #\a #\i #\newline)