Re: CVS commit: src/sys
On 2013-01-30 12:46, Izumi Tsutsui wrote: >> Module Name: src >> Committed By:para >> Date:Tue Jan 29 21:26:25 UTC 2013 >> >> Modified Files: >> src/sys/kern: subr_vmem.c >> src/sys/rump/librump/rumpkern: vm.c >> src/sys/sys: vmem.h vmem_impl.h >> >> Log Message: >> make vmem(9) ready to be used early during bootstrap to replace extent(9) >> pass memory for vmem structs into the initialization function and >> do away with the static pool of vmem structs. >> remove special bootstrapping of the quantum cache pools of the kmem_va_arena >> as memory for pool_caches is allocated via pool_allocator_meta which is >> fully operational at this point. > > Is this change reviewed by vm guys (especailly yamt@)? No, there was some discussion about it with dyoung@ and skrll@ There is no expected functional change to vm. It's all about how some vmem internal structs are allocated during bootstrap to make vmem usable earlier during bootstrap. As always communication could have been better. > If so it's much better to note it in the commit log. sure. -- Lars
Re: CVS commit: src/sys/external/bsd/drm/dist/bsd-core
we should fix the inconsistent use then, the problem ist malloc(9) does not return page aligned memory as kmem does now, for allocations >= PAGE_SIZE and that break drm mmap where does the diagnostic panic occur? lars On Sun, Jan 29, 2012 at 12:49 PM, Matthias Drochner wrote: > Module Name: src > Committed By: drochner > Date: Sun Jan 29 11:49:02 UTC 2012 > > Modified Files: > src/sys/external/bsd/drm/dist/bsd-core: drm_bufs.c > > Log Message: > remove incomplete conversion to kmem_alloc -- inconsistent use > leads at least to diagnostic panics > > > To generate a diff of this commit: > cvs rdiff -u -r1.9 -r1.10 src/sys/external/bsd/drm/dist/bsd-core/drm_bufs.c > > Please note that diffs are not public domain; they are subject to the > copyright notices on the relevant files. >
Re: CVS commit: src
On 05/26/11 18:30, Julio Merino wrote:
> On 5/26/11 5:10 PM, Lars Heidieker wrote:
>> Hi,
>>
>> with those changes I can't compile a kernel without USERCONF option set.
>> The changes in x86_machdep.c should be with in if defs on that options
>>
>> Ok to commit the attached patch?
>>
>> @@ -178,6 +182,7 @@ module_init_md(void)
>> }
>> #endif/* MODULAR */
>>
>> +#if defined(USERCONF)
>> void
>> userconf_bootinfo(void)
>> {
>> @@ -197,6 +202,7 @@ userconf_bootinfo(void)
>> userconf_parse(bi->text);
>> }
>> }
>> +#endif /* defined USERCONF) */
>
> Missing ( before USERCONF.
>
> Also, this is defining userconf_bootinfo conditionally. Did you
> validate that all callers are protected by USERCONF as well? (An
> alternative would be to make the body of userconf_bootinfo conditional,
> not the function itself.
>
Yes, all calls are under option USERCONF.
Re: CVS commit: src
On 05/26/11 06:25, Masao Uebayashi wrote:
> Module Name: src
> Committed By: uebayasi
> Date: Thu May 26 04:25:28 UTC 2011
>
> Modified Files:
> src/share/man/man5: boot.cfg.5
> src/share/man/man8/man8.i386: boot.8
> src/sys/arch/i386/stand/boot: boot2.c
> src/sys/arch/i386/stand/lib: bootmenu.c exec.c libi386.h
> src/sys/arch/i386/stand/pxeboot: main.c
> src/sys/arch/x86/include: bootinfo.h cpu.h
> src/sys/arch/x86/x86: x86_machdep.c
> src/sys/kern: init_main.c subr_userconf.c
> src/sys/sys: userconf.h
>
> Log Message:
> Support userconf(4) command in boot(8)/boot.cfg(5) on i386/amd64.
>
>>From jmmv@, no objections seen in the proposed thread:
>
> http://mail-index.netbsd.org/tech-kern/2009/01/22/msg004081.html
>
>
Hi,
with those changes I can't compile a kernel without USERCONF option set.
The changes in x86_machdep.c should be with in if defs on that options
Ok to commit the attached patch?
Lars
Index: x86_machdep.c
===
RCS file: /cvsroot/src/sys/arch/x86/x86/x86_machdep.c,v
retrieving revision 1.47
diff -u -p -r1.47 x86_machdep.c
--- x86_machdep.c 26 May 2011 04:25:28 - 1.47
+++ x86_machdep.c 26 May 2011 16:09:24 -
@@ -36,6 +36,7 @@ __KERNEL_RCSID(0, "$NetBSD: x86_machdep.
#include "opt_modular.h"
#include "opt_physmem.h"
#include "opt_splash.h"
+#include "opt_userconf.h"
#include
#include
@@ -50,7 +51,10 @@ __KERNEL_RCSID(0, "$NetBSD: x86_machdep.
#include
#include
#include
+
+#if defined(USERCONF)
#include
+#endif /* defined(USERCONF) */
#include
#include
@@ -178,6 +182,7 @@ module_init_md(void)
}
#endif /* MODULAR */
+#if defined(USERCONF)
void
userconf_bootinfo(void)
{
@@ -197,6 +202,7 @@ userconf_bootinfo(void)
userconf_parse(bi->text);
}
}
+#endif /* defined USERCONF) */
void
cpu_need_resched(struct cpu_info *ci, int flags)
Re: CVS commit: src/sys
On Thu, Feb 17, 2011 at 8:27 PM, Matt Thomas wrote: > Module Name: src > Committed By: matt > Date: Thu Feb 17 19:27:13 UTC 2011 > > Modified Files: > src/sys/kern: kern_kthread.c > src/sys/uvm: uvm_extern.h uvm_glue.c > > Log Message: > Add support for cpu-specific uarea allocation routines. Allows different > allocation for user and system lwps. MIPS will use this to map uareas of > system lwp used direct-mapped addresses (to reduce the overhead of > switching to kernel threads). ibm4xx could use to map uareas via direct > mapped addresses and avoid the problem of having the kernel stack not in > the TLB. > > > To generate a diff of this commit: > cvs rdiff -u -r1.30 -r1.31 src/sys/kern/kern_kthread.c > cvs rdiff -u -r1.170 -r1.171 src/sys/uvm/uvm_extern.h > cvs rdiff -u -r1.147 -r1.148 src/sys/uvm/uvm_glue.c > > Please note that diffs are not public domain; they are subject to the > copyright notices on the relevant files. > > Hi, I get the idea of this change but not quite complete. First I got the a compile error on amd64, thats what made me look at it. An ifdef arround the initialization of the uvm_uarea_system_cache is missing. What are the cpu_uarea_alloc functions supposed to do, differently from the PMAP_MAP_POOLPAGE approach, I guess they are able to alloc multiplies of PAGE_SIZE with the correct alignment, if so once they are in place the PMAP_MAP_POOLPAGE is not required any more? I think MIPS currently uses PMAP_MAP_POOLPAGE. And why treat system lwp uareas differently from user ones? Sorry if I miss something here. Greetings, Lars -- Mystische Erklärungen: Die mystischen Erklärungen gelten für tief; die Wahrheit ist, dass sie noch nicht einmal oberflächlich sind. -- Friedrich Nietzsche [ Die Fröhliche Wissenschaft Buch 3, 126 ]
Re: CVS commit: src/sys
Hi, I just got a compile error after the movement of the sysctls. When having netbsd32 compat on a 64bit machine. A conditional include for compat/netbsd32/netbsd32.h fixed this, one like in init_sysctl.c Kind Regards, Lars Am 28.01.2011 19:44 schrieb "Antti Kantee" : > Module Name: src > Committed By: pooka > Date: Fri Jan 28 18:44:45 UTC 2011 > > Modified Files: > src/sys/kern: init_main.c init_sysctl.c kern_descrip.c kern_proc.c > kern_sysctl.c > src/sys/sys: proc.h sysctl.h > > Log Message: > Move sysctl routines from init_sysctl.c to kern_descrip.c (for > descriptors) and kern_proc.c (for processes). This makes them > usable in a rump kernel, in case somebody was wondering. > > > To generate a diff of this commit: > cvs rdiff -u -r1.426 -r1.427 src/sys/kern/init_main.c > cvs rdiff -u -r1.176 -r1.177 src/sys/kern/init_sysctl.c > cvs rdiff -u -r1.209 -r1.210 src/sys/kern/kern_descrip.c > cvs rdiff -u -r1.169 -r1.170 src/sys/kern/kern_proc.c > cvs rdiff -u -r1.229 -r1.230 src/sys/kern/kern_sysctl.c > cvs rdiff -u -r1.299 -r1.300 src/sys/sys/proc.h > cvs rdiff -u -r1.190 -r1.191 src/sys/sys/sysctl.h > > Please note that diffs are not public domain; they are subject to the > copyright notices on the relevant files. >
