Re: CVS commit: [netbsd-7] src/etc/powerd/scripts

2018-08-25 Thread Roy Marples

On 25/08/2018 21:11, m...@netbsd.org wrote:

it's an indicator for how long its been since there was a netbsd
developer using it on a laptop & with working suspend.
"Before we all switched to dhcpcd"

I'm curious if there is one now.


I dunno.
I've had a urtwn for ages and constantly plugged and unplugged it during 
dhcpcd development which is what that bug implies. I've done that a lot 
until maybe netbsd-7.


I dont think suspend has much todo with it.

Roy


Re: CVS commit: [netbsd-7] src/etc/powerd/scripts

2018-08-25 Thread maya
On Sat, Aug 25, 2018 at 07:30:10PM +0100, Roy Marples wrote:
> On 25/08/2018 18:23, m...@netbsd.org wrote:
> > On Sat, Aug 25, 2018 at 07:04:23PM +0200, Martin Husemann wrote:
> > > On Sat, Aug 25, 2018 at 04:58:13PM +, m...@netbsd.org wrote:
> > > > Please see the reply by mlelstv to
> > > > https://gnats.netbsd.org/53233
> > > 
> > > How is that related to this script?
> > > 
> > > Martin
> > 
> > No usb wifi can handle suspend/resume without stopping
> > dhcpcd/wpa_supplicant
> 
> I still fail to see how that's related as dhcpcd was never in that script to
> begin with, only wpa_supplicant. It's also been that way in -current and -8
> for quite a long time now, so this can hardly be a new thing.
> 
> I'm also pretty sure that other applications would open similar sockets to
> dhcpcd or wpa_supplicant from pkgsrc which would need to be in that script
> or similar anyway, otherwise surely panics would still happen?
> 
> Roy

it's an indicator for how long its been since there was a netbsd
developer using it on a laptop & with working suspend.
"Before we all switched to dhcpcd"

I'm curious if there is one now.


Re: CVS commit: [netbsd-7] src/etc/powerd/scripts

2018-08-25 Thread Roy Marples

On 25/08/2018 18:23, m...@netbsd.org wrote:

On Sat, Aug 25, 2018 at 07:04:23PM +0200, Martin Husemann wrote:

On Sat, Aug 25, 2018 at 04:58:13PM +, m...@netbsd.org wrote:

Please see the reply by mlelstv to
https://gnats.netbsd.org/53233


How is that related to this script?

Martin


No usb wifi can handle suspend/resume without stopping
dhcpcd/wpa_supplicant


I still fail to see how that's related as dhcpcd was never in that 
script to begin with, only wpa_supplicant. It's also been that way in 
-current and -8 for quite a long time now, so this can hardly be a new 
thing.


I'm also pretty sure that other applications would open similar sockets 
to dhcpcd or wpa_supplicant from pkgsrc which would need to be in that 
script or similar anyway, otherwise surely panics would still happen?


Roy


Re: CVS commit: [netbsd-7] src/etc/powerd/scripts

2018-08-25 Thread maya
On Sat, Aug 25, 2018 at 07:04:23PM +0200, Martin Husemann wrote:
> On Sat, Aug 25, 2018 at 04:58:13PM +, m...@netbsd.org wrote:
> > Please see the reply by mlelstv to
> > https://gnats.netbsd.org/53233
> 
> How is that related to this script?
> 
> Martin

No usb wifi can handle suspend/resume without stopping
dhcpcd/wpa_supplicant


Re: CVS commit: [netbsd-7] src/etc/powerd/scripts

2018-08-25 Thread Martin Husemann
On Sat, Aug 25, 2018 at 04:58:13PM +, m...@netbsd.org wrote:
> Please see the reply by mlelstv to
> https://gnats.netbsd.org/53233

How is that related to this script?

Martin


Re: CVS commit: [netbsd-7] src/etc/powerd/scripts

2018-08-25 Thread maya
Please see the reply by mlelstv to
https://gnats.netbsd.org/53233

On Sat, Aug 25, 2018 at 02:54:19PM +, Martin Husemann wrote:
> Module Name:  src
> Committed By: martin
> Date: Sat Aug 25 14:54:18 UTC 2018
> 
> Modified Files:
>   src/etc/powerd/scripts [netbsd-7]: sleep_button
> 
> Log Message:
> Pull up following revision(s) (requested by roy in ticket #1631):
> 
>   etc/powerd/scripts/sleep_button: revision 1.11
> 
> Remove the stopping and starting of various network scripts on
> sleep / resume.
> 
> This should no longer be needed now the various applications
> (dhcpcd, ntpd, wpa_supplicant et all) are more aware to the network state
> as all interface carriers should be brought down and up again.
> 
> Fixes PR misc/52397.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.10 -r1.10.22.1 src/etc/powerd/scripts/sleep_button
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
> 

> Modified files:
> 
> Index: src/etc/powerd/scripts/sleep_button
> diff -u src/etc/powerd/scripts/sleep_button:1.10 
> src/etc/powerd/scripts/sleep_button:1.10.22.1
> --- src/etc/powerd/scripts/sleep_button:1.10  Mon Oct 17 23:27:41 2011
> +++ src/etc/powerd/scripts/sleep_button   Sat Aug 25 14:54:18 2018
> @@ -1,6 +1,6 @@
>  #!/bin/sh -
>  #
> -#$NetBSD: sleep_button,v 1.10 2011/10/17 23:27:41 jmcneill Exp $
> +#$NetBSD: sleep_button,v 1.10.22.1 2018/08/25 14:54:18 martin Exp $
>  #
>  # Generic script for sleep button events.
>  #
> @@ -10,13 +10,6 @@
>  
>  case "${2}" in
>  pressed)
> -
> - /etc/rc.d/bluetooth stop
> - /etc/rc.d/ntpd stop
> - /etc/rc.d/dhclient stop
> - /etc/rc.d/network stop
> - /etc/rc.d/wpa_supplicant stop
> -
>   if /sbin/sysctl -q hw.acpi.sleep.state; then
>   /sbin/sysctl -w hw.acpi.sleep.state=3
>   elif /sbin/sysctl -q machdep.xen.suspend; then
> @@ -31,13 +24,6 @@ pressed)
>   # ... waking up
>   sleep 1
>   fi
> -
> - /etc/rc.d/wpa_supplicant start
> - /etc/rc.d/network start
> - /etc/rc.d/dhclient start
> - /etc/rc.d/ntpdate start
> - /etc/rc.d/ntpd start
> - /etc/rc.d/bluetooth start
>   ;;
>  
>  released)
>