Re: CVS commit: src/lib/libm/arch/i387
In article <20110618181640.cff9717...@cvs.netbsd.org>, Joerg Sonnenberger wrote: > >+#define ARG_LONG_DOUBLE_ONE 4(%rsp) >+#define ARG_LONG_DOUBLE_TWO 16(%rsp) > #define ARG_DOUBLE_ONE4(%esp) > #define ARG_DOUBLE_ONE_LSW4(%esp) > #define ARG_DOUBLE_ONE_MSW8(%esp) Shouldn't that be %esp? christos
Re: CVS commit: src/lib/libm/arch/i387
Joerg Sonnenberger writes: > Log Message: > Switch to SSE code, since our gas supports it now. > > > To generate a diff of this commit: > cvs rdiff -u -r1.6 -r1.7 src/lib/libm/arch/i387/s_copysign.S > cvs rdiff -u -r1.5 -r1.6 src/lib/libm/arch/i387/s_copysignf.S Is the change done in s_copysignf.S correct? enami.
Re: CVS commit: src/lib/libm/arch/i387
On Mon, Jun 20, 2011 at 11:25:34AM +0900, tsugutomo.en...@jp.sony.com wrote: > Joerg Sonnenberger writes: > > > Log Message: > > Switch to SSE code, since our gas supports it now. > > > > > > To generate a diff of this commit: > > cvs rdiff -u -r1.6 -r1.7 src/lib/libm/arch/i387/s_copysign.S > > cvs rdiff -u -r1.5 -r1.6 src/lib/libm/arch/i387/s_copysignf.S > > Is the change done in s_copysignf.S correct? It works, but why do you think it is incorrect? Joerg
Re: CVS commit: src/lib/libm/arch/i387
jo...@britannica.bec.de said: > why do you think it is incorrect? You just did an unifdef. best regards Matthias Forschungszentrum Juelich GmbH 52425 Juelich Sitz der Gesellschaft: Juelich Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498 Vorsitzender des Aufsichtsrats: MinDirig Dr. Karl Eugen Huthmacher Geschaeftsfuehrung: Prof. Dr. Achim Bachem (Vorsitzender), Dr. Ulrich Krafft (stellv. Vorsitzender), Prof. Dr.-Ing. Harald Bolt, Prof. Dr. Sebastian M. Schmidt Besuchen Sie uns auf unserem neuen Webauftritt unter www.fz-juelich.de
Re: CVS commit: src/lib/libm/arch/i387
Joerg Sonnenberger writes: > On Mon, Jun 20, 2011 at 11:25:34AM +0900, tsugutomo.en...@jp.sony.com wrote: >> Joerg Sonnenberger writes: >> >> > Log Message: >> > Switch to SSE code, since our gas supports it now. >> > >> > >> > To generate a diff of this commit: >> > cvs rdiff -u -r1.6 -r1.7 src/lib/libm/arch/i387/s_copysign.S >> > cvs rdiff -u -r1.5 -r1.6 src/lib/libm/arch/i387/s_copysignf.S >> >> Is the change done in s_copysignf.S correct? > > It works, but why do you think it is incorrect? I should ask if it is `what you intended' instead of `correct'. Since what you did for thses two files are quite opposite, I guess one of the changes is not waht you want. For s_copysignf.S (not s_copysign.S), you simply removed already #if 0 outed code which uses pand/por instruction and it disagrees with commit message. enami.